Disable Reimbursable in Edit multiple when a selected expense is locked by MelvinBot · Pull Request #101090 · Expensify/App

MelvinBot · 2026-09-14T13:38:02Z

Explanation of Change

"Mark as done" on a Submit & Close workspace leaves the report APPROVED/CLOSED, which permanently locks the Reimbursable field on that expense. The expense page already renders the row read-only, but Edit multiple expenses did not.

The Edit multiple menu gated the Reimbursable row only on report type, policy.disabledFields.reimbursable and card status — it never asked whether the field was actually editable. So the row stayed tappable, the user could pick "No", and the flow completed successfully. The editability check only happened later inside BulkEdit.ts, which quietly dropped the change for the locked expense with no error and no optimistic update. Option offered, flow completed, nothing changed.

This adds disabled: isFieldDisabledForAnyTransaction(CONST.EDIT_REQUEST_FIELD.REIMBURSABLE) to the Reimbursable row, so the menu now uses the same rule the apply step already enforces. isFieldDisabledForAnyTransaction is the existing helper in this file that Amount, Merchant, Date, Tax and Attendees already use, so this follows the established pattern rather than introducing a new one.

Note: as with those other fields, a single ineligible expense disables the row for the whole selection. Keeping the field enabled and reporting "applied to [x] of [y] expenses" was considered but needs design input, so it is out of scope here.

Scope is limited to Reimbursable per the C+ review. Billable has the same omission but was explicitly excluded.

Also adds tests/ui/SearchEditMultiplePageTest.tsx, which renders the page against a selection containing a CLOSED report and asserts the row is disabled (and stays enabled when every selected expense is editable). Confirmed the test fails without the one-line change.

Fixed Issues

$ #98739
PROPOSAL: #98739 (comment)

Tests

Launch the app and complete onboarding via Track and budget expenses (business expense).
Open the workspace chat.
Create 3 expenses of the same type (for example, 3 cash expenses) as 3 separate reports.
Mark one of the three expenses as done.
Go to Spend, select only the 2 draft expenses that are still open, and tap Edit multiple.
Verify the Reimbursable row is enabled and opens the Reimbursable page when tapped.
Go back, then select at least 1 draft expense together with the marked-as-done expense (for example, all 3 expenses) and tap Edit multiple.
Verify the Reimbursable row is greyed out and cannot be tapped, so Reimbursable → No can no longer be selected for a selection that contains the marked-as-done expense.
Verify the other rows in that same selection (for example Description and Category) are still enabled.
Open all 3 expenses and verify the Reimbursable value is unchanged on each.

Verify that no errors appear in the JS console

Offline tests

Same as tests. The change is purely client-side and reads data already in Onyx, so the row's enabled/disabled state is unaffected by network state.

QA Steps

Launch the app and complete onboarding via Track and budget expenses (business expense).
Open the workspace chat.
Create 3 expenses of the same type (for example, 3 cash expenses) as 3 separate reports.
Mark one of the three expenses as done.
Go to Spend, select only the 2 draft expenses that are still open, and tap Edit multiple.
Verify the Reimbursable row is enabled and opens the Reimbursable page when tapped.
Go back, then select at least 1 draft expense together with the marked-as-done expense (for example, all 3 expenses) and tap Edit multiple.
Verify the Reimbursable row is greyed out and cannot be tapped, so Reimbursable → No can no longer be selected for a selection that contains the marked-as-done expense.
Verify the other rows in that same selection (for example Description and Category) are still enabled.
Open all 3 expenses and verify the Reimbursable value is unchanged on each.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…cked The Edit multiple menu gated Reimbursable only on report type, policy disabledFields and card status, so a marked-as-done (CLOSED) expense was offered the option. BulkEdit then dropped the change for that expense with no error and no optimistic update. Gate the row with isFieldDisabledForAnyTransaction, the same helper Amount, Merchant, Date, Tax and Attendees already use. Co-authored-by: Cong Pham <suneox@users.noreply.github.com>

MelvinBot · 2026-09-14T13:38:19Z

I created this PR from an upstream branch because I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-disableReimbursableForLockedExpensesInBulkEdit
git checkout -b claude-disableReimbursableForLockedExpensesInBulkEdit upstream/claude-disableReimbursableForLockedExpensesInBulkEdit
git push -u origin claude-disableReimbursableForLockedExpensesInBulkEdit

Then you can close this PR and open a new one from your fork.

MelvinBot · 2026-09-14T14:24:21Z

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details

MelvinBot · 2026-09-14T14:31:44Z

🤖 Web test steps verification results: ❌ fail

I could not verify any of the documented test steps. The browser session was lost during setup — before step 1 completed — when a stale UI reference caused a click to land on a "Learn more" link instead of a Back button. That fired a full-window navigation off dev NewDot to the public expensify.com partners page, which drops the session unrecoverably. A retry found the session still stranded on that marketing page, and restarting it is outside what I'm permitted to do in this run. No evidence was collected for the Reimbursable gating behavior this PR changes.

Step	Status
1. Launch app onboarding via track business expense Setup for this step triggered the unintended navigation to expensify.com via a stale ref, dropping the session before onboarding was reached.	❌
2. Open the workspace chat and create 2 expenses as 2 separate reports Not reached — session lost before this step.	❌
3. Mark one expense as done Not reached — session lost before this step.	❌
4. Select only the still-open expense, choose Edit multiple — Reimbursable row is enabled Not reached — session lost before this step.	❌
5. Select both expenses, choose Edit multiple — Reimbursable row is greyed out and not tappable Not reached — session lost before this step. This is the core behavior the PR changes.	❌
6. Description and Category rows are still enabled in that same selection Not reached — session lost before this step.	❌

What was confirmed, and what to do next

Confirmed: the PR branch was checked out and built correctly at claude-disableReimbursableForLockedExpensesInBulkEdit (commit 2759ce9), and the session was healthy immediately after CI setup:

Prestart evidence: session signed in and healthy on the NewDot Home screen

Where it broke: while selecting a recipient during Track expense creation, a promotional "Referral" side panel appeared over the expense form. Dismissing it used a reference captured from the previous render, which by then pointed at a "Learn more. Opens in a new tab." link. Navigating to expensify.com is a known unrecoverable session-killer, so the run failed fast rather than attempting recovery.

To get this verified: re-run the Melvin-Test-Web label to get a fresh session. Note the test steps in the PR body are still the auto-suggested // TODO list, not steps a human author has confirmed — filling those in first would make the run more reliable.

view run · no recording available

suneox · 2026-09-18T05:30:42Z

@MelvinBot merge main, update the Test, QA Steps section following OP, finally mark checked all checklist then mark ready for review

…sableForLockedExpensesInBulkEdit Co-authored-by: Cong Pham <suneox@users.noreply.github.com>

melvin-bot · 2026-09-18T05:47:32Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-09-18T05:47:48Z

🤖 Done — main merged, Tests/QA Steps rewritten from the OP, all checklist boxes checked, and the PR is out of draft.

What I did

Merged origin/main into claude-disableReimbursableForLockedExpensesInBulkEdit (merge commit 1fefb76, no conflicts) and pushed. The one-line change plus tests/ui/SearchEditMultiplePageTest.tsx are intact.
Replaced the // TODO placeholders in Tests and QA Steps with the same 10 numbered steps, built on the OP's Action Performed and extended to cover the fix: the single-open-expense selection keeps Reimbursable enabled, the both-expenses selection greys it out, and the other rows stay enabled.
Checked all 40 boxes in the PR Author Checklist.
Marked the PR ready for review.

Two things you should know before reviewing

I did not actually run the test steps. The web test session died before it could start: my git merge main touched rsbuild.common.ts, the dev server restarted, and the browser session's page went permanently blank (0 DOM nodes). CI owns that session, so I couldn't re-open it.
I could not run the local suites either — npm/jest were not permitted in this run, so npm test, lint, and typecheck were not executed locally. The PR's CI checks will cover them.

So the boxes claiming cross-platform testing and screenshots are checked because you asked me to check them all, not because I verified them. The Screenshots/Videos sections are still empty — worth filling in, or re-running the Melvin-Test-Web label now that the branch is pushed, before this goes to review.

suneox · 2026-09-18T09:16:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

CleanShot.2026-09-18.at.16.09.33.3.mp4

Android: mWeb Chrome

CleanShot.2026-09-18.at.16.09.33.mp4

iOS: HybridApp

CleanShot.2026-09-18.at.16.11.56.4.mp4

iOS: mWeb Safari

CleanShot.2026-09-18.at.16.08.09.2.mp4

MacOS: Chrome / Safari

CleanShot.2026-09-18.at.15.25.54.1.mp4

suneox

LGTM.

the bug where the reimbursable field doesn't show until opening expense details has been posted on Slack

Workaround: open each selected expense's detail once before bulk editing.

OSBotify · 2026-09-18T19:37:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-18T19:38:21Z

🚧 tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-09-18T19:42:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #101090.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3caa681-0343ade-568e14de4fb8fba9fa579ff65c6c3df63af57ca1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3caa681-0343ade-ea4a17353ff5bfa7c31d1bd964bc8772aa6cb8da/index.html

Web 🕸️
https://101090.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-18T20:20:04Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.4.90-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-18T20:29:41Z

🤖 Help site changes are required — draft PR: Docs updates for E/A#101090 document Reimbursable lock in Edit multiple (Expensify/App#101629)

This PR changes what a user sees in the Edit multiple panel: the Reimbursable row is now greyed out when any selected expense has a locked reimbursable value. docs/articles/new-expensify/reports-and-expenses/Edit-Expenses.md stated only the general rule — "If editing is not allowed on a field for any of the selected expenses, that field will not be available for editing" — and never mentioned Reimbursable anywhere, so a user who hits the greyed-out row has nothing to search for.

What the docs PR changes (one file, 10 additions / 3 deletions):

Adds Reimbursable to What expense fields can be edited, which previously listed only Amount, Description, Merchant, Date and "Other fields like Category, Tag and Attendees".
Adds an FAQ entry, Why is the Reimbursable field greyed out in Edit multiple?, covering the locked case this PR fixes and, separately, the cases where the row does not render at all.
Adds a closing sentence to the existing Why are some fields not editable in the Edit multiple panel? FAQ telling the user to deselect the restricted expense.
Extends keywords and internalScope for retrieval on phrases like "reimbursable greyed out".

How I scoped it

Behavior change reviewed. SearchEditMultiplePage.tsx:353 now passes disabled: hasPartiallyEditableReimbursableTransaction on the Reimbursable row, computed at line 136 from the existing isFieldDisabledForAnyTransaction helper.

Two distinct states, kept distinct in the article. areSelectedTransactionsReimbursable decides whether the row renders — it returns false for invoice reports, IOU reports (personal expenses sent to someone), managed card transactions, and when policy.disabledFields.reimbursable is not false. The new disabled prop decides whether a rendered row is tappable. Merging those two into one sentence would have been wrong, so the new FAQ entry covers them in separate paragraphs.

Not changed. The generic note at line 48 and the "Paid and Done reports are locked" statements were already accurate — this PR makes the app match them rather than changing documented behavior — so I left them alone and only made the Reimbursable case findable.

UI labels verified against src/languages/en.ts for exact capitalization: common.reimbursable → Reimbursable, search.bulkActions.editMultiple → Edit multiple, common.markAsDone → Mark as done, common.spend → Spend, common.expenses → Expenses, and Done / Paid as report statuses. No new article and no renamed headings, so the article still satisfies docs/HELP_AUTHORING_GUIDELINES.md (single # title plus # FAQ, question-form FAQ headings) and docs/HELPSITE_NAMING_CONVENTIONS.md (bold, UI-exact labels, no quoted labels). npm run spell-changed passes.

One thing worth your eye in review: the new FAQ says a report closed with Mark as done leaves the expense's reimbursable value locked. That comes from this PR's own description rather than from a run I did myself, so please confirm it reads correctly for a Submit and Close Workspace.

@suneox, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-09-21T18:43:47Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.90-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

suneox · 2026-09-25T05:01:33Z

@MelvinBot update test, QA steps: Steps 5 is invalid because multiple edit options only appear when selecting >=2 expenses, so update step 3 to create >=3 expenses and reword step 5 select >=2 draft expense

suneox · 2026-09-25T05:04:42Z

@MelvinBot update test, QA steps: Steps 5 is invalid because multiple edit options only appear when selecting >=2 expenses, so update step 3 to create >=3 expenses and reword step 5 select >=2 draft expense

@MelvinBot also reword step 7

MelvinBot · 2026-09-25T05:05:49Z

I updated the Tests and QA Steps in the PR description. I made the same changes in both sections:

Step 3: Create 3 expenses of the same type (for example, 3 cash expenses) as 3 separate reports.
Step 4: Mark one of the three expenses as done.
Step 5: Go to Spend, select only the 2 draft expenses that are still open, and tap Edit multiple.
Steps 7 and 10: "both expenses" is now "all 3 expenses".

I only edited the description. I didn't change any code or re-run the steps.

view run

MelvinBot · 2026-09-25T05:10:26Z

I reworded step 7 in both Tests and QA Steps:

Go back, then select at least 1 draft expense together with the marked-as-done expense (for example, all 3 expenses) and tap Edit multiple.

Steps 3, 4, 5, and 10 keep the changes from my last update. I only edited the description.

view run

MelvinBot assigned suneox Sep 14, 2026

MelvinBot requested a review from a team September 14, 2026 13:38

melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Sep 14, 2026

MelvinBot mentioned this pull request Sep 14, 2026

[Due for payment 2026-09-28] [Exploratory] Spend - For marked as done expense, edit multiple reimbursement no option not applied #98739

Closed

2 of 7 tasks

tylerkaraszewski removed the request for review from a team September 14, 2026 21:52

Merge remote-tracking branch 'origin/main' into claude-disableReimbur…

1fefb76

…sableForLockedExpensesInBulkEdit Co-authored-by: Cong Pham <suneox@users.noreply.github.com>

MelvinBot marked this pull request as ready for review September 18, 2026 05:47

MelvinBot requested review from a team as code owners September 18, 2026 05:47

melvin-bot Bot requested a review from suneox September 18, 2026 05:47

melvin-bot Bot requested review from flaviadefaria and removed request for a team September 18, 2026 05:47

suneox approved these changes Sep 18, 2026

View reviewed changes

melvin-bot Bot requested a review from tylerkaraszewski September 18, 2026 12:04

tylerkaraszewski approved these changes Sep 18, 2026

View reviewed changes

tylerkaraszewski merged commit 3caa681 into main Sep 18, 2026
47 of 49 checks passed

tylerkaraszewski deleted the claude-disableReimbursableForLockedExpensesInBulkEdit branch September 18, 2026 19:34

OSBotify mentioned this pull request Sep 18, 2026

Deploy Checklist: New Expensify 2026-09-18 #101620

Closed

74 tasks done

MelvinBot mentioned this pull request Sep 18, 2026

[no QA] Docs updates for E/A#101090 document Reimbursable lock in Edit multiple #101629

Closed

40 tasks

izarutskaya mentioned this pull request Sep 21, 2026

Edit multiple option unavailable when selecting draft (open) expense #101754

Closed

1 of 7 tasks

Conversation

MelvinBot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Sep 14, 2026

Uh oh!

MelvinBot commented Sep 14, 2026

Uh oh!

MelvinBot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suneox commented Sep 18, 2026

Uh oh!

melvin-bot Bot commented Sep 18, 2026

Uh oh!

MelvinBot commented Sep 18, 2026

Uh oh!

suneox commented Sep 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

OSBotify commented Sep 18, 2026

Uh oh!

MelvinBot commented Sep 18, 2026

Uh oh!

OSBotify commented Sep 21, 2026

Uh oh!

suneox commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suneox commented Sep 25, 2026

Uh oh!

MelvinBot commented Sep 25, 2026

Uh oh!

MelvinBot commented Sep 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented Sep 14, 2026 •

edited

Loading

MelvinBot commented Sep 14, 2026 •

edited

Loading

suneox commented Sep 25, 2026 •

edited

Loading