Repository navigation
[Due for payment 2026-10-16] [$175] Enable the Go Back button by default (flip shouldUseGoBackButton) #96098
Description
Activity
Blocked by open PRs
We're wrapping up the last PRs
21 remaining items
🤖 I created three draft PRs, one for each site from the re-audit. Please mark each one "Ready for review", or ask me to, when it's ready.
PR Change Use ActivityIndicator below the header while CollectDepositAccount loads Replaces FullScreenLoadingIndicatorwith a largeActivityIndicator(flex1) under the existing headerUse ActivityIndicator inside the Per Diem tab while the selected workspace loads Uses the same View+fullScreenLoading+ActivityIndicatorpattern thatIOURequestStartPagealready uses for its other tab loadersKeep the Go Back button off the global FullScreenLoaderContext overlay Adds an explicit shouldUseGoBackButton={false}with a comment explaining why. Nothing changes onmainuntil the default flips.I left
withPolicyAndFullscreenLoadingunchanged, since the audit marked it as borderline with no change needed.Checks:
lint-changed,typecheck, React Compiler compliance,spell-changed, andoxfmtall pass. 91 of 92 related Jest suites pass.HomePage.test.tsxfailed only in the parallel run and passes on its own on both these branches andmain.Not done: I didn't verify these in a browser, because the loaders only show for a moment. The
TestsandQAsections still need to be filled in.situchandoesn't have a fork of App, so all three branches are on upstream.
- changed the title
[-]Enable the Go Back button by default (flip shouldUseGoBackButton)[/-][+][$175] Enable the Go Back button by default (flip shouldUseGoBackButton)[/+]on Oct 8, 2026 Job added to Upwork: https://www.upwork.com/jobs/~022108076540772533400
Note for payment. 3 additional payments for the above 3. then payment for the upcoming final flip PR.
- $125*3 = $375
Depending on the time spent on the final issue we can figure out that price later.
- changed the title
[-][$175] Enable the Go Back button by default (flip shouldUseGoBackButton)[/-][+][Due for payment 2026-10-16] [$175] Enable the Go Back button by default (flip shouldUseGoBackButton)[/+]on Oct 9, 2026 The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
- Keep the Go Back button off the global FullScreenLoaderContext overlay #103422
- Use ActivityIndicator below the header while CollectDepositAccount loads #103420
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Problem
Once the site refactors are complete, flip
shouldUseGoBackButtononFullScreenLoadingIndicatorto default-trueso every fullscreen loader shows a "Go Back" button after a timeout. This is the step that actually delivers the recoverable error page — it fixes all remaining trapped-user loaders in one change instead of ~66 one-line PRs.Solution
Blocked on #96093, #96094, #96095, #96096 (the bullet-1 refactors must land first, otherwise the flip draws a stray "Go Back" button on top of headers that already have one).
shouldUseGoBackButtondefault totrueinsrc/components/FullscreenLoadingIndicator.tsx.shouldUseGoBackButtonprops from the sites that already pass it.shouldUseGoBackButton={false}on the six auth/transition screens where Go Back is dead or harmful on a cold deep-link start (no history to pop):ValidateLoginPage/index.tsxValidateLoginPage/index.web.tsxUnlinkLoginPageLogInWithShortLivedAuthTokenPageDelegatorConnectGateLogOutPreviousUserPage— actively harmful, not just dead: Go Back can pop/transitionback into the outgoing user's session mid-Onyx.clear()/sign-out.Issue Owner
Current Issue Owner: @situchanUpwork Automation - Do Not Edit