[Due for payment 2026-08-28] [$250] Refactor IOU cluster loaders to ActivityIndicator #96096

Activity

1. Julesssss

   assigned

   Julesssss

   and

   situchan

   on Jul 14, 2026
2. Julesssss

   added

   Engineering

   WeeklyKSv2KSv2

   ImprovementItem broken or needs improvement.Item broken or needs improvement.

   on Jul 14, 2026
3. Julesssss

   added a parent issue on Jul 14, 2026

   • [Tracking] Ensure any error page is recoverable and logs necessary info for more debugging #69850
4. melvin-bot

   added

   Overdue

   on Jul 22, 2026
5. situchan commented on Jul 23, 2026

   

   situchan

   on Jul 23, 2026

   Contributor

   More actions

   @MelvinBot implement this. Create separate PRs per each occurrence

   👀React with 👀1Reacted by melvin-bot
6. melvin-bot

   removed

   Overdue

   on Jul 23, 2026
7. MelvinBot commented on Jul 23, 2026

   

   MelvinBot

   on Jul 23, 2026

   Contributor

   More actions

   🤖 Done — I split the refactor into 4 separate draft PRs, one per occurrence, each assigned to situchan with Expensify/pullerbear requested for review:

   #	PR	Site	Swap
   1	#96823	IOURequestStartPage.tsx:249 — manual-tab pending-reset loader	Unconditional → ActivityIndicator (always embedded; header + tab bar always visible)
   2	#96825	IOURequestStepConfirmation.tsx:808 — isLoadingTransaction early return	Conditional on shouldHideHeader → ActivityIndicator embedded, FullScreenLoadingIndicator standalone RHP
   3	#96827	IOURequestStepConfirmation.tsx:937 — isLoading/scan overlay	Unconditional → ActivityIndicator, preserving the absolute-fill overlay (a header is present in both contexts)
   4	#96835	withFullTransactionOrNotFound.tsx:109 — HOC loader	Conditional on render context → threads shouldHideHeader into the HOC

   All swaps follow the established pattern (ActivityIndicator from @components/ActivityIndicator wrapped in the fullScreenLoading container, reasonAttributes telemetry preserved).

   On the "conditional on render context" note in the issue:

   • The IOURequestStepConfirmation early return (Use ActivityIndicator for embedded IOURequestStepConfirmation loading-transaction early return #96825) uses the existing shouldHideHeader prop.
   • Its overlay (Use ActivityIndicator for the IOURequestStepConfirmation scan/loading overlay #96827) turned out to always sit under a header (inner header in the RHP route, parent header/tab bar when embedded), so that one is unconditional.
   • For the HOC (Use ActivityIndicator for embedded withFullTransactionOrNotFound loader #96835), the loader only ever fires for the Amount step, which renders both standalone (RHP) and embedded (IOURequestStepAmountWithTransactionOnly on the start page). I threaded the existing shouldHideHeader signal into the HOC as an optional prop and set it on the two embedded start-page usages. This touches a widely-used generic HOC — if you'd prefer a different mechanism or prop name (e.g. an explicit isEmbedded), that PR is the one to weigh in on.

   Two things to flag:

   • ⚠️ Local AI tests could not run in my environment (the formatter/linter/typecheck/jest tooling isn't runnable here), so CI is the validation of record — please confirm CI is green, especially the typecheck on Use ActivityIndicator for embedded withFullTransactionOrNotFound loader #96835 (it has a small TS surface change to the HOC). Each PR notes this and leaves the Tests/QA sections for you to complete before marking ready for review.
   • Use ActivityIndicator for embedded IOURequestStepConfirmation loading-transaction early return #96825 and Use ActivityIndicator for the IOURequestStepConfirmation scan/loading overlay #96827 both edit IOURequestStepConfirmation.tsx (and both add the ActivityIndicator import); Use ActivityIndicator for IOURequestStartPage manual-tab pending-reset loader #96823 and Use ActivityIndicator for embedded withFullTransactionOrNotFound loader #96835 both edit IOURequestStartPage.tsx. The edits are on different lines and merge cleanly, but whichever merges second in each pair may show a trivial conflict to resolve.

   Mark each PR "Ready for review" once you've filled in the test steps.
8. melvin-bot

   added

   ReviewingHas a PR in reviewHas a PR in review

   WeeklyKSv2KSv2

   and removed

   WeeklyKSv2KSv2

   on Aug 3, 2026
9. melvin-bot

   changed the title [-]Refactor IOU cluster loaders to ActivityIndicator[/-] [+][$250] Refactor IOU cluster loaders to ActivityIndicator[/+] on Aug 3, 2026
10. melvin-bot commented on Aug 3, 2026

    

    melvin-botbot

    on Aug 3, 2026 – with Melvin Bot

    More actions

    Job added to Upwork: https://www.upwork.com/jobs/~022084391000062890878
11. 17 remaining items

    Load more

12. melvin-bot commented on Aug 10, 2026

    

    melvin-botbot

    on Aug 10, 2026 – with Melvin Bot

    More actions

    Payment Summary

    Resolving PRs:

    • Use ActivityIndicator for IOURequestStartPage manual-tab pending-reset loader #96823

    • Reviewer: @situchan owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
13. melvin-bot

    added

    Overdue

    on Aug 12, 2026
14. mallenexpensify commented on Aug 13, 2026

    

    mallenexpensify

    on Aug 13, 2026

    Last edited by mallenexpensify

    Contributor

    More actions

    Payment Summary

    Contributor+: @situchan due $500 via NewDot
15. mallenexpensify

    closed this as completedon Aug 13, 2026
16. melvin-bot

    removed

    Overdue

    on Aug 13, 2026
17. melvin-bot

    changed the title [-][Due for payment 2026-08-11] [$250] Refactor IOU cluster loaders to ActivityIndicator[/-] [+][Due for payment 2026-08-28] [$250] Refactor IOU cluster loaders to ActivityIndicator[/+] on Aug 21, 2026
18. melvin-bot commented on Aug 21, 2026

    

    melvin-botbot

    on Aug 21, 2026 – with Melvin Bot

    More actions

    @situchan @mallenexpensify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.57-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    • Use ActivityIndicator for embedded IOURequestStepConfirmation loading-transaction early return #96825
    • Use ActivityIndicator for the IOURequestStepConfirmation scan/loading overlay #96827
    • Use ActivityIndicator for embedded withFullTransactionOrNotFound loader #96835

    If no regressions arise, payment will be issued on 2026-08-28. 🎊
19. situchan commented on Aug 23, 2026

    

    situchan

    on Aug 23, 2026

    Contributor

    More actions

    @mallenexpensify the total should be $500 (4 PRs, $125 per each)

    • Use ActivityIndicator for IOURequestStartPage manual-tab pending-reset loader #96823
    • Use ActivityIndicator for embedded IOURequestStepConfirmation loading-transaction early return #96825
    • Use ActivityIndicator for the IOURequestStepConfirmation scan/loading overlay #96827
    • Use ActivityIndicator for embedded withFullTransactionOrNotFound loader #96835
20. mallenexpensify commented on Aug 29, 2026

    

    mallenexpensify

    on Aug 29, 2026

    Contributor

    More actions

    Updated payment amount for @situchan to $500, will reopen for a sec in case @Julesssss disagrees

    👍React with 👍1Reacted by Jules
21. mallenexpensify

    reopened this on Aug 29, 2026
22. melvin-bot commented on Sep 1, 2026

    

    melvin-botbot

    on Sep 1, 2026 – with Melvin Bot

    More actions

    @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
23. melvin-bot

    added

    Overdue

    on Sep 1, 2026
24. mallenexpensify

    closed this as completedon Sep 3, 2026
25. melvin-bot

    removed

    Overdue

    on Sep 3, 2026
26. laurenreidexpensify commented on Sep 3, 2026

    

    laurenreidexpensify

    on Sep 3, 2026

    Contributor

    More actions

    $500 approved @situchan New Expensify