Keep the Go Back button off the global FullScreenLoaderContext overlay

[MelvinBot]

Explanation of Change

FullScreenLoaderContextProvider renders a global FullScreenLoadingIndicator next to {children} at the app root. The attachment picker in the report composer and useFilesValidation turn it on while files are processed. It's a blocking overlay rather than a route loader: the current screen and its header stay underneath it at 0.8 opacity.

Once #96098 flips FullScreenLoadingIndicator's shouldUseGoBackButton default to true, this overlay would show "Go Back" after the timeout. Pressing it would call Navigation.goBack on the screen underneath, but nothing would clear isLoaderVisible, so the overlay would stay on top of whatever screen the user lands on.

This passes an explicit shouldUseGoBackButton={false}, with a comment explaining why, matching the explicit opt-outs added for the auth and transition screens in the flip PR. It doesn't change behavior on main today, because the default is still false. It keeps the overlay unchanged once the default flips.

This is one of the sites found in the re-audit before the flip.

AI tests run locally

• npm run lint-changed: passed
• npm run typecheck: passed
• npm run react-compiler-compliance-check check <file>: passed
• npm run spell-changed: passed
• oxfmt: clean
• Jest --findRelatedTests: 91/92 suites passed. tests/unit/pages/HomePage.test.tsx failed only in the parallel run and passes in isolation on both this change and main, so it's a pre-existing isolation flake.
• Not run: Storybook smoke test (no stories touched), and no browser verification.

Fixed Issues

$ #96098
PROPOSAL: #96098 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

This PR keeps the current behavior. The loader already hides the "Go Back" button by default on main. These steps check that the attachment loader overlay still works and never shows "Go Back".

1. Open any chat.
2. Click + > Add attachment.
3. Leave the file picker open for more than 10 seconds, then cancel it.
4. Verify that the loading overlay disappears, no "Go Back" button appears on it, and the chat is usable.
5. Click + > Add attachment again and select an image.
6. Verify that the attachment preview opens and the loading overlay is gone. (web)
7. Close the preview and verify that the chat is usable.
8. Verify that no errors appear in the JS console.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

🤖 Web test steps verification results: ⚠️ partial

I reached the composer's "Add attachment" action in the Concierge chat, but I couldn't pick a file because the test browser can't drive the native file picker, so the loader overlay this PR changes never rendered. I also couldn't read the JS console on web; network traffic for the whole session showed no 4xx/5xx responses.

Step	Status
Attach a file via the composer attachment picker: the file is processed, the preview opens, the loader shows no "Go Back" button, and the app isn't stuck behind an overlay Clicked "+" → "Add attachment" in the Concierge chat. This opens the native OS file picker, which the web test driver can't control, so no file was selected and the preview and loader overlay never rendered. The chat returned to its normal state with the composer still usable, no stuck overlay, and no "Go Back" label on the page.	❌
Verify that no errors appear in the JS console The web test driver has no console access (logs returns UNSUPPORTED_OPERATION on web), so I couldn't check console errors directly. As an indirect signal, the network log for the whole session showed no 4xx/5xx responses.	❌

To confirm the change, someone needs to attach an image manually on this branch with DevTools open. Check that the loader overlay shows no "Go Back" button and that the console has no errors.

[situchan]

@MelvinBot add QA steps

[MelvinBot]

I added QA steps to the PR description. They check that the attachment loader overlay still clears and never shows "Go Back":

1. Open any chat.
2. Click + > Add attachment.
3. Leave the file picker open for more than 10 seconds, then cancel it.
4. Verify that the loading overlay disappears, no "Go Back" button appears on it, and the chat is usable.
5. Click + > Add attachment again and select an image.
6. Verify that the attachment preview opens and the loading overlay is gone.
7. Close the preview and verify that the chat is usable.
8. Verify that no errors appear in the JS console.

This PR doesn't change behavior on main, because the loader already hides "Go Back" by default, so these are regression checks. The 10-second wait matches the loader's "Go Back" timeout. I left the Tests section for you to fill in.

[situchan]

@MelvinBot mark this PR ready for review

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[MelvinBot]

🤖 Done. This PR is now marked ready for review.

The Tests and QA sections in the PR description still contain the TODO placeholders, so fill those in before review.

[melvin-bot]

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[situchan]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

[JmillsExpensify]

LGTM

[Julesssss]

Comment okay in this case

[github-actions]

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103422.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7ae5a2b-b8010af-0c05f3ac2cda9b4e145f4da735e872ced7fc0600/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7ae5a2b-b8010af-aefc3ebc5afc33e41539418597f45bb49ca6bc1e/index.html

Web 🕸️
https://103422.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

No help site update is needed. This PR only passes an explicit shouldUseGoBackButton={false} to the file-processing loader overlay, so nothing users see changes and no article sentence becomes wrong.

[lanitochka17]

Hello @JmillsExpensify @Julesssss
step 6: Verify that the attachment preview opens and the loading overlay is gone.
Is it for app too?

[lanitochka17]

Theres no "preview" when selecting a image in apps as appears in web

and.mp4

web.mp4

[situchan]

Hello @JmillsExpensify @Julesssss step 6: Verify that the attachment preview opens and the loading overlay is gone. Is it for app too?

There should be no behavioral change compared to production.
If the same happens in production, feel free to ✅

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[Julesssss]

Hello @JmillsExpensify @Julesssss step 6: Verify that the attachment preview opens and the loading overlay is gone. Is it for app too?

There should be no behavioral change compared to production. If the same happens in production, feel free to ✅

Yeah fine to check off, thanks.