Deploy Checklist: New Expensify 2022-04-25

[francoisl]

Release Version: 1.1.57-17
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix for iOS Image Downloads not going through Photos lib #7849

  • QA
  • Accessibility

• Add feature to view Profile Picture in full screen #8483

  • QA
  • Accessibility

• show confirmation screen on password change #8493

  • QA
  • Accessibility

• fix(native): limit max height of composer to 6 lines #8521

  • QA
  • Accessibility

• Fix Input is lost upon opening search page #8535

  • QA
  • Accessibility

• Remove promises that are not used #8538

  • QA
  • Accessibility

• Fixed : One of the popup modal options is highlighted by default #8581

  • QA
  • Accessibility

• Keep focus on textinput field after pressing enter when button is disabled #8591

  • QA
  • Accessibility

• present CTAs as green buttons #8609

  • QA
  • Accessibility

• [No QA] Add context and more specific logs for various fetch errors #8613

  • QA
  • Accessibility

• add welcome message for archived rooms #8632

  • QA
  • Accessibility

• Use userAgent in order to know if device is mobile instead of canUseTouchScreen function #8634

  • QA
  • Accessibility

• [No QA] Improve logging for Pusher error event. Avoid unnecessary reauthentication. Update Pusher. #8635

  • QA
  • Accessibility

• Fix Deep Link for Statements page #8656

  • QA
  • Accessibility

• Remove unused code for setPassword() action #8680

  • QA
  • Accessibility

• Clean up CheckboxWithLabel refactor #8682

  • QA
  • Accessibility

• fix disabled cursor #8689

  • QA
  • Accessibility

• Fix app hang when sending long comments #8691

  • QA
  • Accessibility

• fix: 8329: Resolve fabmenu open multiple time #8692

  • QA
  • Accessibility

• update picker properly on parent value #8698

  • QA
  • Accessibility

• Remove GMT options from timezones #8712

  • QA
  • Accessibility

• Add test tools to make it easier to test Network/reauthentication logic #8713

  • QA
  • Accessibility

• Fix room creation error #8725

  • QA
  • Accessibility

• edited notification content by removing the prefix "new message from" #8726

  • QA
  • Accessibility

• Prevent the Composer from autofilling redundent data #8730

  • QA
  • Accessibility

• add note about enter behaviour & character limits #8732

  • QA
  • Accessibility

• Correct some improper code patterns #8733

  • QA
  • Accessibility

• [No QA] Improve logs for Get calls #8735

  • QA
  • Accessibility

• add spanish translation for "are you sure" #8737

  • QA
  • Accessibility

• Issues/dharmik 8460 ios build against ios 15 #8738

  • QA
  • Accessibility

• Add download option to show in context menu for attachments #8739

  • QA
  • Accessibility

• Fix error message belong to issue #7912 #8741

  • QA
  • Accessibility

• Block SequentialQueue on reauthentication. Reorganize Network / Reauthentication code. #8742

  • QA
  • Accessibility

• update expensify-common #8743

  • QA
  • Accessibility

• Hide billing card in payment methods page #8746

  • QA
  • Accessibility

• [No QA] Update netinfo to 8.3.0 #8750

  • QA
  • Accessibility

• Fix mismatched names for archived policyExpenseChats that the user owns #8751

  • QA
  • Accessibility

• Update CONTRIBUTING.md #8753

  • QA
  • Accessibility

• Find Onyx data on web in IndexedDB #8756

  • QA
  • Accessibility

• fix user select style on anchor tag #8757

  • QA
  • Accessibility

• statepicker refactored to compatible with form #8758

  • QA
  • Accessibility

• Bump onyx version / Preserve active report for each open tab #8759

  • QA
  • Accessibility

• Fix: remove maxLength property for taxId and expiration date fields #8764

  • QA
  • Accessibility

• Re-fetch actions when we move from offline to online #8766

  • QA
  • Accessibility

• Fix MAX_COMMENT_LENGTH const #8767

  • QA
  • Accessibility

• Open old dot links with openOldDotLink() function #8769

  • QA
  • Accessibility

• Refactor Datepicker to work with Form.js #8770

  • QA
  • Accessibility

• show closed action message when a workspace member is removed #8778

  • QA
  • Accessibility

• Make sure external links open in a new tab in Safari #8788

  • QA
  • Accessibility

• Give buttons more space in the preferences page #8789

  • QA
  • Accessibility

• fix link not veritically aligning on android/ios #8795

  • QA
  • Accessibility

• Pusher suffix for internal devs #8796

  • QA
  • Accessibility

• Fix bug where 2FA input field is permanently hidden after resetting password #8801

  • QA
  • Accessibility

• Block activation of primary buttons on background screens #8802

  • QA
  • Accessibility

• Adjust webpack type to apple-app-site-association #8803

  • QA
  • Accessibility

• adding header gap on desktop when screen is small #8805

  • QA
  • Accessibility

• Fix Start over button #8808

  • QA
  • Accessibility

• [No QA] Update various names in ReportActionsView #8813

  • QA
  • Accessibility

• Show full link when hovering over hyperlink #8815

  • QA
  • Accessibility

• Fix IOU badge disappearing after sending money to same user #8816

  • QA
  • Accessibility

• Return exact search matches at the top of the search list #8818

  • QA
  • Accessibility

• [No QA] Move some methods in ReportActionsView #8821

  • QA
  • Accessibility

• Fix AddressSearch input #8826

  • QA
  • Accessibility

• Remove setTimeout(). Fix behavior of create menu. #8827

  • QA
  • Accessibility

• Fix emoji search behavior when deleting all text #8828

  • QA
  • Accessibility

• Create ReportActionsList to organize and Isolate problem code in ReportActionsView #8830

  • QA
  • Accessibility

• Update IOU currency selection for offline first #8834

  • QA
  • Accessibility

• Make both main and sequential queue wait for credentials #8836

  • QA
  • Accessibility

• Refetch IOU data when reconnecting online #8837

  • QA
  • Accessibility

• Fix IOU Options bug #8839

  • QA
  • Accessibility

• [#7971] Disable send if only backticks/whitespace #8844

  • QA
  • Accessibility

• Show failedKYC page when ssn or address is on blacklist #8853

  • QA
  • Accessibility

• Remove monthly settlement beta #8854

  • QA
  • Accessibility

• Limit max digit for rates in Reimburse to be 8 digits - Signed Commit #8856

  • QA
  • Accessibility

• Add SequentialQueue.push(). Fix up tests. #8857

  • QA
  • Accessibility

• Improve reconnection callback #8858

  • QA
  • Accessibility

• Reload wallet data on EnablePayments page when going from offline to online #8859

  • QA
  • Accessibility

• [NO QA] Migrate Crashlitics to Firebase BoM to align library versions #8861

  • QA
  • Accessibility

• Make scripts/set-pusher-suffix.sh executable #8862

  • QA
  • Accessibility

• [No QA] Cleanup Authentication error handling #8865

  • QA
  • Accessibility

• Remove unnecessary _.map in the code for video call menu items #8866

  • QA
  • Accessibility

• Re-get call wait time when going from offline to online #8868

  • QA
  • Accessibility

• merge workspace/reimburse pages #8879

  • QA
  • Accessibility

• [No QA] Fix: Storybook Build  #8880

  • QA
  • Accessibility

• Testing no dots and assistance button #8906

  • QA
  • Accessibility

• Revert 3 dots and change flex styles #8909

  • QA
  • Accessibility

• Revert "trying different styles" and updating react-navigation #8912

  • QA
  • Accessibility

• Revert "Updating navigation packages" #8916

  • QA
  • Accessibility

• Fix unresponsive "forgot" link #8940

  • QA
  • Accessibility

• Revert "Keep focus on textinput field after pressing enter when button is disabled" #8953

  • QA
  • Accessibility

• [CP Staging] bind scrollToBottomAndUpdateLastRead to "this" #8957

  • QA
  • Accessibility

• Fix connect with Plaid on mobile #8969

  • QA
  • Accessibility

• Password btn fix #8970

  • QA
  • Accessibility

Internal QA:

• Add platform to each network request in addition to referer #8771 - @tylerkaraszewski @johnmlee101

Deploy Blockers:

• [$250] IOS - Fab Menu - The pop up opens again after doing double tapping on new chat #8329
• Android/IOS - Invalidate button is not fully visible #8783
• [$4000] mWeb/safari - Menu - "Open app banner" at the top causes spacing issues at the bottom of the browser #8791
• Payments - App is freezing after open Debit Card option under Payments and trying to close #8800
• Payments -Two options are hidden when you click on > button #8922
• [HOLD for payment 2022-05-20]Web - Log in - "Forgot?" password link is unresponsive #8924
• Sending money - User can't search for a currency because the search function is blocked #8926
• Android/IOS - App is crashed when you tap on the unread message indicator #8945
• Android - Connect bank account - Unable to connect with Plaid option, page is skipping #8947
• Log in - "Set Password" button should be disable when field is blank #8962
• iOS - Notifications - New message is not displayed in offline mode #8963
• Login- Error is not highlighted in red when typing a password not meet the requirements #8968

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.57-2 🚀

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.57-3 🚀

[Julesssss]

I marked #8783 as NOT a blocker, as it's not that important overall. It'll get triaged as usual though.

[francoisl]

Hi @mvtglobally, how's it going with the checklist? Anything I can help with to move it forward?

[mvtglobally]

80%done. Will be updating the list in a little bit

[mvtglobally]

@francoisl Team is still working through some of the PRs to complete all platforms coverage.
So far logged Deploy Blocker - #8791

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.57-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.57-4 has been deployed to staging 🎉

[mvtglobally]

@francoisl Regression is completed
#8738 (comment)
#8743 is failing due to #8787. Since its repro in PROD checking off
We are re-testing #8656 as per last message

[mvtglobally]

#8656 is pass after retest. Checking off