Log in - "Set Password" button should be disable when field is blank

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. Start typing a new email account
3. Click Continue
4. Go back to your email and tap on link
5. Change the URL to staging
6. Click on "Set Password" button

Expected Result:

"Set Password" button should be disable when field is blank

Actual Result:

"Set Password" button is enabled when field is blank

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.57.15

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.396.mp4

Recording.395.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thesahindia]

It's a regression from #8680

Need to pass isDisabled={!this.state.isFormValid} here -

App/src/pages/SetPasswordPage.js

Lines 133 to 135 in f25c38f

	<FormAlertWithSubmitButton
	buttonText={buttonText}
	isLoading={this.props.account.loading || this.props.userSignUp.isValidatingEmail}

[chiragsalian]

Thanks @thesahindia. I'll create a PR, test and CP it.

[chiragsalian]

Hi @kbecciv, this should be resolved in version 1.1.57-16 or higher.
Can you retest and confirm? if its resolved feel free to close the issue.

[chiragsalian]

Passed the checklist, closing isssue.