Repository navigation
Deploy Checklist: New Expensify 2024-09-03 #48515
Description
Release Version: 9.0.29-12
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Fix maintainVisibleContentPosition in Safari #47193
- Update UpdatePolicyConnectionConfiguration to be 1:1:1 Part-3 #47628
- iOS: Enable App Groups #47738
- Add CSV import flow to Categories page #47827
- [Advanced Approval Workflows] Display empty state when the member list is empty #47848
- Fix next button isn't aligned at bottom in switch to expensify reason form page #47957
- fix: Onboarding task deeplinks used within the app redirect users to the web #47983
- Fix screen behind overlay changes to WS profile when open WS address page #48002
- [HybridApp] Share auth token in HybridApp #48007
- fix: Workspace - Workspace profile page becomes grayed out when go offline. #48131
- #2 - Don't render report mention markdown if it's not a policy report #48140
- [NoQA] Perf: getStateFromPath config calculations caching #48151
- Fix loading animation is shown when saving substep in BA flow #48155
- [NO QA] [3rd Party Feeds] Company Cards List #48176
- Prevent travel booking for SMS logins #48180
- Tag settings: Billable #47019 #48184
- [No QA] Bump ruby version #48233
- Fix cursor moving before the emoji when typing #48234
- fix: take photo option is missing for uploading a profile avatar image #48311
- Update Expensify-Card-Perks.md #48343
- Create Automatic-Receipt-Audit.md #48350
- Update and rename pay-an-invoice.md to Pay-an-invoice.md #48367
- [NoQA] fix onPaste patch #48370
- Add support for REJECTED report action #48385
- feat: Add new sub-header to More features page. #48389
- [Snyk] Upgrade electron-updater from 6.3.2 to 6.3.3 #48392
- fix storing policyID in q param #48403
- feat: bump react-native-svg to newest version and remove unnecessary … #48413
- Revert "Revert "Consolidate options on settlement "Pay" button"" #48421
- Fix unread indicator isn't cleared when deleting the unread message #48445
- Update WS once for all #48469
- [No QA] Allocate more memory for typecheck #48484
- [NO QA] remove redirect that breaks helpdot workflow #48502
- [No QA] Use dedicated Company Card Feeds beta flag #48505
- [CP Staging] Fix column header going out of screen #48537
- [CP Staging] fix undefined is displayed for GL code #48539
- [CP stag] Fix category header text overlaps with button #48546
- [CP Staging] Make readme notes consistent #48553
- [CP Staging] Handle empty file issue #48556
- [CP Staging] fix: create object uri for import spreadsheets #48574
- [Fix] Edit messages by pressing ArrowUp #48585
- [CP Staging] Fix app crash when clicking on got it button #48609
- [CP Staging] [FIX] Categories - GL code data disappears after importing same file that does not have GL code #48629
- [CP Staging] Revert "Consolidate options on settlement "Pay" button" #48639
Deploy Blockers:
- [HOLD for Payment 9/12] [$125] Categories - Categories explanation sentence overlaps with dropdown button #48528
- [HOLD for payment 2024-09-24] [$125] Import categories - Error message for multiple GL code mappings displays "glCode" #48530
- [HOLD for payment 2024-09-16] [$125] Advanced approvals - Left and right side of the empty state image is cut off #48531
- [HOLD for Payment 2024-09-12][$250] Import categories - Nothing happens after dragging and dropping file into RHP #48533
- [HOLD for payment 2024-09-12][$125] Import categories - GL code field shows undefined when imported category does not have GL code #48535
- Import categories - Column is out of page when importing txt file #48536
- [WAITING ON CHECKLIST - RUSHAT] [$250] Desktop - Categories - App crashes after importing categories and clicking Got it #48540
- Import categories - Corrupted csv file can be uploaded without error message #48542
- [CHECKLIST] [$250] Android & iOS - [Search v2.1] - Selected option is not highlighted #48543
- [$250] mWeb - Chat - Entering multi line text by tapping enter key, cursor goes down instead of next line #48544
- Compose box - Unable to enter edit mode when pressing ArrowUp #48548
- [HOLD for payment 2024-09-12][$250] Can't edit messages by pressing UP ARROW #48549
- [Awaiting Payment] [$250] Thread – Your space opens when leave thread in a new non-validated account #48550
- Import categories - Nothing happens after uploading empty csv file, console error shows up #48554
- [$250] Pay with business BA - System message is "paid x", while thread header is "paid x elsewhere" #48560
- [$125] Import categories - Unable to dismiss "Import successful" modal by clicking outside the modal #48563
- iOS - More features - Word is too close to the page border #48565
- iOS - Import spreadsheet - Offline modal does not show up on iOS app only #48580
- [Hold for payment 2024-09-12] [$250] Categories - GL code data disappears after importing same file that does not have GL code #48587
- Import categories - Column header for category is imported as a category #48644
- [Hold for payment 2024-10-07][$250] Spacing in error message in Fields for Expensify Page are not consistent #48659
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Sep 4, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.29-0 🚀
mountiny commentedon Sep 4, 2024
demoted #48530
lakchote commentedon Sep 4, 2024
demoted #48543 for reasons mentioned here.
mountiny commentedon Sep 4, 2024
demoted #48531 as its very minor ui issue
mvtglobally commentedon Sep 4, 2024
Regression:
TCs - 80% completed
PRs:
#47628 - Pending validation on iOS
#47827 - Pending validation on iOS and Desktop
#47848 - issue repro on Android an iOs only with #48531
#47983 -Pending validation on iOS
#48155 - Pending validation on Android and iOS
#48180 - Pending validation on all platforms
#48385 - Pending validation on all platforms
#48403 - Failing on mWeb, Desktop, Android wit #48240
Blockers:
#48528
#48533
#48535
#48536
#48540
#48542
#48544
#48549
#48550
#48554
mountiny commentedon Sep 4, 2024
demoted #48542
roryabraham commentedon Sep 4, 2024
#48528 is fixed on staging, checking it off
neil-marcellini commentedon Sep 4, 2024
#48565 is a very small issue only for iOS with a specific system font size, so not a blocker.
isagoico commentedon Sep 4, 2024
Checked off #48556 as it was a pass
#48537 is still failing - #48537 (comment)
mvtglobally commentedon Sep 4, 2024
Regression:
TCs - 98% completed
PRs:
#47827 - is failing with #48540 on Desktop
#48180 - Pending validation on mWeb and Android
#48385 - is failing with #48555. checking off
#48403 - Failing on mWeb, Desktop, Android with #48240
Checking CPs
Blockers:
#48533
#48535
#48536
#48540
#48580
#48587
mvtglobally commentedon Sep 5, 2024
Regression is completed
PRs:
#47827 - is failing with #48540 on Desktop
#48180 - Pending validation on mWeb and Android. This PR needs phone enabled travel account and we are not able to validate. Can you check these internally?
#48403 - Failing on mWeb, Desktop, Android with #48240
#48537 - Pending validation on all platforms
#48546 - Pending validation on Android
Blockers:
#48533
#48535
#48536
#48540
#48580
#48587
mountiny commentedon Sep 5, 2024
demoted #48644
mvtglobally commentedon Sep 5, 2024
Checked off new CPs
francoisl commentedon Sep 5, 2024
Demoted #48659
roryabraham commentedon Sep 5, 2024
#47827 had a number of issues, but they've all been fixed or demoted, so I'm checking it off
luacmartins commentedon Sep 5, 2024
Tested #48403. It's a pass
roryabraham commentedon Sep 5, 2024