Skip to content

[$250] Pay with business BA - System message is "paid x", while thread header is "paid x elsewhere" #48560

Closed
Closed
[$250] Pay with business BA - System message is "paid x", while thread header is "paid x elsewhere"#48560
Assignees
allroundexpertsisabelastisser
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Description

@IuliiaHerets
IuliiaHerets
opened on Sep 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4921007
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Admin and member are in the same workspace.
  • Workspace has bank account set up.
  • Member has personal bank account.
  1. Go to staging.new.expensify.com
  2. [Member] Go to workspace chat and submit an expense.
  3. [Admin] Approve the expense.
  4. [Admin] Go offline (because there is an error when paying with business bank account).
  5. [Admin] Click Pay with business bank account.
  6. [Admin] Right click on the paid system message > Reply in thread.

Expected Result:

The thread header for paid system message should be the same as the system message.

Actual Result:

The system message is "paid x", while the thread header shows "paid x elsewhere".

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6592705_1725443475664.20240904_174052.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831454888955451181
  • Upwork Job ID: 1831454888955451181
  • Last Price Increase: 2024-10-09
Issue OwnerCurrent Issue Owner: @

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 4, 2024
  2. melvin-bot
    assigned
    isabelastisser
    and
    AndrewGable
    on Sep 4, 2024

  3. melvin-bot commented on Sep 4, 2024

    @melvin-bot
    melvin-botBot
    on Sep 4, 2024 – with Melvin Bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Sep 4, 2024

    @melvin-bot
    melvin-botBot
    on Sep 4, 2024 – with Melvin Bot

    Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot
    added
    DailyKSv2
    on Sep 4, 2024
  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Sep 4, 2024

  7. github-actions commented on Sep 4, 2024

    @github-actions
    github-actionsBot
    on Sep 4, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. AndrewGable commented on Sep 4, 2024

    @AndrewGable
    AndrewGable
    on Sep 4, 2024
    Contributor

    Trying to figure out which PR introduced this since it doesn't happen on prod

  9. AndrewGable commented on Sep 4, 2024

    @AndrewGable
    AndrewGable
    on Sep 4, 2024
    Contributor

    @bondydaa / @MariaHCD - I am curious if you think this revert revert PR could possibly be related? #48421

  10. AndrewGable commented on Sep 4, 2024

    @AndrewGable
    AndrewGable
    on Sep 4, 2024
    Contributor

    After discussion in Slack we think this is probably a regression from the linked PR, we are going to work with @bondydaa @brandonhenry @allroundexperts to fix this regression!

  11. AndrewGable
    assigned
    bondydaa
    on Sep 4, 2024

  12. 60 remaining items

  13. isabelastisser commented on Oct 3, 2024

    @isabelastisser
    isabelastisser
    on Oct 3, 2024
    Contributor

    @allroundexperts, can you please provide an update? Thanks!

  14. melvin-bot
    removed
    Overdue
    on Oct 3, 2024

  15. allroundexperts commented on Oct 7, 2024

    @allroundexperts
    allroundexperts
    on Oct 7, 2024
    Contributor

    Since this is no longer reproducible, I think we can close this issue.

  16. trjExpensify commented on Oct 7, 2024

    @trjExpensify
    trjExpensify
    on Oct 7, 2024
    Contributor

    Trying to replicate this again and I am not able to get the option for "Pay with business bank account". If I try using Pay with Expensify then the text is for thread title and system message.

    I'm not following this. Can you confirm these steps and include a video to confirm it's not reproducible:

    1. Create a workspace
    2. Enable Workflows > Make or Track Payments > Connect bank account
    3. Submit an expense to the workspace
    4. Click "Pay with Expensify" to pay it via the connected bank account
    5. Click reply on the "paid $x.xx" system message to open a thread
    6. What does the thread header say?

  17. melvin-bot commented on Oct 9, 2024

    @melvin-bot
    melvin-botBot
    on Oct 9, 2024 – with Melvin Bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  18. melvin-bot
    added
    Overdue
    on Oct 9, 2024

  19. jaydamani commented on Oct 10, 2024

    @jaydamani
    jaydamani
    on Oct 10, 2024
    Contributor

    @trjExpensify
    It shows "Paid x with expensify" for both header and message which seems correct.

    1.New.Expensify.-.Google.Chrome.2024-10-10.18-39-25.mp4

    Also unrelated to this issue but, while checking I noticed that an expense is greyed out even when no changes were done after going offline Here are some rough steps for it:

    1. Follow steps from original issue
    2. Turn off offline mode
    3. Clear the error
    4. Check that payment button is visible
    5. Turn on offline mode
    6. Validate that the expense is not greyed out

    Can you confirm if this is something that needs to be changed?

  20. isabelastisser commented on Oct 10, 2024

    @isabelastisser
    isabelastisser
    on Oct 10, 2024
    Contributor

    @allroundexperts can you follow up on the comments above? Thanks!

  21. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Oct 10, 2024

  22. isabelastisser commented on Oct 15, 2024

    @isabelastisser
    isabelastisser
    on Oct 15, 2024
    Contributor

    @allroundexperts, please provide an update! I will DM you for visibility, thanks!

  23. melvin-bot
    removed
    Overdue
    on Oct 15, 2024

  24. trjExpensify commented on Oct 16, 2024

    @trjExpensify
    trjExpensify
    on Oct 16, 2024
    Contributor

    It shows "Paid x with expensify" for both header and message which seems correct.

    Great, so this bug is resolved and we can close this.

  25. trjExpensify
    closed this as completedon Oct 16, 2024
  26. github-project-automation
    moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions