Repository navigation
Deploy Checklist: New Expensify 2024-01-11 #34327
Description
Release Version: 1.4.24-8
Compare Changes: production...staging
This release contains changes from the following pull requests:
- perf: search transition smoother on slower devices #31354
- Remove old receipt selector #32764
- Fix last spacer #32843
- perf: optimise transition on Desktop when click on start chat #33055
- SearchPage list refactor #33080
- [NoQA] Add BrickRoadsUtils #33239
- [TS migration] Migrate 'SignInButtons' component to TypeScript #33404
- [TS migration] Migrate 'ConfirmedRoute.js' component to TypeScript #33529
- Add finallyData as alternative to successData and failureData #33530
- fix: treat certain US numbers as invalid #33605
- Fix: Attachment - The image shakes when you zoom in and back to the original size #33755
- Fix OnyxTab Navigator performance issues on web #33841
- Delete docs/articles/expensify-classic/expensify-partner-program/How-… #33892
- Delete docs/articles/expensify-classic/expensify-card/Expensify-Card-… #33898
- fix: Enable Wallet card flashes briefly when returning from card details page #33931
- Load parent report action from withOnyx in ReportScreen #33970
- fix: Filter out personal details with falsy accountIDs #34015
- Delete docs/articles/expensify-classic/bank-accounts-and-credit-cards… #34036
- Fix: remove overlay on emoji top scroll bar #34077
- Replace all spaces before compare with search text in workspace invite #34083
- [TS migration] Migrate 'ReportActionItemMessageEdit.js' component to TypeScript #34091
- Decrease line height for ReportPreview #34100
- fix: Use the full-height ReportActionsSkeletonView in all cases #34114
- Fix: Emoji skin tone is not updated when changing skin tone while suggestion list is open #34134
- Form Provider Refactor] BaseGetPhysicalCard followup #34147
- Re-order merchant and date field in confirm page #34201
- migrate SettingsSecuritySettings to ts #34215
- [HelpDot] Lower case a, the, and. #34223
- [No QA] Update TS guidelines to allow only new files in TS #34230
- [Snyk] Upgrade electron-updater from 6.1.6 to 6.1.7 #34245
- Fix translation #34256
- [No QA] Fix linter error for type imports #34309
- [No QA] Remove usage of awesome-phonenumber #34312
- fix: enter key not working #34313
- [No QA] Add areChatRoomsEnabled to TeachersUnite.ts #34315
- Fix app crashing on main when route is undefined during Distance Money Request creation #34336
- [CP Staging] Revert "Merge pull request #32422 from tienifr/fix/31503" #34396
- [CP Staging] Only apply interaction for desktop #34449
Deploy Blockers:
- [$500] [HOLD for payment 2024-01-24] [HOLD for payment 2024-01-22] Web - Request money - The 'Enter' button doesn't work for the confirmation money page #34367
- [HOLD for payment 2024-01-24] [HOLD for payment 2024-01-22] FAB - Skeleton appears first on Start chat page #34371
- [HOLD for payment 2024-01-24] [HOLD for payment 2024-01-22] Distance - App crashes when creating distance request quickly after changing date #34375
- Start chat - Transition between Room & Chat tab is not smooth #34377
- [HOLD for payment 2024-01-25] IOU - Page flashes when adding or replacing receipt in details page #34379
- Login - Magic code is sent to wrong email after editing when using ENTER key #34381
- [HOLD for payment 2024-01-24] [HOLD for payment 2024-01-22] iOS - App get crashed on iPad during Sign In flow #34383
- Request money - “Hmm… it’s not here” shown when adding a receipt to a manual request #34388
- Chat - Enter key doesn't work when confirming saving deleted message from keyboard #34397
- [$500] IOU - Error page appear when Employee replace receipt from manual request #34417
- [$250] Chat - Green line and 'New' label disappear after clicking 'New Messages' and scrolling down #34419
- [HOLD for payment 2024-02-07] [$500] Workplace - User is unable to return back to homepage after clicking “here” in Concierge chat #34456
- [$500] Error shows up whenever tried to go back using keyboard #34474
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Jan 11, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.24-4 🚀
Julesssss commentedon Jan 11, 2024
Checking off #34367 as a blocker, it was fixed here
rlinoz commentedon Jan 11, 2024
Demoting #34379
amyevans commentedon Jan 11, 2024
Checked off #34381 after CP completed
francoisl commentedon Jan 11, 2024
Checking off #34397, also fixed with the last CP in 1.4.24-5.
grgia commentedon Jan 12, 2024
Checking off #34375, fixed by contributor / added cherry pick request in deploy room
kavimuru commentedon Jan 12, 2024
Regression is 4% left
#31354 is from past build and checking it off
PR #32764 failing with #34388
PR #33055 failing with #34371
kavimuru commentedon Jan 12, 2024
Regression completed.
Unchecked PRs:
PR #32764 failing with #34388
PR #33055 failing with #34371
CP #34336 iOS build is not available yet
Open Blockers:
#34371
#34417
#34419
#34388
youssef-lr commentedon Jan 14, 2024
Checked off #34419, happening in production as well, and we're not sure yet if it's a bug or a feature.
mountiny commentedon Jan 15, 2024
Demoted #34456
Julesssss commentedon Jan 15, 2024
No new crashes with version
1.4.24.xmountiny commentedon Jan 15, 2024
Timings good and no more deploy blockers and github status looking good too
Julesssss commentedon Jan 15, 2024
Checking off #34449, we manually tested each platform
mountiny commentedon Jan 15, 2024