Repository navigation
[HOLD for payment 2024-01-24] [HOLD for payment 2024-01-22] iOS - App get crashed on iPad during Sign In flow #34383
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.24-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition: user should be Sign In
- Open app
- Write a private domain email (expensifail)
- Tap on Sign In
- Write a magic code from email
Expected Result:
User should be successfully signed in
Actual Result:
App get crashed. If user kill and launch app the app will be crashed again.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native -IPad
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
github-actions commentedon Jan 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 11, 2024
Triggered auto assignment to @dangrous (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.roryabraham commentedon Jan 11, 2024
Interesting that we would see this in a
.tsxfile. This is maybe the first time I've seen this happen in our codebase even with TS coverage.situchan commentedon Jan 11, 2024
@abzokhattab are you able to find offending PR?
There was similar crash (from react-navigation) in the past where TS check didn't catch it - #32515. Fixed in #32525
abzokhattab commentedon Jan 11, 2024
@situchan my proposal is not working so i removed .. if i got a clue on what is happening will post here
dangrous commentedon Jan 11, 2024
Based on a simulator build, the same crash happens on production so I don't think this is a blocker, but it would be great to confirm that
EDIT: I confirmed on a real iPad downloading from the App Store, this is not a blocker (but is a fire)
dangrous commentedon Jan 12, 2024
This has been resolved on staging with #34396, once that's on production we'll be able to close
[-]iOS - App get crashed on iPad during Sign In flow[/-][+][HOLD for payment 2024-01-22] iOS - App get crashed on iPad during Sign In flow[/+]melvin-bot commentedon Jan 15, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-22. 🎊
[-][HOLD for payment 2024-01-22] iOS - App get crashed on iPad during Sign In flow[/-][+][HOLD for payment 2024-01-24] [HOLD for payment 2024-01-22] iOS - App get crashed on iPad during Sign In flow[/+]melvin-bot commentedon Jan 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-24. 🎊
dangrous commentedon Jan 23, 2024
No payment needed here, I'm going to close it out.