[CP Staging] Only apply interaction for desktop by dukenv0307 · Pull Request #34449 · Expensify/App

dukenv0307 · 2024-01-12T16:04:27Z

Details

Only apply interaction for desktop

Fixed Issues

$ #34371
PROPOSAL: #34371 (comment)

Tests

Login with any account
After loading data completely, go to FAB > Start chat
Verify that for desktop, skeleton displays briefly and for other platforms, no skeleton displays

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Login with any account
After loading data completely, go to FAB > Start chat
Verify that for desktop, skeleton displays briefly and for other platforms, no skeleton displays

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-12.at.22.55.51.mov

Android: mWeb Chrome

Screen.Recording.2024-01-12.at.22.53.47.mov

iOS: Native

Screen.Recording.2024-01-12.at.22.57.04.mov

iOS: mWeb Safari

Screen.Recording.2024-01-12.at.22.52.17.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-12.at.22.47.28.mov

MacOS: Desktop

Screen.Recording.2024-01-12.at.23.01.44.mov

melvin-bot · 2024-01-12T16:08:17Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-01-15T01:53:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

startChatAndroidChrome-compressed.mp4

iOS: Native

Screen.Recording.2024-01-15.at.8.04.53.AM.mov

iOS: mWeb Safari

startChatiOSSafari.mp4

MacOS: Chrome / Safari

startChatChrome.mp4

MacOS: Desktop

startChatDesktop.mp4

c3024 · 2024-01-15T02:06:46Z

@@ -0,0 +1,6 @@
+function doInteractionTask(callback: () => void) {
+    callback();
+    return null;


NAB: Is this returning null for explicit clarity or does it serve any other purpose as well?

For desktop we return an interaction and cancel it in cleanup function. For others, only need to return null.

I saw that. By default it returns undefined anyway if we dont add any return statement. Returning null does not appear to serve any additional purpose. That's why I asked.

By default it returns undefined anyway if we don't add any return statement

I know that but I think a function should return something.

c3024

LGTM

mountiny

Thanks for the review moving this ahead as one of only two remaining deploy blockers

OSBotify · 2024-01-15T10:23:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] Only apply interaction for desktop (cherry picked from commit 2c44394)

OSBotify · 2024-01-15T11:10:32Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.24-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Julesssss · 2024-01-15T11:13:44Z

Re-running Desktop so we can confirm the fix -- update: @mountiny beat me to it

Julesssss · 2024-01-15T11:20:38Z

Verified Andrroid, Android mWeb, and Web

OSBotify · 2024-01-15T11:22:22Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.24-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Julesssss · 2024-01-15T11:29:02Z

Verify that for desktop, skeleton displays briefly and for other platforms, no skeleton displays

Verified Desktop ✅

OSBotify · 2024-01-15T11:41:45Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.24-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 3 commits January 12, 2024 22:54

only apply interaction for desktop

6ab6be8

add comment

3172464

Merge branch 'main' into fix/34371

7ed7b59

dukenv0307 marked this pull request as ready for review January 12, 2024 16:08

dukenv0307 requested a review from a team as a code owner January 12, 2024 16:08

melvin-bot Bot requested review from eVoloshchak and removed request for a team January 12, 2024 16:08

mountiny changed the title ~~Only apply interaction for desktop~~ [CP Staging] Only apply interaction for desktop Jan 15, 2024

mountiny assigned dukenv0307 Jan 15, 2024

c3024 reviewed Jan 15, 2024

View reviewed changes

c3024 approved these changes Jan 15, 2024

View reviewed changes

melvin-bot Bot requested a review from iwiznia January 15, 2024 02:42

mountiny approved these changes Jan 15, 2024

View reviewed changes

mountiny merged commit 2c44394 into Expensify:main Jan 15, 2024

OSBotify pushed a commit that referenced this pull request Jan 15, 2024

Merge pull request #34449 from dukenv0307/fix/34371

7169522

[CP Staging] Only apply interaction for desktop (cherry picked from commit 2c44394)

github-actions Bot mentioned this pull request Jan 15, 2024

Deploy Checklist: New Expensify 2024-01-11 #34327

Closed

54 tasks done

melvin-bot Bot mentioned this pull request Jan 15, 2024

[HOLD for payment 2024-01-24] [HOLD for payment 2024-01-22] FAB - Skeleton appears first on Start chat page #34371

Closed

4 of 6 tasks

Conversation

dukenv0307 commented Jan 12, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 12, 2024

Uh oh!

c3024 commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c3024 Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 15, 2024

Uh oh!

OSBotify commented Jan 15, 2024

Uh oh!

Julesssss commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss commented Jan 15, 2024

Uh oh!

OSBotify commented Jan 15, 2024

Uh oh!

Julesssss commented Jan 15, 2024

Uh oh!

OSBotify commented Jan 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

c3024 commented Jan 15, 2024 •

edited

Loading

dukenv0307 Jan 15, 2024 •

edited

Loading

Julesssss commented Jan 15, 2024 •

edited

Loading