Repository navigation
Simple Loot Council: update the module to SLC 0.43.34 - #2698
Merged
EllesmereGaming merged 1 commit intoOct 15, 2026
Merged
EllesmereGaming merged 1 commit into
EllesmereGaming merged 1 commit into
Conversation
Re-export of SimpleLootCouncil ba4e882 (0.43.34) with the EllesmereUI edition at port 4c31129. The module stays held back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 15, 2026
EllesmereGaming
pushed a commit
that referenced
this pull request
Oct 18, 2026
Covers v9.5.5 (after #2698) through v9.6 and drops 12 keys no source produces any more.
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the Simple Loot Council module (
EllesmereUISimpleLootCouncil, added in #2677) from SLC 0.43.17 to 0.43.34. Only the module folder, its options page and the regenerated locale keys change; no other EUI file is touched, and the module stays inHELD_BACK_ADDONS.What changes for the player:
EllesmereUISimpleLootCouncilDBinstead of sharingSimpleLootCouncilDBwith the standalone addon. Sharing one table let the standalone's file overwrite the module's on a character that loaded both. Both names are declared for this one version: the module's first login moves any existingSimpleLootCouncilDBdata across, and later versions drop the old name.EllesmereUISimpleLootCouncil_Camelot.tocis the plain.tocplus## DefaultState: disabled, so the module is off on Forever until enabled. Retail's.tochas noDefaultState, matching v9.5.5.art/logo.tga,art/logo-pride.tga).EllesmereUI.RequestReload(). The full list is in SLC's changelog.Unchanged from #2677: the guardrail fixes. Combat deferral goes through
EllesmereUI.NewCombatQueue(CombatQueue.lua), and spec calls throughC_SpecializationInfo.Module content is SLC
ba4e882(0.43.34) exported with the EUI edition at port4c31129(## X-SLC-Commit,## X-SLC-Port-Commitin the.toc).How was it tested?
2f55ea6). That build is this PR minus the combat-queue andC_SpecializationInfochanges above (CombatQueue.lua,BagShare.lua,Trade.lua,Gear.lua,Specs.lua), which are the same changes Add the Simple Loot Council module #2677 shipped with. This exact commit has not been loaded in game yet.python3 .tools/guardrails.py --base upstream/main --head HEAD: OK (49 Lua files)..tools/extract-locale-keys.sh:_keys.txtis current (one new key,Edition.lua's reworded switch prompt).Screenshots
N/A in this description; I can add the options page on request.
Checklist
SetScripton Blizzard frames🤖 Generated with Claude Code