Skip to content

Simple Loot Council: update the module to SLC 0.43.34 - #2698

Merged
EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
Laxxzz:feat/simple-loot-council-0.43.34
Oct 15, 2026
Merged

EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
Laxxzz:feat/simple-loot-council-0.43.34

Conversation

@Laxxzz

@Laxxzz Laxxzz commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the Simple Loot Council module (EllesmereUISimpleLootCouncil, added in #2677) from SLC 0.43.17 to 0.43.34. Only the module folder, its options page and the regenerated locale keys change; no other EUI file is touched, and the module stays in HELD_BACK_ADDONS.

What changes for the player:

  • Its own saved variables. The module now stores its data in EllesmereUISimpleLootCouncilDB instead of sharing SimpleLootCouncilDB with the standalone addon. Sharing one table let the standalone's file overwrite the module's on a character that loaded both. Both names are declared for this one version: the module's first login moves any existing SimpleLootCouncilDB data across, and later versions drop the old name.
  • WoW: Forever TOC. EllesmereUISimpleLootCouncil_Camelot.toc is the plain .toc plus ## DefaultState: disabled, so the module is off on Forever until enabled. Retail's .toc has no DefaultState, matching v9.5.5.
  • Options page.
    • An art wordmark replaces the panel title; it switches to a pride variant when SLC's pride mode is on (art/logo.tga, art/logo-pride.tga).
    • SLC's version badge, with the Active tag beside it.
    • A one-line status section.
    • Guild ranks as checkboxes beside the council list.
    • The BoE route reason as a free-text box with a colour swatch.
    • The loot funnel guard as a dropdown ("Loot funnel in which groups?").
    • Session timer length under the Session timer switch.
  • New settings:
    • Never prompt to lead SLC groups (off).
    • Open the Loot Queue on a boss kill (on; acts only for the loot master while SLC is active).
    • Add bag items when opening the Loot Queue (off).
    • "Use SLC in groups" now defaults to off.
    • The guild funnel guard now defaults to on, with a one-time chat notice on upgrade.
  • SLC 0.43.18-0.43.34 itself: bag sharing watches only while SLC is active, received comms input is bounded and checked, idle windows cost nothing, and the reloads go through EllesmereUI.RequestReload(). The full list is in SLC's changelog.

Unchanged from #2677: the guardrail fixes. Combat deferral goes through EllesmereUI.NewCombatQueue (CombatQueue.lua), and spec calls through C_SpecializationInfo.

Module content is SLC ba4e882 (0.43.34) exported with the EUI edition at port 4c31129 (## X-SLC-Commit, ## X-SLC-Port-Commit in the .toc).

How was it tested?

  • In game, retail 12.1.5: installed and loaded on my client on EUI 9.5.5 as SLC 0.43.34 (2f55ea6). That build is this PR minus the combat-queue and C_SpecializationInfo changes above (CombatQueue.lua, BagShare.lua, Trade.lua, Gear.lua, Specs.lua), which are the same changes Add the Simple Loot Council module #2677 shipped with. This exact commit has not been loaded in game yet.
  • SLC's offline test suite: the 31 Lua harnesses (the module's EUI halves included), the locale and comment audits, and the exporter self-test, on the assembled tree. All pass.
  • python3 .tools/guardrails.py --base upstream/main --head HEAD: OK (49 Lua files).
  • .tools/extract-locale-keys.sh: _keys.txt is current (one new key, Edition.lua's reworded switch prompt).
  • Static lint of the module (Lua 5.1 syntax, TOC, API existence, removed APIs): 0 errors.

Screenshots

N/A in this description; I can add the options page on request.

Checklist

  • New settings default OFF: two do not. "Open the Loot Queue on a boss kill" is on, and acts only for the loot master while SLC is active. The guild funnel guard is on, a safety prompt before loot is passed outside the guild. Every other new setting is off.
  • Zero cost while disabled: the module does not load; while inert beside the standalone, every file returns at its first line
  • Cheap while enabled: event-driven, no OnUpdate polling; combat deferral through EUI's combat queue
  • No writes onto Blizzard-owned frames; no SetScript on Blizzard frames
  • Tested in-game on live (retail 12.1.5, see above for the delta); no version gates or pre-Midnight APIs added

🤖 Generated with Claude Code

Re-export of SimpleLootCouncil ba4e882 (0.43.34) with the EllesmereUI edition at port 4c31129. The module stays held back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@EllesmereGaming
EllesmereGaming merged commit fe65877 into EllesmereGaming:main Oct 15, 2026
2 checks passed
EllesmereGaming pushed a commit that referenced this pull request Oct 18, 2026
Covers v9.5.5 (after #2698) through v9.6 and drops 12 keys no source
produces any more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants