Skip to content

Simple Loot Council: update the module to SLC 0.43.80 - So much perf you won't pelieve it - #2784

Merged
EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
Laxxzz:feat/simple-loot-council-0.43.80
Oct 19, 2026
Merged

EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
Laxxzz:feat/simple-loot-council-0.43.80

Conversation

@Laxxzz

@Laxxzz Laxxzz commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the Simple Loot Council module (EllesmereUISimpleLootCouncil) from SLC 0.43.34 to 0.43.80, with its options page (EUI_SimpleLootCouncil_Options.lua) and the regenerated locale keys. Nothing else in EUI is touched, and the module stays in HELD_BACK_ADDONS (both .toc files keep their LoadOnDemand hold), exactly as in #2698.

What changes for the player, from SLC's changelog (0.43.35-0.43.80):

  • Loot queue and bags. Opening the queue, and other council members' bag lists arriving while it is open, no longer re-read every item; leaving it open no longer stutters every five minutes; a council member added while the queue is open gets their bags listed within seconds.
  • Council window. The coin tag reads "Bonus rolls: 2 of 4" (or "Bonus rolls: 2" where the Adventure Guide has no answer) and follows the right boss.
  • Loot history. Council snapshots take less than half the space in the saved file (converted at first login); a long history opens, sorts and searches faster; a history row edited while only one of the two SLC editions was enabled is no longer lost when both are enabled again.
  • Raid team and guild roster. Reading a large guild's roster is several times quicker; a group leader with a guild-rank council does much less work when guildmates log in and out; the addon no longer re-reads the roster while solo or in combat.
  • Wishlists. wowaudit is a Wishlist and Sim source, with its own file for the wowaudit desktop client (SimpleLootCouncil_SimulationImport) so updates no longer erase its data; the response window shows the wishlist tier and sim gain on their own line.
  • Groups and prompts. Entering a delve no longer asks about using SLC for the group formed with the companion; joining a group outside an instance no longer asks to disable the guild loot funnel guard.
  • Other. Dates read day/month/year; the Options sections are in a new order; the council and raid team tooltips were trimmed; several smaller fixes.
  • Saved variables. The module declares only EllesmereUISimpleLootCouncilDB now, the second name Simple Loot Council: update the module to SLC 0.43.34 #2698 kept for one version is dropped, and both editions share one table (newer file wins, history rows by their edit time).

Module content is SLC 655f316 (0.43.80) exported with the EUI edition at port bd26233 (## X-SLC-Commit, ## X-SLC-Port-Commit in the .toc). _keys.txt loses eight strings of the old standalone-switch prompt.

How was it tested?

  • In game, retail 12.1.5, on a test build of this exact module code (the same export with the held-back lines removed, because a held-back module does not load) on top of EUI 9.6: the EUI edition loaded and ran at SLC 0.43.80 (edition eui), and the history edit survived the standalone's newer saved file with both editions enabled ("the standalone's file is newer; 1 record(s) merged").
  • SLC's offline test suite (the 30-odd Lua harnesses, the module's EUI halves included), the locale and comment audits and the exporter self-test, on the assembled tree: all pass.
  • python3 .tools/guardrails.py --base upstream/main --head HEAD: OK (68 Lua files).
  • .tools/extract-locale-keys.sh: _keys.txt is current.
  • Not run in game: the delve prompt change (needs a real delve).

Screenshots

N/A.

Checklist

  • No new settings: wowaudit is one more choice in the existing Wishlist source setting
  • Zero cost while disabled: the module stays held back, so it does not load
  • Cheap while enabled: event-driven, no OnUpdate polling; this release is mostly about doing less work
  • No writes onto Blizzard-owned frames; no SetScript on Blizzard frames
  • Tested in-game on live (retail 12.1.5, see above); no version gates or pre-Midnight APIs added

Module folder and its options page re-exported from SLC 655f316 (0.43.80) with the EUI
edition at port bd26233. The module stays in HELD_BACK_ADDONS.
@Laxxzz Laxxzz changed the title Simple Loot Council: update the module to SLC 0.43.80 Simple Loot Council: update the module to SLC 0.43.80 - So much perf you won't pelieve it Oct 19, 2026
@EllesmereGaming
EllesmereGaming merged commit fcfbb14 into EllesmereGaming:main Oct 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants