Skip to content

refactor(bench): retire legacy Graph500 scale orchestration (#959) - #1061

Merged
DecisionNerd merged 4 commits into
mainfrom
cursor/959-legacy-retirement-rebased-5258
Sep 1, 2026
Merged

DecisionNerd merged 4 commits into
mainfrom
cursor/959-legacy-retirement-rebased-5258

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Rebased onto current main (includes merged #1067 BenchExec Fly fixes). Retires duplicated legacy Graph500 scale orchestration after parity gate wiring.

#900 ladder evidence ingested

Fly S18/S19 qualification on ext4 volume (vol_40od6de197mn01p4, performance-16x):

Rung Status Wall time Peak RSS
S18 passed 298s 7.0 GB
S19 passed 943s 14.0 GB

Commit 6255f9393362c996b5840566d255569761e881d7 image; S19 required 16 GB BenchExec memlimit.

make -C benchmarks parity-gate
# ready_for_retirement: true

Changes

  • Remove legacy scripts/ci/validate-g500-ladder-qualification.py and related CI glue superseded by the isolated benchmarks/ harness.
  • Rename .github/workflows/g500-certification.yml → progressive-ladder.yml and update gate registry.
  • Extend parity gate criteria tracker; preserve historical migration fixtures.
  • Ingest real S18/S19 rung bundles into fixtures/parity/ladder-bundle/.

Validation

make -C benchmarks smoke-python
make gate-registry-check
make -C benchmarks parity-gate  # ready_for_retirement: true
cd benchmarks && PYTHONPATH=harness uv run --locked python -m unittest tests.test_progressive_run tests.test_benchexec_authority -q

Fixes #959

Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Note

Retire legacy Graph500 scale orchestration and replace g500-certification with progressive-ladder

  • Removes legacy G500 Make targets (bench-g500-scale20, bench-g500-ladder, g500-ladder-qualification, g500-ladder-qualification-check) and deletes associated CI scripts (build-g500-ladder-qualification.py, validate-g500-ladder-qualification.py) and their test suites.
  • Renames the operator handoff workflow from g500-certification to progressive-ladder across progressive-ladder.yml, gate-registry.json, and test-ci-storage-policy.py. The registry now uses workflow id progressive-ladder with updated evidence contract, freshness, and sha semantics; operator_gates is cleared.
  • Adds _legacy_orchestration_present helper to parity_gate.py that scans the Makefile, workflow file, and gate-registry.json for leftover g500-certification artifacts. The parity_gate_status function uses this to set the legacy_orchestration_retired_with_coverage criterion.
  • Removes ignored Rust tests (run_ladder, scale20_public_facade_engineering_green, certification lifecycle tests) from scale_g500_ladder.rs and scale_g500_scale20.rs and updates module docs to point to the progressive-ladder operator.
  • Adds new parity fixtures under benchmarks/fixtures/parity/ladder-bundle/ for S18/S19 rungs, manifest, and teardown inventory.
  • Risk: Any out-of-tree consumers referencing the g500-certification workflow id or the removed Make targets will break; the operator_gates list in gate-registry.json is now empty, so consumers must use the workflows entry instead.

Macroscope summarized f2b623e.

cursoragent and others added 2 commits September 1, 2026 04:11
Remove Makefile targets, g500-ladder-qualification scripts, and ignored
provisioned Rust ladder/certification tests superseded by the benchmarks/
progressive qualification operator. Rename the operator handoff workflow to
progressive-ladder.yml and teach parity_gate to detect legacy retirement.

Historical validate-g500-certification.py and migration fixtures remain for
parity comparison. Full #959 gate green still requires ingested #900 ladder
bundles; do not merge until parity-gate reports ready_for_retirement.

Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
progressive-ladder now lives in gate-registry workflows (not operator_gates)
after g500-certification retirement; update the wiring test accordingly.

Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 553c80a0-3333-4448-a148-2f891b947925

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added core Core source code changes documentation Improvements or additions to documentation ci-cd CI/CD configuration changes tooling Developer tooling and automation labels Sep 1, 2026
cursoragent and others added 2 commits September 1, 2026 11:34
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Real BenchExec qualification runs on Fly ext4 volume:
- S18 passed (298s wall, commit 6255f93 image)
- S19 passed (943s wall, 16 GB memlimit)

Parity comparisons: accepted_difference for both rungs.

Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
@DecisionNerd
DecisionNerd marked this pull request as ready for review September 1, 2026 11:34
@DecisionNerd
DecisionNerd merged commit 1b2cbcd into main Sep 1, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the cursor/959-legacy-retirement-rebased-5258 branch September 1, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI/CD configuration changes core Core source code changes documentation Improvements or additions to documentation tooling Developer tooling and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

epic(bench): standardize BenchExec and Divan measurement and retire custom benchmark harnesses

2 participants