Repository navigation
fix(bench): mount /work in BenchExec containers for Fly S18 (#900) - #1067
Conversation
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
When /work is mounted, BenchExec containers need an explicit --dir for the stage, overlay/hidden mount flags matching the admission fixture, and profile paths rewritten to /work/workspace/sNN so generate/ingest share durable ext4 locations instead of overlay-relative workspace paths. Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
#900) BenchExec overlay allowed gf to stage import temps off the /work ext4 volume; commit then failed with Invalid cross-device link (os error 18). Use --read-only-dir / with --full-access-dir /work and TMPDIR=/work/tmp. Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
…on (#900) Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Summary
Fixes Fly S18 BenchExec failures for durable progressive qualification on ext4
/workvolumes.Root causes fixed
workspace/sNN/...paths lived in BenchExec overlay, invisible on/work. Fixed by rewriting to absolute/work/workspace/sNN/...paths and--full-access-dir /work.Invalid cross-device link (os error 18). Fixed by--read-only-dir /(only/workwritable) plusTMPDIR=/work/tmp.Evidence
tests.test_progressive_run→ 20 passed82d334c751de78on 50GB volume:publication_committed: true, 4.4M rows)Volume
Extended Fly volume
vol_40od6de197mn01p4from 10GB → 50GB for S18+S19 headroom.Closes #900 (partial — full S18/S19 ladder evidence pending run completion)
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Mount
/workin BenchExec containers and raise memlimit to 16 GB for Fly S18_provider_volume_mountedin progressive_run.py; when/workis a mount point, staging uses it for HOME, TMPDIR, tool directory, profile paths, and benchmark XMLprofile.jsonto absolute/work/workspace/s{scale}paths and wraps staged executables in a shell script that setsTMPDIR=/work/tmp"- Raises BenchExec memory limit from 4 GB to 16 GB in provider-volume mode and configures container flags to expose/workwhile hiding/runand/tmpstage/rawto an outputs{scale}-failure-rawdirectory on non-zero BenchExec exit or ingestion errors_safe_stagenow requiresscaleas a keyword argument; any callers not updated will raiseTypeError. Evidence path inTool.cmdlinechanges to/work/tmp/graphforge-certify-evidence.jsonwhen/workis mounted, which may break readers expectingevidence.jsonin the stage rootMacroscope summarized ae061bb.