Skip to content

test(bench): update parity gate tests for post-retirement state (#959) - #1068

Merged
DecisionNerd merged 1 commit into
mainfrom
cursor/959-parity-gate-test-fix-5258
Sep 1, 2026
Merged

DecisionNerd merged 1 commit into
mainfrom
cursor/959-parity-gate-test-fix-5258

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Fixes smoke-python failure on main after #1061 merged ingested S18/S19 ladder bundles.

  • test_gate_status_reports_retirement_ready: expects ready_for_retirement: true now that legacy orchestration is retired and ladder evidence is ingested.
  • test_ingested_ladder_bundle_runs_comparisons: ladder bundle now contains two rung files.
cd benchmarks && PYTHONPATH=harness uv run --locked python -m unittest tests.test_parity_gate -q
make -C benchmarks smoke-python
Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Note

Update parity gate tests to expect retirement-ready state and non-empty comparisons

  • test_gate_status_reports_retirement_ready (renamed from test_gate_status_reports_retirement_blocked) now asserts ready_for_retirement is True, with harness_authoritative_after_ladder_comparison met and no blocked_by, and legacy_orchestration_retired_with_coverage met with legacy_present=False evidence.
  • test_ingested_ladder_bundle_runs_comparisons (renamed from test_empty_ladder_bundle_returns_no_comparisons) now expects compare_ladder_bundle to return two comparison matrices, each with a truthy overall field, instead of an empty list.

Macroscope summarized bf8b2ac.

Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 645d96e3-3411-47f6-ba66-91c3729be751

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@DecisionNerd
DecisionNerd marked this pull request as ready for review September 1, 2026 12:12
@DecisionNerd
DecisionNerd merged commit b365ed0 into main Sep 1, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the cursor/959-parity-gate-test-fix-5258 branch September 1, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants