Skip to content

merge queue: checking #782 on main (7a7a2bd), stacked on 4 pull requests ahead - #797

Closed
mergify[bot] wants to merge 16 commits into
mainfrom
mergify/merge-queue/fe428f05ec
Closed

mergify[bot] wants to merge 16 commits into
mainfrom
mergify/merge-queue/fe428f05ec

Conversation

@mergify

@mergify mergify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🎉 This pull request has been checked successfully and will be merged soon. 🎉

#782 is queued for merge on branch main (7a7a2bd).

Stacked behind 4 pull requests queued ahead of this batch, not part of it. These checks run on a tip that also carries their commits, so a failure here can come from them as much as from #782.

Queued ahead of this batch:

This pull request has been created by Mergify to speculatively check the mergeability of #782.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

  • check-success = gates (linux)
  • check-success = gates (windows)
  • check-success = red-first
  • github-review-approved [🛡 GitHub repository ruleset rule main-pr-required-checks]
  • label != do-not-merge
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (linux)
    • check-neutral = @github-actions/gates (linux)
    • check-skipped = @github-actions/gates (linux)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (windows)
    • check-neutral = @github-actions/gates (windows)
    • check-skipped = @github-actions/gates (windows)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/red-first
    • check-neutral = @github-actions/red-first
    • check-skipped = @github-actions/red-first
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections

Required conditions to stay in the queue:

---
all_scopes: false
checking_base_sha: 07eaebb6c446128e3b11dda5fbd35ff5c14d4aeb
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 782
    scopes: []
scopes: []
...

Cuarroc and others added 16 commits October 9, 2026 02:10
Test-First: src-tauri/src/questions.rs::questions::tests::store_fixture_drop_waits_for_connection_return_and_directory_removal
Extract the existing predicate unchanged and reproduce the KI-25 remainder with a compiling regression test.

Test-First: src-tauri/src/setupgate.rs::process_state_classification_rejects_zombies_and_dead_states
Hand off the Tokio worker while joining cleanup so SQLx connection-return tasks can finish. Drop TempDir outside the runtime context to keep Windows cleanup retries synchronous, and assert removal without polling.

Test-First: src-tauri/src/questions.rs::questions::tests::store_fixture_drop_waits_for_connection_return_and_directory_removal
Test-First: scripts/lib/dev-mrp-count.test.mjs::countRp recognizes all current Mergify package branches
Test-First: scripts/lib/dev-bench-weekly.test.mjs::weekly package counts follow current Mergify prefixes and preserve package IDs
Match the sibling testgate helper so dead processes cannot appear alive during setup cleanup assertions.

Test-First: src-tauri/src/setupgate.rs::process_state_classification_rejects_zombies_and_dead_states
Test-First: scripts/lib/dev-mrp-count.test.mjs::countRp recognizes all current Mergify package branches
Test-First: scripts/lib/dev-bench-weekly.test.mjs::weekly package counts follow current Mergify prefixes and preserve package IDs
The full prepush suite exposed one connection remaining after SQLx close completed. Re-drain the closed pool until empty before removing the directory; preserve the strict pool-size assertion and avoid timed polling.

Test-First: src-tauri/src/questions.rs::questions::tests::store_fixture_drop_waits_for_connection_return_and_directory_removal
No-Test: documentation only (acceptance matrix reconcile)
No-Test: documentation-only KI-25 status update; regression covered by the preceding commits.
Test-First: scripts/lib/dev-push-verified.test.mjs::PUSH-REMOTE: option-like remote refuses before push
Test-First: scripts/lib/dev-push-verified.test.mjs::PUSH-REMOTE: option-like remote refuses before push
@mergify mergify Bot closed this Oct 9, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/fe428f05ec branch October 9, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant