Repository navigation
fix(dev): align statistics package branches with Mergify - #782
Conversation
Test-First: scripts/lib/dev-mrp-count.test.mjs::countRp recognizes all current Mergify package branches Test-First: scripts/lib/dev-bench-weekly.test.mjs::weekly package counts follow current Mergify prefixes and preserve package IDs
Test-First: scripts/lib/dev-mrp-count.test.mjs::countRp recognizes all current Mergify package branches Test-First: scripts/lib/dev-bench-weekly.test.mjs::weekly package counts follow current Mergify prefixes and preserve package IDs
Cuarroc
added
the
review-ok
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1abdb63aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // provider/<letters+digits>-<number>...: w3-02d-x -> w3-02, ki-30-x -> ki-30, ci-03-x -> ci-03 | ||
| packageBranch: /^(?:claude|codex|kimi|opencode|glm)\/([a-z]+\d*-\d+)/i, | ||
| // Mergify package prefixes; retain task numbers: w3-02d-x -> w3-02, dr-14-sort -> dr-14. | ||
| packageBranch: /^(?:claude|codex|kimi|opencode|glm|cursor)\/((?:w\d+-|df\d+|ki-\d+|hq2-|dr-|z\d+-)\d*)/i, |
There was a problem hiding this comment.
Wenn mehrere Z2- oder unterteilte DR-Pakete im selben Messfenster liegen, gibt packageId für alle Z2-Branches nur z2- und beispielsweise für dr-07e1 sowie dr-07e2 jeweils nur dr-07 zurück. Dadurch meldet thr_pkgs zu wenige unterschiedliche Pakete und rework_fix kann einen Fix eines anderen Pakets fälschlich als Nacharbeit innerhalb von 72 Stunden zählen; docs/PLAN.md führt diese Suffixe ausdrücklich als getrennte Pakete. Die Extraktion muss daher den unterscheidenden Paketteil bewahren, statt am gemeinsamen Präfix abzuschneiden.
AGENTS.md reference: AGENTS.md:L13-L15
Useful? React with 👍 / 👎.
| // provider/<letters+digits>-<number>...: w3-02d-x -> w3-02, ki-30-x -> ki-30, ci-03-x -> ci-03 | ||
| packageBranch: /^(?:claude|codex|kimi|opencode|glm)\/([a-z]+\d*-\d+)/i, | ||
| // Mergify package prefixes; retain task numbers: w3-02d-x -> w3-02, dr-14-sort -> dr-14. | ||
| packageBranch: /^(?:claude|codex|kimi|opencode|glm|cursor)\/((?:w\d+-|df\d+|ki-\d+|hq2-|dr-|z\d+-)\d*)/i, |
There was a problem hiding this comment.
Sobald diese Version für die nächste Wochenmessung verwendet wird, werden Cursor-, DR-, Z- und zuvor ausgeschlossene w16-*-Branches neu als Pakete gezählt, während etwa ci-* und fu-* aus der Reihe fallen; im vorhandenen Merge-Verlauf ändert sich damit die Klassifikation für 144 von 399 Branches. Die Ergebnisse werden trotzdem direkt mit der unveränderten J2-Baseline und den Zielen verglichen, obwohl docs/plan/v1.6.0/benchmark.md:95-103 ausdrücklich festlegt, dass Definition und Baseline nicht geändert werden dürfen. Das kann M-THR und M-REWORK allein durch den Regexwechsel bestehen oder scheitern lassen; entweder muss der eingefrorene Klassifikator für diese Reihe erhalten bleiben oder eine neue, neu berechnete Baseline samt eigener Metrikversion eingeführt werden.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merge Queue Status
This pull request spent 27 minutes 2 seconds in the queue, including 14 minutes 58 seconds running CI. Required conditions to merge
|
Die beiden Statistikskripte erkennen jetzt dieselben Paketbranches wie die Berichtspflicht aus PR #768.
Branches von Cursor sowie Denkraum- und Z-Pakete werden mitgezählt, Dokumentations- und Queue-Branches bleiben ausgeschlossen.
Die Tests und die vollständige lokale Prüfung sind grün; der Entwurf wartet auf die unabhängige Review.
Report
a1d9a5fba38d2e50fe72727a644cb587edbe9357, verified descendant ofdd7391cd064a0720b2d1f747e959bbeab5a3fe7d.e1abdb63aa5aaf39bb2f43cb4fbc6080de0d7408; branch:codex/mrp-regex-scripts..mergify.ymlfromorigin/codex/mergify-report-regexat10788225cab64b6d1bbe8e5fd3645a7c870089d8(fix(ci): extend report protection to current package branches #768).claude|codex|kimi|opencode|glm|cursorand prefixesw\d+-|df\d+|ki-\d+|hq2-|dr-|z\d+-, case-insensitively. Weekly package IDs retain numeric task suffixes (e.g.w3-02,dr-14); prefix-only IDs such asz2-are counted too. Report formatting and metric formulas are unchanged.ci-03assertion now expects exclusion, matching the requested Mergify contract.Evidence (2026-10-09)
node --test scripts/lib/dev-mrp-count.test.mjs scripts/lib/dev-bench-weekly.test.mjs— exit 1, 16 passed / 3 failed; recorded in test-first commite1281401e3d3be18c33e12168bcabbe6d765cf62before the implementation commit.bash scripts/ci/red-first.sh— exit 0; both exact named tests missing at merge-base and green at head. The gate provisioned locked dependencies in its temporary base checkout automatically.bash scripts/ci/gates.sh lane prepushin the assigned worktree at the reported head — exit 0, 22 gates, 279 seconds; Rust suite 1,892 passed / 7 skipped.bash scripts/ci/secret-scan.shbefore each commit — exit 0; commit hooks also passed.git push -u origin codex/mrp-regex-scripts— exit 0; its full prepush hook passed again (122 seconds).git ls-remote origin codex/mrp-regex-scripts— exit 0; remote SHA equals the reported head.git diff --check origin/main...HEAD— exit 0; working tree clean after checks.node --input-type=modulecomparison against the pinned Mergify regex — exit 0; both scripts agreed on 288 provider/suffix/case combinations, including bare prefixes.NICHT ABGEDECKT
#[cfg(windows)]tests or Windows clippy branches. The Windows lane runs in the merge queue; the seven skipped Rust tests are not claimed as covered.lage-jetztmemory mirror were unavailable; no claims are made about them. Start checks passed before gates, following one required build-slot wait.Review and handover
Review: ausstehend (Stufe B) — pending Root dispatch. No worker review or review findings are claimed.
Implementation, red-first, local checks and verified push are complete. Root owns independent review, acceptance, ready status and Mergify integration; this PR remains a draft. The bounded native worker goal ends at this checked handover; the parent goal remains open.
Root-Abnahme (09.10.2026, head e1abdb6)
bench-weekly.mjs:15prefix-only branches (z2-) collapse into one weekly IDci-03no longer counted as packageTier B: author Codex gpt-6-astra (OpenAI); reviewer Anthropic family (claude-sonnet-5-5 on the server), verdict approve, bound to head e1abdb6. Report: ~/pa-orch/reports/review-pr782-anthropic-r1-e1abdb63aa5a.md.
NICHT ABGEDECKT addendum: Windows lane comes from the merge queue.