Repository navigation
feat(design): DS-H-07a probe hall gallery page - #1696
Merged
Merged
Conversation
The German words for the page switches land with the tests so the tests compile; the page itself follows in the next commit. Test-First: src/design/gallery/hallPage.test.tsx::the gallery shows the probe hall with the Beispieldaten label Test-First: src/design/gallery/hallPage.test.tsx::the page motion switch sets the hall to lively and off Test-First: src/design/gallery/hallPage.test.tsx::OS reduced motion still wins over the page switch Test-First: src/design/gallery/hallPage.test.tsx::empty and unread sets show words and no working figure Test-First: src/design/gallery/hallPage.test.tsx::the query opens mode and set Test-First: src/design/gallery/hallPage.test.tsx::an unknown query value falls back to the defaults Test-First: src/design/hall/HallMotion.test.tsx::an off-screen scene pauses the hall Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The gallery family "hall" renders Hall on Beispieldaten with a page motion switch (a prop on Hall; useMotion is a store hook, not a context), a sample-set switch (normal, leer, ungelesen) and state from the hash query. Hall pauses when the scene is off screen, on the same data-paused path as a hidden document. Test-First: src/design/gallery/hallPage.test.tsx::the gallery shows the probe hall with the Beispieldaten label Test-First: src/design/gallery/hallPage.test.tsx::the page motion switch sets the hall to lively and off Test-First: src/design/gallery/hallPage.test.tsx::OS reduced motion still wins over the page switch Test-First: src/design/gallery/hallPage.test.tsx::empty and unread sets show words and no working figure Test-First: src/design/gallery/hallPage.test.tsx::the query opens mode and set Test-First: src/design/gallery/hallPage.test.tsx::an unknown query value falls back to the defaults Test-First: src/design/hall/HallMotion.test.tsx::an off-screen scene pauses the hall Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: plan text only Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Cuarroc
marked this pull request as ready for review
October 17, 2026 05:12
Cuarroc
added
the
review-ok
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Root auto-queue: head 87bea25 unchanged since review-ok, all checks green. @Mergifyio queue |
Owner
Author
|
@Mergifyio queue |
30 of 46 tasks
Contributor
☑️ This pull request is already queued |
Contributor
Merge Queue Status
This pull request spent 12 minutes 45 seconds in the queue, including 12 minutes 26 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Die Design-Galerie hat jetzt eine Seite „Probe-Halle“, die die Halle mit dem Schild „Beispieldaten“ zeigt. Dort kannst du die Bewegung (Ruhig, Lebendig, Aus) und den Beispielsatz (normal, leer, ungelesen) umschalten; leer und ungelesen zeigen nur Worte und keine Arbeitsfigur. Eine Halle, die nicht auf dem Bildschirm zu sehen ist, pausiert ihre Bewegung jetzt wie bei einem versteckten Fenster.
Plan-ID: DS-H-07a
Report
Änderung
src/design/gallery/Gallery.tsx: Familiehallrendert die Seite „Probe-Halle“ (Nav-Eintrag heißt jetzt „Probe-Halle“ statt „Halle“). ZweiSegmented-Schalter: Bewegung (Ruhig/Lebendig/Aus) und Beispielsatz (normal =SAMPLE_HALL, leer =EMPTY_HALL, ungelesen = kein Szenenobjekt). Das Schild „Beispieldaten“ kommt ausHallund steht in allen drei Sätzen.Hall(motion?: MotionMode), nicht deruseMotion-Kontext —useMotionist ein Store-Hook aufdata-motion/localStorage, kein Provider; ein Überschreiben dort hätte die ganze App umgestellt. Das Betriebssystem gewinnt weiter (system || mode === "off"→still).useHallMotion: IntersectionObserver auf die Szene;paused = hidden || offScreen, derselbedata-paused-Pfad. Ohne IntersectionObserver gilt die Szene als sichtbar.src/i18n/de.ts: Wörter der Schalter.docs/PLAN.md: genau eine neue Zeile DS-H-07a.fixtures.tsblieb unverändert (EMPTY_HALLgab es schon).URL-Parameter (Hash-Routing, Zustand im Hash-Query, wird einmal beim Öffnen gelesen; Kopfkommentar in
Gallery.tsx):/#/designsystem?page=hall&motion=calm|lively|off&set=normal|empty|unread.pageist jede Galerieseite (colour, type, space, radius, glass, motion oder eine Familie); unbekannte Werte fallen auf die Vorgabe zurück.Rot → grün (Test-First-Commit
cafc761b, Fixa9831926)cafc761b: 7 Tests rot (npx vitest run src/design/gallery src/design/hall/HallMotion.test.tsx, Exit 1).npx vitest run src/design/gallery src/design/hall→ 59 Tests, Exit 0.hallPage.test.tsx(Schild, Seitenschalter lively/off, OS gewinnt, leer/ungelesen ohne Arbeitsfigur, Query öffnet Modus und Satz, unbekannter Wert) undHallMotion.test.tsx::an off-screen scene pauses the hall(IntersectionObserver-Attrappe).Belege (Kopf
87bea254)npm run typecheckExit 0;node scripts/contrast-check.mjsExit 0;node scripts/plan-check.mjs --offlineExit 0;bash scripts/ci/red-first.sh --planExit 0.bash scripts/ci/gates.sh lane prepushExit 0 (302 s, ungefiltert).git ls-remote origin claude/ds-h-07a=87bea254c69b6671a6b397d6ddf0c8d88c3e6390.scripts/dev/shot.mjs, Route/#/designsystem?page=hall&motion=calm&set=normal|empty, alle vier angesehen):ds-h-07a-calm-{normal,empty}-{light,dark}.pngim Ordner der Server-Berichte. Hinweis:shot.mjssetzt heute immerreducedMotion: reduce, daher sind die Bilder Bild 0 (Lebendig/Aus als Bild folgt mit 07b--motion).Architecture drift: keine neuen Funde.
NICHT ABGEDECKT
#[cfg(windows)]-Tests und die Windows-Arme von clippy: Linux deckt sie nicht ab, die Windows-Bahn läuft in der Merge-Queue.Review: ausstehend (Stufe B, Root beauftragt einen unabhängigen Nicht-Anthropic-Prüfer).
🤖 Generated with Claude Code on the ProjectA server worker
Root review disposition and acceptance (head 87bea25)
Tier B (gallery page + hall hook, TS only, no seam). Author family: Anthropic (Claude Sonnet server job). Independent review: Cohere
north-mini-code:freevia kilo, round 1 on head 87bea25, verdict "approve with conditions". Root (Anthropic) checked each finding at the head; Root's own reading is not counted as independent.overrideuseHallMotion.ts:35-38documentsoverrideandsceneRef.#/designsystem); the format is documented in theGallery.tsxheader comment and covered byhallPage.test.tsx("the query opens mode and set").oneOftypes may mismatchoneOf<T>returns a member ofidsorids[0]; typecheck green in prepush.motionprop without defaultoverride ?? storedfalls back to the stored mode (useHallMotion.ts:41).Screenshots inspected by Root (
/home/pa/pa-orch/reports/ds-h-07a-calm-{normal,empty}-{light,dark}.png): probe hall page, "Beispieldaten" label visible, empty set shows "Die Halle ist leer: kein Werkstück da." and no working figure. Note: these are frame-0 captures (oldshot.mjsalways emulates reduced motion); the motion evidence run follows after DS-H-07b merges.Decision: accept. Evidence bound to head 87bea25; prepush exit 0 per job report
ds-h-07a-20261017.md. Any later push voids this acceptance.