Repository navigation
merge queue: checking #1696 on main (faa4f8a) - #1698
Closed
mergify[bot] wants to merge 4 commits into
Closed
mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
The German words for the page switches land with the tests so the tests compile; the page itself follows in the next commit. Test-First: src/design/gallery/hallPage.test.tsx::the gallery shows the probe hall with the Beispieldaten label Test-First: src/design/gallery/hallPage.test.tsx::the page motion switch sets the hall to lively and off Test-First: src/design/gallery/hallPage.test.tsx::OS reduced motion still wins over the page switch Test-First: src/design/gallery/hallPage.test.tsx::empty and unread sets show words and no working figure Test-First: src/design/gallery/hallPage.test.tsx::the query opens mode and set Test-First: src/design/gallery/hallPage.test.tsx::an unknown query value falls back to the defaults Test-First: src/design/hall/HallMotion.test.tsx::an off-screen scene pauses the hall Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The gallery family "hall" renders Hall on Beispieldaten with a page motion switch (a prop on Hall; useMotion is a store hook, not a context), a sample-set switch (normal, leer, ungelesen) and state from the hash query. Hall pauses when the scene is off screen, on the same data-paused path as a hidden document. Test-First: src/design/gallery/hallPage.test.tsx::the gallery shows the probe hall with the Beispieldaten label Test-First: src/design/gallery/hallPage.test.tsx::the page motion switch sets the hall to lively and off Test-First: src/design/gallery/hallPage.test.tsx::OS reduced motion still wins over the page switch Test-First: src/design/gallery/hallPage.test.tsx::empty and unread sets show words and no working figure Test-First: src/design/gallery/hallPage.test.tsx::the query opens mode and set Test-First: src/design/gallery/hallPage.test.tsx::an unknown query value falls back to the defaults Test-First: src/design/hall/HallMotion.test.tsx::an off-screen scene pauses the hall Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: plan text only Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch chivalrous-cassoulet-4y69u8 of the
defaultqueue, to test #1696 before it merges intomain. Pushing to this branch or closing this pull request removes #1696 from the queue.What this draft tests
Mergify checks that #1696 still passes CI on top of
main. CI runs on this draft's code, built in this order:mainatfaa4f8a🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
mainand closes this draft.Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections