issues: capture three unowned follow-ups (id allocation, --med-accent-soft, mockup hover tokens)

[BigSimmo]

Summary

Three append-only rows on docs/outstanding-issues.md. No source, config, or test changes. Each captures something that was verified against origin/main and had no owner in the ledger.

• #155 — outstanding-issues ids are still allocated read-modify-write, and Update-branch corrupts the merge. #133 is correctly resolved: #1444 removed merge=union and #1479 excluded this file from Prettier, which together fixed conflict frequency. Neither touches id allocation, which is still read-modify-write against the issues:next-id marker, so concurrent branches still claim the same number. The sharper finding is the resolution path: GitHub's Update branch button pushed a sync to PR fix(ui): repair three dropped CSS custom-property references, and record the defect family #1451 (df3f3aeed) whose auto-merge produced two rows numbered #141 and two next-id markers, leaving the marker below main's highest id — so the next allocation would have reused a live number. git merge reported success; only npm run check:outstanding-issues caught it. That guard runs in verify:cheap and static-pr, so such a head cannot merge, but the corruption comes from a one-click path that runs no guard.

• #156 — --med-accent-soft is dead plumbing. medicationAccentStyle() at medication-record-page.tsx:92 sets it via color-mix, but nothing reads it; --med-accent and --med-accent-border are both consumed. Left in place rather than deleted because it plausibly mirrors the --clinical-accent-soft idiom and the comment block documents the trio as a contract.

• #157 — two mockup hover tokens #141 left undefined. #141 closed on the production defect (--clinical-accent-strong, now defined for light, dark and forced-colors), but --primary-hover and --success-hover are still undefined on main, referenced at favourites-library-redesign-page.tsx:203 and :217 with zero definitions in the stylesheet. Both declarations are dropped at CSS parse time, so those hover states silently do nothing. Impact is genuinely low — *-mockups is design scratch that 404s in production and is exempt from the wiring and reachability gates — but with #141 archived, nothing in this ledger owned them, and .design-sync/NOTES.md is prose in a tooling file rather than a tracked item.

Note on the ids: these rows were renumbered five times between being written and landing, because main took each number in turn. #155 records its own three collisions, which is the evidence for its claim rather than an aside.

Verification

• node scripts/check-outstanding-issues.mjs — exit 0: 155 rows (47 open, 108 archived), unique ids, next-id=158 above the highest, no merge driver, no ids deleted from base.
• On every conflict resolution, origin/main's table was taken as canonical and these rows re-applied on top, then comm used to confirm zero of main's ids were lost. That check exists because an earlier merge on PR fix(ui): repair three dropped CSS custom-property references, and record the defect family #1451 silently dropped an appended evidence block — a failure the guard cannot see, since it validates ids and structure rather than whether a merge kept both sides' prose.
• Prettier deliberately not run on this file: .prettierignore excludes docs/outstanding-issues.md as of Stop Prettier padding the issues ledger table, closing #133 #1479. The repository-wide pre-push Prettier guard ran on each pushed commit and passed; it was not bypassed.

Not run: unit, build, browser and provider gates. This diff is documentation rows with a dedicated structural gate, which is the smallest gate that covers it; CI's static-pr runs that same gate.

Risk and rollout

None to the product. Additive rows in an append-only memory file, no code path touched. classifyPullRequestFiles returns clinicalRisk: false, operationalRisk: false, ragRanking: false, ui: false, so no governance preflight or RAG impact: line applies.

Rollback: git revert the relevant commit.

This branch has been worked concurrently by more than one agent. Rows may have shifted ids again since this body was written — trust the file, not these numbers, and re-run check:outstanding-issues before merging.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 15 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 363b2d33-a7f2-460f-9cb2-f2e875afc151

📥 Commits

Reviewing files that changed from the base of the PR and between 5a91910 and acec1a3.

📒 Files selected for processing (2)

• docs/branch-review-ledger.md
• docs/outstanding-issues.md

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bac6311e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BigSimmo]

Temporarily paused during the owner-authorized ordered merge sweep so main cannot move between exact-head review and merge. The branch and all commits are preserved; this PR will be reopened at its verified place in the queue.

[BigSimmo]

@cursoragent this PR will be re-opened soon. Please resolve any failing CI, run bugbot and resolve any bugbot comments against current repo and fix any merge conflicts and also fix any errors and address and fix all comments or suggestions that are likely to improve the PR and Codebase. Please implement smallest required fix according to best code practices. Check your work. Leave this PR closed for now but still make all these changes and run the review. I want it ready to go for when I re-open it.

[cursor]

PR #1506 is reopen-ready on branch tip 56e4c0f0, and left closed.

What was wrong

• Only real CI failure was PR mergeability (DIRTY / conflict with main)
• Codex P2: #151 duplicated the residual race already archived under #112
• Bugbot: tip #154 collided with main’s unrelated #154; false “re-landed as #155 below” evidence

What I fixed

• Merged origin/main with a content-preserving rebuild
• Kept main’s #154; hazard is now #155; --med-accent-soft is #156; next-id=157
• Cross-linked archived #112 ↔ open #155 (did not reopen #112)
• Resolved the Codex review thread
• Pushed claude/issues-133-evidence

Verified

• check:outstanding-issues: 154 rows (46 open, 108 archived), unique ids, next-id=157… exit 0
• check:branch-review-ledger exit 0
• git merge-tree origin/main HEAD clean
• Bugbot re-check: ready

Note: Closed PRs freeze head.sha, so the GitHub page may still show ce410e44 / dirty until you reopen — the branch tip is already synced and clean.

  

[cursor]

Reopen-prep complete (PR left closed)

Branch tip 56e4c0f0 on claude/issues-133-evidence is synced to current origin/main and ready for reopen.

Fixed

• Merge conflict on docs/outstanding-issues.md (content-preserving rebuild; git merge-tree clean)
• Codex P2: residual of archived #112 tracked as open #155 with archive forward-pointer; #112 not reopened
• Bugbot P1/P2: kept main’s #154; hazard renumbered #155; removed false “re-landed as #155 below” clause; --med-accent-soft is #156
• Review thread on the Codex finding resolved

Verified

• check:outstanding-issues: 154 rows (46 open, 108 archived), unique ids, next-id=157… exit 0
• check:branch-review-ledger: exit 0
• merge-tree origin/main HEAD: clean

Note: GitHub freezes head.sha on closed PRs, so this page may still show ce410e44 / dirty until you reopen — the branch tip is already ahead and clean.

[cursor]

Reopen-prep (left CLOSED)

Tip: 8d227ed8 on claude/issues-133-evidence — behind 0 / ahead 10 vs origin/main; git merge-tree clean.

Sync: merged #1513; kept main’s #155 (cross-session concurrency); tip-only rows are #156 (id-allocation / #112 residual), #157 (--med-accent-soft), #158 (mockup hover tokens); next-id=159.

Threads: Codex #112 consolidation resolved (follow-up notes residual is now #156). No other unresolved Codex/Bugbot/Copilot/human threads.

Checks: closed-PR rollup still frozen at ce410e44 / dirty — stale until reopen. Fresh mergeability + required CI apply only after reopen.

Hygiene: docs-only tip (outstanding-issues + prior ledger rows); no ledger-only tip; no secrets/WIP. PR title still says #151 (closed-PR metadata); intentional capture is #156.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[BigSimmo]

@cursoragent This PR was just reopened. Do not merge, force-push, rebase, or arm auto-merge
unless I explicitly ask.

1. Confirm GitHub is on the current branch tip (not the old closed head).
   Snapshot head SHA, behind/ahead, mergeable state, required checks, and
   unresolved actionable threads.

2. Mergeability on this tip only:

   • Real conflict (merge-tree dirty): smallest fix, push.
   • Behind-but-clean: if required CI is in flight, wait and sync once late;
     otherwise sync once now. Prefer human/operator identity for update-branch;
     else git merge origin/main + push. No sync thrash.
   • Clean/current: leave it.
     Missing checks while mergeability is dirty ≠ green.

3. Fresh required CI on this tip only — ignore pre-close rollup. On failure:
   smallest fix, push, re-check. Don’t rerun unless a fix landed or a check
   is stuck. No provider-backed gates without approval.

4. New/unresolved actionable Codex/Bugbot/Copilot/human threads: smallest fix
   or short already-fixed/not-actionable reply, then resolve. Ignore
   rate-limit/summary noise.

5. Stop when: merge-tree clean, no actionable threads, required checks green
   or clearly in progress on this tip. Report tip SHA, sync done/not needed,
   CI status, threads handled, residual risks. Leave the merge decision to me.

[cursor]

1. Snapshot (at reopen)

• GitHub head was already the live tip 8d227ed8 (not the frozen closed head)
• Behind 8 / ahead 10 vs origin/main; mergeable=CONFLICTING / real merge-tree conflict on docs/outstanding-issues.md
• Missing required CI while dirty (not green)
• Codex #112 thread already resolved; no other actionable threads

2. Sync

• Merged origin/main once with a content-preserving rebuild (kept richer #156/#157, #112 residual pointer; mockup capture → #161)
• Main moved again (#1514); behind-but-clean, no CI in flight → one late git merge origin/main + push
• Tip pushed: acec1a38

3. CI on tip acec1a38

All success on that tip:

• PR mergeability, PR policy, Static PR checks, PR required, SAST, Secret Scan

4. Threads

No new unresolved actionable threads. Codex consolidation remains resolved (#156 + archive #112 pointer).

5. Outcome

While checks were finishing, you merged the PR (merged_by=BigSimmo, squash 6ca1f805). Content is on main (verified: #156 with #112 residual, #161 mockup tokens, next-id=162).

I did not merge, force-push, rebase, or arm auto-merge.