Parse nested JSONB job-status RPC result before completion gate checks

[Copilot]

Summary

completeJob assumed select * from ... returned top-level ok/gate_passed, but for JSONB-returning RPC shapes the payload can be nested under the function-name column, making rows[0]?.ok undefined and falsely routing successful jobs into failure handling.

• Status RPC parsing hardening

  • Added parseJobStatusRpcResult(row, rpcName) in supabase/functions/indexing-v3-agent/behavior.ts.
  • Supports both response shapes:
    • direct row columns ({ ok, gate_passed, ... })
    • nested function column ({ complete_strict_enrichment_job: { ok, gate_passed, ... } })
  • Normalizes missing: null to [].

• Completion path update

  • supabase/functions/indexing-v3-agent/index.ts now parses the first RPC row before evaluating ok and gate_passed.

• Focused regression coverage

  • Extended tests/indexing-v3-agent.test.ts with parser tests for direct row, nested JSONB row, and missing: null.

const result = parseJobStatusRpcResult(rows[0], "complete_strict_enrichment_job");
if (!result?.ok || !result.gate_passed) {
  throw new Error(/* blocked payload */);
}

Verification

• npm run verify:cheap
• npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
• npm run verify:release before release or handoff confidence claims
• npm run format:check
• npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
• npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

• Scope is intentionally narrow: worker-side RPC result decoding + targeted tests; no schema, privilege, or workflow contract changes.