Overlap regression tests, dead mic removal, CSS layering (plan items 3-5) - #143
Merged
Conversation
…oser The page-overflow smoke checks only assert document-level horizontal overflow, which overlapping siblings never trigger; this bug class shipped three times (ledger under the mode pill, composer clear button over typed text, standalone-home chips under the pill). Assert visible header elements do not stack at 640-1536px and the composer clear button occupies its own slot. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The mic buttons in the composer, applications launcher, and document viewer had no click handler, and the forms search field drew a mic icon implying voice support that does not exist. A silent dead control in a clinical tool erodes trust; remove them until the feature is real. Also drops the now-unused Mic imports. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Unlayered globals.css classes beat Tailwind utilities on the same element, which caused three shipped UI bugs. The audited conflict-free helpers (app-edge-backdrop, mobile-app-shell, mobile-popover-scroll, citation-link, animate-skeleton-shimmer, focus-ring-premium, source-capsule-hover, polished-scroll) now live in @layer components so utilities override them normally; also removes the orphaned answer-footer-search-mic rules. The chrome classes stay intentionally unlayered because call sites rely on the class winning today — that reconciliation is tracked in docs/process-hardening.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DocumentViewer drift is from this branch's mic removal; the other three drifted on main via recent merges. format:check is green repo-wide after this. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BigSimmo
pushed a commit
that referenced
this pull request
Jul 30, 2026
…ild-skip gate gap Records three items that surfaced during the /mockups/warning-consolidation study (PR #1437) and were not tracked anywhere: #141 P2 task — adopt a consolidated answer-home notice block; the study landed but nothing adopts it, and adoption moves the single site-wide APP-5 line across three composers #142 P2 issue — answer mode ships no verify-before-use caveat while every other clinical mode does #143 P2 issue — verify:pr-local exits 0 when guard-next-build refuses to run, reporting green with the build never executed Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPyFcMfn1jMmphr6AqiWBg
BigSimmo
pushed a commit
that referenced
this pull request
Jul 30, 2026
The merge of origin into this branch hit exactly the damage #133/#140 describe: merge=union concatenated both sides of the ledger rather than merging it. Two collisions, both repaired without dropping either side's rows: - Another agent had already allocated #141-#144 on main for different items while this branch used #141-#143. The incoming rows renumber, per the ledger rule, so the capture becomes #145 (adopt a consolidated answer-home notice block), #146 (answer mode ships no verify-before-use caveat) and #147 (verify:pr-local exits 0 when its build step refuses to run). Their cross-references were updated to match, and the two duplicated next-id markers collapse to one at 148. - #140 appeared in both tables: it was closed on main as a duplicate of #133 (PR #1444) while this branch still carried it open. The resolution is honoured — the stale open row goes, the archive row stays. check:outstanding-issues: 145 rows (72 open, 73 archived), unique ids, next-id=148 above the highest, no merge driver. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPyFcMfn1jMmphr6AqiWBg
BigSimmo
added a commit
that referenced
this pull request
Jul 30, 2026
…ocs content The three conflicts were all the squash-merge ancestry break: this branch was stacked on the pre-merge #1436 head, so its copies of docs/codebase-index.md, docs/scripts-index.md and docs/outstanding-issues.md collided with main's squashed version. Resolutions: kept this branch's corrected scripts-index counts (191/206 against main's stale 188/203) and its three new root-directory rows; took main's outstanding-issues wholesale because main renumbered the rows on merge (#135 became #144, next-id 145) and its ids are authoritative, then re-applied the #143 correction on top. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
BigSimmo
added a commit
that referenced
this pull request
Jul 30, 2026
…ording Another session merged main into this branch and reworded #143 concurrently. Both revisions carry the MSYS ref:path correction; this keeps the local wording, which additionally records that copying the primary checkout's untracked hook over that branch's version would have silently reverted its mixed-inputs guard. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
BigSimmo
added a commit
that referenced
this pull request
Jul 30, 2026
edits Another session reconciled the same three rows while this one snapshotted the worktrees. Resolution keeps this side for #149 and #150 (theirs carried no snapshot SHAs) and unions #151: their PR #1442 provenance plus the correction that the archived #143 row implied the fail-open was durable when only the hook and script had landed, kept alongside this side's redirect to PR #1494. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
BigSimmo
added a commit
that referenced
this pull request
Jul 30, 2026
…rktree (#1494) * fix(hooks): fail open when the inventory script is absent from the worktree core.hooksPath is an absolute path to the primary checkout, so this hook runs from every linked worktree - including ones whose branch predates the sync tooling and so does not contain scripts/update-docs-inventory.mjs. Those commits aborted with MODULE_NOT_FOUND before the author could do anything about it, which is ledger row #151 (originally #143). The inventory task now drops itself when its script is missing, removes docs/scripts-index.md from docs_to_check, and re-checks the all-tasks-empty early exit. That re-check matters: an empty docs_to_check makes the trailing `git diff --name-only --` match every modified file in the tree and fail the commit for unrelated reasons. The grep carries `|| true` because it exits 1 when it filters everything out, which `set -e` would treat as a hook failure. Verified in an isolated repository with the script genuinely absent - not merely deleted from the working tree, which the mixed-inputs guard catches first: the hook prints "skipping inventory sync" and the commit succeeds. With the script present the new block is a no-op, so the normal path is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(hooks): reject staged inventory generator removal * docs: record pre-commit hook review --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
BigSimmo
added a commit
that referenced
this pull request
Jul 31, 2026
* issues: capture the unreadable-CI token, at-risk worktree work, and the unpushed hook fix Three findings from the 2026-07-30 organisation session that were recorded nowhere durable: - #149 the session GitHub PAT lacks Checks: Read, so no agent can confirm a PR is green. The endpoint that does work returns an empty result rather than an error, so it reads like an absence of checks rather than an absence of permission. - #150 four worktrees on already-merged branches hold uncommitted work that exists in no branch and no PR, the largest being +395/-200 across 19 files including CI config. - #151 the pre-commit fail-open for #143 lives only on a never-pushed local branch, which is also 17 behind main and conflicts on the file whose count sentence main's new docs:update generator now owns. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(ledger): record the session-followup capture review for PR #1490 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(ledger): record #143/#151/#149 reconciliation for PR #1490 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): supersede PR #1490 reconciliation after remote sync Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * issues: record the worktree snapshots and redirect #151 to PR #1494 #150 — the four at-risk worktrees were snapshotted onto their own already-merged branches (748ef018f, 5dbd9f965, b7eae51a4, d949859c3), so the work survives a worktree reclaim. All four are clean now. None is pushed or reviewed; the next action is per-snapshot promote-or-reset. #151 — the never-pushed branch is superseded rather than salvageable: its script and hook reached main by other routes, so the fail-open guard was applied to main's committed hook in PR #1494 instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: remove credential metadata and correct audit dates * docs: consolidate session follow-up findings * docs: record consolidated follow-up review * issues: record that #101 hydration shipped PR #1463 merged as dba7356, so #86's "Next X3 unit — rag-hydration.ts" is now stale. The row records the extraction as shipped and keeps the corrected boundary: hydration re-homed only two of prepareCoverageGateResults's five rag.ts-only dependencies, so it did not unblock that function — exactly as the Codex review on PR #1461 predicted. This row was deliberately dropped from #1463 itself (commit 6290d02) after docs/outstanding-issues.md conflicted on five consecutive main syncs. Recording it separately here is the same pattern used for #1454 via #1461. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GGEBHp4Seoh1jK1vGTNtYS * docs(ledger): record the landed X3 hydration review Appended with npm run ledger:append (never hand-written), keyed to the squash commit dba7356 so ledger:lookup can resolve it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GGEBHp4Seoh1jK1vGTNtYS * docs: fix the #101 mislabel and key the ledger row to a resolvable ref Both defects were raised by Codex on PR #1495 and both are real; verified against the files before accepting. 1. #101 is NOT this extraction. docs/outstanding-issues.md:138 shows #101 is "Canary-gated retrieval parallelisation candidates" (P3, rec) — a separate, still-open recommendation gated on a live canary pair. Calling the hydration extraction "#101" marked that unrelated work as shipped and could have caused the live-evaluation work to be skipped. The label came from the original task brief and was propagated without checking it against the ledger. Both the #86 row and the X3 work-order entry now identify the change as the X3 hydration unit (PR #1463) instead. #101's own row is untouched and still open. 2. The ledger row did not resolve. `npm run ledger:lookup -- dba7356` returned NOT REVIEWED, because the ref cell held only the slash-form branch token and that branch no longer resolves locally, so the throttling record could not prevent a repeat review. Appended a superseding record keyed to the landed SHA; the same lookup now returns ALREADY REVIEWED. The original row is retained, per the ledger's append-only rule. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GGEBHp4Seoh1jK1vGTNtYS * docs: record consolidated PR reviews * docs: record ingestion recovery review * docs(visual): document the platform-scoped baseline layout and how to seed it `playwright.visual.config.ts` records snapshots under `__screenshots__/{platform}/`, so a baseline taken on Windows lands in `win32/` and is never consulted by the `ubuntu-24.04` CI job, which reads `linux/`. Nothing said so, and committing `win32/` images looks like protection while providing none. Records the constraint, names the CI artifact as the supported recorder for `linux/` baselines, and notes that comparison stays advisory until the jobs come off `continue-on-error`. Also creates the tracked directory `.gitignore` already claims exists, which sets `ui_changed=true` (`scripts/ci-change-scope.mjs`) so the visual job can run and produce that first artifact. No baselines are added here — they cannot be produced on this platform. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: correct visual baseline adoption steps * docs: record visual baseline guidance review * fix(ui): repair mockup accent token references * docs: record token-reference repair review * docs: archive advisory UI scoping task * docs: record advisory UI closure review * issues: archive #151 after #1494 and mark #143 fully resolved PR #1494 landed the fail-open guard on main, so close the open salvage row and update the #143 archive from PARTIAL to resolved across #1442 and #1494. Also carries the merge of origin/main that cleared the GitHub DIRTY mergeability state. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record PR #1490 main-sync and #151 closeout Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record #1496 id-collision renumber for PR #1490 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * issues: record the withdrawn live-region finding as #151 so it is not re-filed Archive-only row. There is no defect and no work to do — the row exists purely as a guard rail against repeating a misreading that already happened once. search-results-header-band.tsx sets aria-live={faulted ? "off" : "polite"} on its count/status span, which reads like a silenced failure announcement. It is not: the band mounts a separate fault panel with role="alert" carrying the failure title, body and Retry, and the mute is deliberate so the two do not both speak. The reasoning is in a comment directly above the attribute, and tests/search-results-header-band.dom.test.tsx pins it with singular role queries that throw on duplicates. During session 2026-07-30 (PR #1481) this was filed as a real P2 defect on the strength of the attribute alone, and the proposed fix — escalating the count span to role="alert"/aria-live="assertive" — would have produced a duplicate announcement and a red test, making it worse than no change. Codex caught it. An earlier withdrawal row was then lost to the squash that merged #1481, which is the row-deletion shape #148 now guards against. Also records that the mockup's escalation is correct in the mockup and must not be ported: search-refine-adaptive-mockups.tsx has no fault panel, so there the count span is the only announcement channel. #148 needed no work — the merge-base deletion check landed on main independently, and its output now reports the base it compared against. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JdPa3mHCX5ZQZZvU5GHU3r * docs(rag): record refuted lexical probe collapse (#98) * issues: capture the residual id-allocation hazard as #151 #133 is resolved: #1444 removed merge=union and #1479 excluded the ledger from Prettier, which together fixed conflict frequency. Neither changes id allocation, which is still read-modify-write against the next-id marker, so concurrent branches still claim the same number. Measured on PR #1451: one row was renumbered #135 -> #141 -> #145 -> #147 -> #149 across four sync cycles. The sharper finding is that GitHub's Update-branch button resolved one such collision into duplicate #141 rows with the marker left below main's highest id — git reported success and only check:outstanding-issues caught it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(issues): attribute the mobile CLS breach — a 128px reserve round trip #147 asked which elements shift. Driving Chromium against the same offline production build with a PerformanceObserver on layout-shift (Lighthouse mobile emulation, reading entry.sources[].node) gives one dominant cause on all four breaching routes: the entire main content region moves down 128px and straight back up 128px within 15-60ms. Both moves score, so it is pure cost with zero net movement — 100% of /documents/search's 0.220 and about 75% of /dsm's. The shifting element is the max-sm:pt-[var(--phone-overlay-chrome-h)] wrapper around <main>. A MutationObserver timeline on the root style attribute pins the mechanism rather than inferring it: the property goes CSS seed -> 200px -> 72px, and the 200px is written when the header stack ALREADY measures 72px (t=1552ms reserve=200px stack=72, corrected at t=1612ms). usePhoneOverlayChromeReserve reads stack.offsetHeight while the stack is transiently tall, publishes a value that is stale by the time it lands, and its ResizeObserver then corrects it. The CSS seed at globals.css:375 is correct for the settled stack, which corrects the mechanism recorded on the now-archived #130 — that framed the defect as the seed under-reserving by 0-8px. Measured, the driver is a 128px transient over-reserve written by the hook, not the seed. / is the control: it never writes the property and is the one clean route. Variance is stated rather than smoothed: /dsm measured 0.363 and 0.219 across two runs, and this harness has no network throttling so /forms and /therapy-compass run high locally. Only /dsm, /documents/search and / reproduced the live dispatch exactly. Also recorded: attaching a MutationObserver to document.documentElement inside a Playwright addInitScript throws before the document element exists, silently killing the CLS observer and reporting a uniform CLS=0.000 — a false clean bill that voided one run of this harness. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01361jh3eYVjJCzXWjAhdZiF * docs(ledger): record the #151 capture review for PR #1506 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(review): clarify snapshot branch state * docs(ledger): record PR #1490 main sync after snapshot wording Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs: archive rendered style contract task * docs: record style contract closure review * docs: record synced style contract review * docs: record post-121 style closure review * docs: normalize style review ledger after sync * docs: record post-1490 style closure review * docs: record consolidated PR 1490 review * docs: record replacement consolidation review * docs: record reconciled consolidation review * docs: record post-1511 consolidation review * docs: normalize PR 1510 ledger after main sync * docs: record PR 1510 post-sync review * docs: correct false #98 canary evidence and NOTES triage Remove the incorrect probe-collapse canary attribution from #98 and point the unread --med-accent-soft note at #157 without breaking the seven-token TOKENS_MISSING accounting. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record PR #1510 evidence-correction review Supersede the prior approve-with-no-findings row after correcting the false #98 canary attribution and NOTES triage drift. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs: keep concurrency note inside issue table * docs: record post-1513 consolidation review * docs: address CodeRabbit notes on PR #1510 Fix the computed-value-time wording in design-sync notes, give #33 a unique recommended-queue order, and drop the duplicated #98 Done block. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record PR #1510 CodeRabbit fix review Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the agreed follow-up plan from the design QA session (items 3–5; items 1–2 were live-database/ops work described in Notes):
tests/ui-overlap.spec.ts, wired into the Playwright testMatch): asserts visible header elements never stack at 640–1536px and the composer clear button occupies its own slot. This bug class shipped three times (header ledger under the mode pill, clear button over typed text, standalone-home chips under the pill); the page-overflow smoke checks structurally cannot catch it..answer-footer-search-micCSS).@layer componentsso Tailwind utilities override them normally. The chrome classes stay intentionally unlayered (call sites rely on the class winning today) — documented with an in-file warning and a "CSS cascade layering" section indocs/process-hardening.md.Verification
npm run verify:cheap— lint, typecheck, unit tests passednpm run verify:ui— 64 Chromium Playwright tests passed (includes the 10 new overlap tests)npm run format:check— green repo-wide after the prettier passnpm run verify:release— not run (no release claim)npm run check:supabase-project— Clinical KB Database (sjrfecxgysukkwxsowpy) confirmed (run as part of the migration work below)npm run check:deployment-readiness— not run (no deployment behavior changed)Clinical Governance Preflight
Presentation/test/process changes only; no ingestion, answer generation, search/ranking, document access, or clinical output behavior touched in this diff.
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
20260702000000_commit_generation_preserve_legacy_artifactsapplied to the live Clinical KB Database with explicit user approval; live function verified to carry the M13 guard;reindex:healthgreen (2,065 docs indexed, 0 failed).check:indexingcannot run on this machine (pre-existing local Python/Tesseract prerequisite gap, already documented in process-hardening "Known limits").RAG_QUERY_HASH_SECRET— is now set in both local.env.localfiles (takes effect on next server restart); set it in any deployed environment that logs real queries.20260701010000–20260701060000) are committed to the repo but absent from the live migrations table — consistent with the documented codify/reconcile flow (20260701140631+ the two20260702reconciliations are applied). Flagged for awareness, deliberately not applied.🤖 Generated with Claude Code