docs: テスト規約を stub-fetch unit test の実態に合わせる(#55)#58
Merged
Conversation
CLAUDE.md の「Tests cover pure logic only / Network IO は E2E のみ」は実態と 乖離していた(github/checksum は ./fetch を、download は ../src/github を、 proxy は undici を mock した unit test を持つ)。境界 mock 方針と E2E の役割 分担を明記する Test layering に更新。 - CLAUDE.md: Conventions の Tests 項を実態へ更新 - TODO.md: #55 を解決済み(#58)へ移動 Closes #55 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AECzAv2vcdATecuvLjBSa6
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
Walkthrough
Changesドキュメント更新
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jun 28, 2026
yk-lab
added a commit
that referenced
this pull request
Jun 28, 2026
## 概要 `ci.yml` / `self-test.yml` の `dorny/paths-filter` フィルタ `!**/*.md` は **root 直下の `.md`(`CLAUDE.md` / `TODO.md` / `README.md` 等)にマッチしない**ため、これらだけの PR でも `src = true` と判定され、フル matrix / self-test / proxy ジョブが走って CI 課金を無駄にしていた。 実例: PR #58(`CLAUDE.md` + `TODO.md` のみ)の `Detect changes` が `Filter src = true`。 ## 変更内容 - `ci.yml` / `self-test.yml` の `changes` フィルタに `- '!*.md'` を追加(root 直下の `.md` を除外)。`!**/*.md`(サブディレクトリの .md)と併用 ## 検証 - `actionlint` ✅ / `typos` ✅ - 本 PR は `.yml` を変更するため `src = true` でフル CI が走る(=挙動は次の **docs-only PR** で「重いジョブがスキップされる」ことで確認できる) - 非 .md を含む PR は従来どおりフル CI(回帰なし) ## 参照 - Closes #59 - PR #58(事象が確認できる) 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Exclude root-level `.md` files from the `dorny/paths-filter` `src` filter so docs-only PRs skip heavy CI (matrix/self-test/proxy); non-doc PRs are unchanged. Implemented by adding `!*.md` alongside `!**/*.md` in `ci.yml` and `self-test.yml`. Closes #59. <sup>Written for commit 9912931. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/yk-lab/setup-task/pull/60?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
CLAUDE.mdの Conventions「Tests cover pure logic only … Network/IO modules (github, download, install, main) are validated end-to-end by self-test.yml」は実態と乖離していた。実際は HTTP/IO モジュールも境界を mock した決定的な unit testを持つ(github/checksum→./fetch、download→@actions/tool-cache+../src/github、proxy→undici)。次に触る人が迷わないよう doc を実態へ合わせる(#42/#54 のレビューで指摘された乖離)。変更内容
CLAUDE.md: Tests 項を Test layering に更新TODO.md: [documentation] テスト規約(CLAUDE.md)を stub-fetch unit test の実態に合わせる #55 を解決済みへ移動検証
typos✅参照
🤖 Generated with Claude Code
Summary by cubic
CLAUDE.md のテスト規約を「Test layering」に更新し、HTTP/IO はネットワークに触れない決定的な unit test(境界を mock)、実 IO は
.github/workflows/self-test.ymlの E2E で担保する方針を明記。合わせて TODO.md で #55 を解決済みに移動。Written for commit e3a9c70. Summary will update on new commits.