Skip to content

refactoring: remove Array.forEach used in place of Array.some/find #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcoe merged 1 commit into from
Oct 9, 2019
Merged

refactoring: remove Array.forEach used in place of Array.some/find #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,16 +748,11 @@ function parse (args, opts) {
})
}

// check if a flag is set for any of a key's aliases.
// return the 1st set flag for any of a key's aliases (or false if no flag set)
function checkAllAliases (key, flag) {
var isSet = false
var toCheck = [].concat(flags.aliases[key] || [], key)

toCheck.forEach(function (key) {
if (flag.hasOwnProperty(key)) isSet = flag[key]
})

return isSet
let setAlias = toCheck.find(key => flag.hasOwnProperty(key))
return setAlias ? flag[setAlias] : false
}

function hasAnyFlag (key) {
Expand Down