refactoring: remove Array.forEach used in place of Array.some/find - #204
Merged
Conversation
Member
|
@mleguen mind rebasing? this looks like a smart refactor. |
Member
Author
|
Sure. Added to next wednesday's TODO. |
No need to parse all the array when a single match is expected.
mleguen
force-pushed
the
refac/array-some
branch
from
October 9, 2019 06:34
b616708 to
bcecd93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #202 (comment)
Replacing Array.forEach in checkAllAliases was not that straightforward, as this function was not really used for what its comment said it was, so I had to use Array.find instead of Array.some.
So I fixed the comment too.