This repository was archived by the owner on Jul 9, 2026. It is now read-only.
Repository navigation
Image block vol 03 (sizing) #147
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d0e0e03
Example html: Removed empty image example block.
etoledom e7cb4c7
Update gutenberg ref
etoledom 84aae0e
Update gutenberg ref
etoledom 512a8eb
Merge branch 'master' into feature/image-block-vol-03
etoledom cc5ba84
Merge branch 'master' into feature/image-block-vol-03
etoledom e7cd2ef
Update gutenberg reference
etoledom eece933
Update gutenberg ref
etoledom 7bd934d
Update gutenberg ref
etoledom 73c716a
Updating gutenberg reference
etoledom ce9d5ca
Update gutenberg reference
etoledom 852f544
Merge branch 'master' into feature/image-block-vol-03
etoledom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule gutenberg
updated
4 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is some background info here on why we remove the "upload placeholder" case. Can you elaborate @etoledom ? Thanks!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For organization.
I added both together before for testing purposes, but I had in mind to leave just one from the beginning. Now we can add the empty one by adding a new Image Block.
There's no problem to add the empty one back if we want to have everything visible anyway! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. No, that's cool, no need to reinstate it. It was just not clear because the actual code changes are on the GB repo side and I wasn't sure if we lost that feature or not. Thanks!