Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Image block vol 03 (sizing) - #147

Closed
etoledom wants to merge 11 commits into
masterfrom
feature/image-block-vol-03
Closed

etoledom wants to merge 11 commits into
masterfrom
feature/image-block-vol-03

Conversation

@etoledom

@etoledom etoledom commented Sep 17, 2018 •

Copy link
Copy Markdown
Contributor

Part of #140

This PR implement the changes related to Image Block sizing on the Gutenberg project.

Please follow the instruction on the mentioned PR for testing.

image_block_resizing

@etoledom etoledom mentioned this pull request Sep 17, 2018
5 of 10 tasks
@etoledom
etoledom requested a review from hypest September 18, 2018 00:31
@etoledom

Copy link
Copy Markdown
Contributor Author

@hypest - Could you please take a look at this? Thank you!

I'll check the merge conflict first time tomorrow. My first test didn't work well. (Updating the gutenberg reference from master seems to breaks the build 😩 )

@daniloercoli
daniloercoli self-requested a review September 18, 2018 14:20
@etoledom

Copy link
Copy Markdown
Contributor Author

Sent an update and finally everything seems to be green in both projects! 🎉
Thanks @daniloercoli for fixing the build error!

I believe this is ready for a review.

@daniloercoli daniloercoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread src/store/index.js
setUnknownTypeHandlerName( UnsupportedBlock.name );

const initialHtml = `
<!-- wp:image -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is some background info here on why we remove the "upload placeholder" case. Can you elaborate @etoledom ? Thanks!

@etoledom etoledom Sep 18, 2018 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For organization.

I added both together before for testing purposes, but I had in mind to leave just one from the beginning. Now we can add the empty one by adding a new Image Block.

There's no problem to add the empty one back if we want to have everything visible anyway! 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. No, that's cool, no need to reinstate it. It was just not clear because the actual code changes are on the GB repo side and I wasn't sure if we lost that feature or not. Thanks!

@etoledom

Copy link
Copy Markdown
Contributor Author

This PR has become irrelevant. We can push a new one when we retake the Images sizing work.

@etoledom etoledom closed this Nov 21, 2018
@etoledom
etoledom deleted the feature/image-block-vol-03 branch November 21, 2018 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants