fix: handle import.meta.glob alias edge cases by intellild · Pull Request #16017 · web-infra-dev/rspack

intellild · 2026-10-08T11:01:21Z

Motivation

Follow-up to #15898. Resolving aliases from the compiled scan request loses information needed by negative patterns, mixed patterns, and caseSensitive: false.

For example, with @ -> <root>/src:

import.meta.glob(
  ["@/pages/*.js", "!@/**/excluded.js"],
  { eager: true },
);

Previously, only the positive pattern was rewritten, so excluded.js was still imported. Alias targets such as src/[dir] were also interpreted as glob syntax, and alias: { dir: [] } incorrectly changed a local dir/*.js request into a module request.

Changes

Resolve aliases independently in each original positive and negative pattern, then recompute the common scan directory. This also supports mixed alias/relative patterns and case-insensitive directory matching.
Escape literal resolved directories while preserving the pattern suffix's glob syntax, and skip empty alias entries.
Reuse one dependency resolver for alias prefixes and the final scan directory, eliminating a duplicate resolver lookup and options clone. Cache each alias-prefix resolution within the glob so positive and negative patterns share it.
Extend the existing config case with regression coverage, including *.mjs with ?raw, ignored/exact aliases, and explicit ./@/... paths. Update English and Chinese docs.

Validation: binding and JS builds; context config suites in standard/runtime modes (62 passed); existing normal context suites (100 passed); cargo clippy -p rspack_core --all-targets -- --deny warnings; formatting and pre-commit checks.

by OpenAI Codex

cloudflare-workers-and-pages · 2026-10-08T11:02:35Z

Deploying rspack with Cloudflare Pages

Latest commit:	`edb990d`
Status:	✅ Deploy successful!
Preview URL:	https://47db4907.rspack-v2.pages.dev
Branch Preview URL:	https://codex-import-meta-glob-alias.rspack-v2.pages.dev

View logs

github-actions · 2026-10-08T11:09:07Z

📦 Binary Size-limit

Comparing f079885 to perf(sources): release generated value after static source map (#16022) by Cong-Cong Pan

❌ Size increased by 20.00KB from 67.19MB to 67.21MB (⬆️0.03%)

github-actions · 2026-10-08T11:12:27Z

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (33500069122f5da1efbd76b9ba8410639d666eeb) does not have baseline artifacts. Using commit 84939462e581debce61c0820aba1f71dfe19d00a for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary

Project	Total Size	Gzip Size
popular-libs	1.7 MB	529.6 KB
react-10k	5.4 MB	1.3 MB
react-1k	827.7 KB	226.6 KB
react-5k	2.6 MB	670.9 KB
ui-components	4.7 MB	1.4 MB

Generated by Rsdoctor GitHub Action

codspeed · 2026-10-08T11:30:09Z

Merging this PR will degrade performance by 2.04%

❌ 1 regressed benchmark
✅ 53 untouched benchmarks
⏩ 47 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`rust@create_module_hashes`	7 ms	7.2 ms	-2.04%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing codex/import-meta-glob-alias-fixes (f079885) with main (8493946)}

47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chatgpt-codex-connector · 2026-10-09T06:06:00Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T07:11:36.250566Z	`f079885`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: edb990d853

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6ed684b75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f07988586f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-09T07:11:33Z

+            if *query != resource.query {
+              query.clear();
+            }
+            if *fragment != resource.fragment {
+              fragment.clear();


Preserve suffixes for each aliased pattern

When positive patterns use aliases with different queries or fragments (for example, raw -> dirA?raw and url -> dirB?url), this merge clears the differing component and the context subsequently applies the final scan directory's suffix—usually empty—to every matched module. Although the new common-suffix handling fixes the single/common-alias case, this means loaders for both patterns lose their alias-specific resource suffixes; these patterns need separate suffix handling, such as separate contexts or per-match metadata.

Useful? React with 👍 / 👎.

fix: resolve import.meta.glob aliases before compiling scan roots

edb990d

intellild marked this pull request as ready for review October 9, 2026 06:05

chatgpt-codex-connector Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread crates/rspack_core/src/context_module_factory/glob.rs Outdated

fix: preserve exact alias semantics in import.meta.glob

c6ed684

chatgpt-codex-connector Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread crates/rspack_core/src/context_module_factory.rs Outdated

fix: preserve glob alias query and fragment

f079885

chatgpt-codex-connector Bot reviewed Oct 9, 2026

View reviewed changes

intellild mentioned this pull request Oct 9, 2026

feat: add resumable glob patterns and prune directory scans #16025

Draft

intellild marked this pull request as draft October 10, 2026 08:33

intellild changed the title ~~fix: handle import.meta.glob alias edge cases~~ refactor(glob): handle import.meta.glob alias edge cases Oct 13, 2026

intellild changed the title ~~refactor(glob): handle import.meta.glob alias edge cases~~ fix: handle import.meta.glob alias edge cases Oct 13, 2026

Navigation Menu

Repository navigation

fix: handle import.meta.glob alias edge cases - #16017

fix: handle import.meta.glob alias edge cases#16017
intellild wants to merge 3 commits into
mainfrom
codex/import-meta-glob-alias-fixes

intellild commented Oct 8, 2026

Uh oh!

cloudflare-workers-and-pages Bot commented Oct 8, 2026

Uh oh!

github-actions Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 9, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

intellild commented Oct 8, 2026

Motivation

Changes

Uh oh!

cloudflare-workers-and-pages Bot commented Oct 8, 2026

Deploying rspack with Cloudflare Pages

Uh oh!

github-actions Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

github-actions Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

Uh oh!

codspeed Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 2.04%

Performance Changes

Footnotes

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Oct 8, 2026 •

edited

Loading

github-actions Bot commented Oct 8, 2026 •

edited

Loading

codspeed Bot commented Oct 8, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading