Repository navigation
fix: resolve aliases in import.meta.glob patterns - #15898
Merged
intellild merged 2 commits intoOct 8, 2026
Merged
Conversation
intellild
self-requested a review
September 28, 2026 01:59
Contributor
|
@codex review |
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
|
@intellild just a friendly nudge is anything else required or is anything blocking from my side for this PR? |
Contributor
Thanks for contributing. I am looking into some edge cases which may break existing users. |
aryan1306
force-pushed
the
fix/import-meta-glob-resolve-alias
branch
from
October 2, 2026 17:44
e439933 to
4114242
Compare
intellild
requested changes
Oct 8, 2026
Only drop the leading './' from a bare import.meta.glob request when its prefix matches a resolve.alias key. Unaliased bare patterns (dir/*.js) and query-only requests (*.mjs with ?raw) resolve relative to the importer as before.
Contributor
|
@codex review |
intellild
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #15894.
import.meta.glob("@/glob-imports/*.js")currently treats the alias as a relative directory and fails to resolve./@/glob-imports/.Changes
resolve.alias.Verified with the new config case in standard and runtime mode, the existing
normalCases/context/import-meta-globsuite, and the repository pre-commit checks.Generated by the Codex AI agent.