Repository navigation
refactor: use proc macro for wasi ignore reasons - #14964
Open
eduardomourar wants to merge 2 commits into
Open
eduardomourar wants to merge 2 commits into
eduardomourar wants to merge 2 commits into
Conversation
This was referenced Sep 29, 2026
|
GNU testsuite comparison: |
eduardomourar
force-pushed
the
refactor/wasi-ignore-reasons
branch
from
September 29, 2026 17:21
2a36443 to
088a962
Compare
Merging this PR will degrade performance by 5.08%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
eduardomourar
force-pushed
the
refactor/wasi-ignore-reasons
branch
from
September 29, 2026 21:26
088a962 to
ab95f3f
Compare
sylvestre
reviewed
Oct 5, 2026
sylvestre
reviewed
Oct 5, 2026
sylvestre
reviewed
Oct 5, 2026
sylvestre
reviewed
Oct 5, 2026
sylvestre
reviewed
Oct 5, 2026
sylvestre
reviewed
Oct 5, 2026
eduardomourar
force-pushed
the
refactor/wasi-ignore-reasons
branch
3 times, most recently
from
October 6, 2026 00:50
d5235e5 to
5353ad6
Compare
eduardomourar
force-pushed
the
refactor/wasi-ignore-reasons
branch
from
October 6, 2026 20:45
5353ad6 to
7fc1254
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralizes the ~400
#[cfg_attr(wasi_runner, ignore = "...")]annotations across the integration tests behind#[uutests::wasi_ignore(ReasonKey)], a proc-macro attribute defined in a newtests/uutests_procscrate.Context: As per PR 14884 and PR 13687 flagged
wasi_runneras a noisy, ad hoccfg. It can't be replaced withtarget_os, since the tests always compile for the host (WASI can't spawn the child process they launch) —wasi_runneris the only signal a run is driving awasm32-wasip1/wasm32-wasip2binary viawasmtime. This doesn't remove thecfg, just the string-literal duplication around it: every reason is now defined once, alphabetically, intests/uutests_procs/src/lib.rs42 keys, down from an initial 57 after merging duplicates), including several that previously had no explanation at all.#[uutests::wasi_ignore(Reason)]can also be applied to amod { ... }block instead of one#[test]fn at a time; it recurses into nested modules and attaches the reason to every test inside.tee'slinux_onlymodule (21 tests) andtruncate'sfifomodule (3 tests) use this instead of repeating the same key on every test.Not touched: structural gates that aren't ignore-reasons (
feat_diagnosticsmodule gating,#[cfg(wasi_runner)]branches selecting alternate passing assertions).