date: fix wasi clock resolution and system datetime support by eduardomourar · Pull Request #13687 · uutils/coreutils

eduardomourar · 2026-08-01T02:25:29Z

date implements get_clock_resolution via libc::clock_getres (rustix's excludes WASI) and set_system_datetime for WASI, the latter reporting "not supported" since the sandbox has no wall-clock-set syscall.

github-actions · 2026-08-01T03:06:23Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)

codspeed · 2026-08-01T14:10:10Z

Merging this PR will not alter performance

✅ 12 untouched benchmarks
⏩ 442 skipped benchmarks¹

_{Comparing eduardomourar:wasi-date-fixes (d7401e1) with main (8cf2e4f)}

442 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-09-07T15:45:15Z

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 153.09 MB (+912 KB, +0.59%)

Significant per-binary changes:
  expr     2.76 MB ->    3.65 MB  (+908 KB, +32.11%)

eduardomourar · 2026-09-08T10:22:31Z

@sylvestre, this one is ready (now with proper testing in place).

sylvestre · 2026-10-06T21:03:17Z

sorry but it needs to be rebased

sylvestre · 2026-10-06T21:06:08Z

Thanks, the earlier comments are all handled. One thing is still missing: nothing runs the new SettingDateNotSupportedWasi path (src/uu/date/src/date.rs:1438). The two -s tests (test_date_set_permissions_error and test_date_set_hyphen_prefixed_values) are just ignored under wasi_runner. Could you add a small #[cfg(wasi_runner)] test in tests/by-util/test_date.rs that runs date -s "2020-01-01" and checks it fails with "setting the date is not supported by WASI"? After that it looks good to me.

eduardomourar · 2026-10-06T21:22:42Z

As requested, added test_date_set_unsupported_on_wasi to exercise SettingDateNotSupportedWasi code path.

date implements get_clock_resolution via libc::clock_getres (rustix's excludes WASI) and set_system_datetime for WASI, the latter reporting "not supported" since the sandbox has no wall-clock-set syscall.

sylvestre · 2026-10-07T06:31:05Z

+        let res = get_clock_resolution();
+
+        // Every supported platform reports a resolution of at least 1ns.
+        let nanos = res.as_second() as i128 * 1_000_000_000 + i128::from(res.subsec_nanosecond());


res.as_nanosecond() already returns an i128, no need to compute it by hand

eduardomourar mentioned this pull request Aug 1, 2026

feat(wasi): normalize wasi error codes #13625

Draft

eduardomourar force-pushed the wasi-date-fixes branch from f767364 to 2321086 Compare August 1, 2026 12:43

eduardomourar force-pushed the wasi-date-fixes branch from 2321086 to b3d7f8f Compare August 1, 2026 21:42

eduardomourar force-pushed the wasi-date-fixes branch 2 times, most recently from 088a4d0 to d2b7ca2 Compare August 11, 2026 18:20

eduardomourar force-pushed the wasi-date-fixes branch 3 times, most recently from 3527d4f to 3c980e5 Compare September 7, 2026 09:19

sylvestre enabled auto-merge (rebase) September 7, 2026 09:23

auto-merge was automatically disabled September 7, 2026 15:24
Head branch was pushed to by a user without write access

eduardomourar force-pushed the wasi-date-fixes branch from 3c980e5 to f82440a Compare September 7, 2026 15:24

eduardomourar force-pushed the wasi-date-fixes branch 2 times, most recently from 715fc00 to 7cc713f Compare September 7, 2026 19:21

eduardomourar force-pushed the wasi-date-fixes branch from 7cc713f to 5015903 Compare September 8, 2026 19:43

eduardomourar force-pushed the wasi-date-fixes branch 3 times, most recently from 8801020 to 32fa6ab Compare September 22, 2026 22:42

eduardomourar changed the title ~~fix(wasi): date clock resolution and system datetime support~~ date: fix wasi clock resolution and system datetime support Sep 22, 2026