Skip to content

Find plugin installs in herdr 0.9.4's generation layout - #3

Merged
umutciloglu merged 2 commits into
masterfrom
herdr-installations-layout
Oct 21, 2026
Merged

umutciloglu merged 2 commits into
masterfrom
herdr-installations-layout

Conversation

@umutciloglu

Copy link
Copy Markdown
Owner

The Windows CI on master started failing after #2 merged:

Cannot find path 'C:\Users\runneradmin\AppData\Roaming\herdr\plugins\github' because it does not exist.

Our code didn't cause it. herdr 0.9.4 (herdrdev/herdr#4245, herdr plugin update) moved GitHub plugin installs:

  • Old: plugins/github/<id>-<hash>/
  • New: plugins/github-installations/<id>-<hash>/<pid>-<generation>/checkout/

herdr deletes only checkout/ when it cleans up an old generation, so empty generation folders can stay behind. It also leaves any legacy github/ checkout in place.

Changes

  • windows.yml: the install check uses the newest generation that still has checkout/, then falls back to the legacy checkout.
  • fetch-or-build.sh / fetch-or-build.ps1: the hsm and agentmail launchers search the same way. The new layout goes first because a leftover legacy checkout is out of date.
  • Updated the launcher comments, which described the old temp-folder-and-move behaviour.

Testing

  • Windows CI is green on this branch (test, stores, install). The install job runs the .cmd launchers.
  • sh launcher, on a fake folder tree: it used the legacy install when that was all there was, then the newest generation, and it skipped a newest generation with no checkout/.

herdr 0.9.4 builds each GitHub install in plugins/github-installations/<id>/<generation>
instead of plugins/github/<id>. The Windows CI check and the hsm/agentmail launchers
only looked in the old place. Look in the new layout first, then fall back to the
legacy checkout.
herdr builds into the checkout/ subfolder of each generation, and reclaiming an old
generation removes only that subfolder.
@umutciloglu
umutciloglu merged commit 45d6c89 into master Oct 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant