Repository navigation
Find plugin installs in herdr 0.9.4's generation layout - #3
Merged
Merged
Conversation
herdr 0.9.4 builds each GitHub install in plugins/github-installations/<id>/<generation> instead of plugins/github/<id>. The Windows CI check and the hsm/agentmail launchers only looked in the old place. Look in the new layout first, then fall back to the legacy checkout.
herdr builds into the checkout/ subfolder of each generation, and reclaiming an old generation removes only that subfolder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows CI on master started failing after #2 merged:
Our code didn't cause it. herdr 0.9.4 (herdrdev/herdr#4245,
herdr plugin update) moved GitHub plugin installs:plugins/github/<id>-<hash>/plugins/github-installations/<id>-<hash>/<pid>-<generation>/checkout/herdr deletes only
checkout/when it cleans up an old generation, so empty generation folders can stay behind. It also leaves any legacygithub/checkout in place.Changes
windows.yml: the install check uses the newest generation that still hascheckout/, then falls back to the legacy checkout.fetch-or-build.sh/fetch-or-build.ps1: thehsmandagentmaillaunchers search the same way. The new layout goes first because a leftover legacy checkout is out of date.Testing
.cmdlaunchers.checkout/.