Skip to content

Add models for java.util.Deque methods - #86

Merged
msridhar merged 3 commits into
masterfrom
ms-deque-model
Dec 18, 2017
Merged

msridhar merged 3 commits into
masterfrom
ms-deque-model

Conversation

@msridhar

@msridhar msridhar commented Dec 17, 2017 •

Copy link
Copy Markdown
Collaborator

Eventually we should address #85 but in the meantime this gets some safety for these methods. Note that we'll get a NullAway error for invoking LinkedList methods with null through the Deque interface, but I think that's reasonable (workaround is to downcast to a LinkedList first). #

@lazaroclapp lazaroclapp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msridhar
msridhar merged commit 861d493 into master Dec 18, 2017
@msridhar
msridhar deleted the ms-deque-model branch December 25, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants