You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should be able to leverage inheritance when writing models for librarys. E.g., Collections.toArray(T[]) is specified to throw an NPE whenever the parameter is null. Right now, we need to add a model for Collections.toArray, ArrayDeque.toArray, LinkedList.toArray, etc. to get full safety. It'd be nice to just add a model for Collections.toArray and then catch this for any overriding method. Would need to be careful about performance when implementing this.
@msridhar we are seeing the word performance thrown around a lot during many tickets failed against nullaway, but we dont seem to have a concrete way to measure this. Can we setup a profiling sample using jmh in this repo that can we run as part of travis and give us numbers on what the performance change looks like on PRs? or atleast a way for us to run manually?
Activity
Add models for java.util.Deque methods (#86)
kageiit commentedon Dec 18, 2017
@msridhar we are seeing the word performance thrown around a lot during many tickets failed against nullaway, but we dont seem to have a concrete way to measure this. Can we setup a profiling sample using jmh in this repo that can we run as part of travis and give us numbers on what the performance change looks like on PRs? or atleast a way for us to run manually?
msridhar commentedon Dec 18, 2017
@kageiit opened #87 on benchmarking / profiling. Not sure we can trust numbers from Travis, but at least for running locally it should be useful.