Add note that the convenience parsers are not cached to readme#104
Merged
masklinn merged 1 commit intoua-parser:masterfrom Apr 27, 2022
Merged
Add note that the convenience parsers are not cached to readme#104masklinn merged 1 commit intoua-parser:masterfrom
masklinn merged 1 commit intoua-parser:masterfrom
Conversation
masklinn
force-pushed
the
cache-warning
branch
6 times, most recently
from
40ad449 to
b6b2d5d
Compare
This is an intermediate stopgap before modifying caching so it works with and across all the functions, as the issue does seem pretty significant (cf ua-parser#97)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An even better solution would be to cache them, but just caching
them seems redundant with the existing cache, so things would need to
be rethought.
Fixes #97