Skip to content

Commit 40ad449

Browse files
committed
Add note that the convenience parsers are not cached to readme
An even better solution would be to cache them, but *just* caching them seems redundant with the existing cache, so things would need to be rethought. Fixes #97
1 parent 934bfab commit 40ad449

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

README.rst

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,16 @@ Extract browser data from user-agent string
7777
'minor': '0',
7878
'patch': '2272'}
7979
80+
..
81+
82+
⚠️The convenience parsers (``ParseUserAgent``, ``ParseOs``, and
83+
``ParseDevice``) currently have no caching, which can result in
84+
degraded performances when parsing large amounts of identical
85+
user-agents (which might occur for real-world datasets).
86+
87+
In that case, prefer using ``Parse`` and extracting the
88+
sub-component you need from the resulting dictionary.
89+
8090
Extract OS information from user-agent string
8191
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
8292

0 commit comments

Comments
 (0)