Repository navigation
v4: Add an actual data-touch="false" example in the carousel docs - #32639
Merged
Merged
Conversation
patrickhlauke
added
docs
patrickhlauke
force-pushed
the
patrickhlauke-carousel-touch-v4-backport
branch
from
December 28, 2020 15:04
b26fbdf to
694f9ca
Compare
i believe the correct option is `slide` here, not `ride`. the `if "carousel"` bit was rather unclear/confusing
patrickhlauke
marked this pull request as draft
December 28, 2020 15:39
patrickhlauke
marked this pull request as ready for review
December 28, 2020 23:29
patrickhlauke
force-pushed
the
patrickhlauke-carousel-touch-v4-backport
branch
from
December 28, 2020 23:32
618ae70 to
ae54c9b
Compare
XhmikosR
marked this pull request as draft
December 29, 2020 10:43
XhmikosR
marked this pull request as ready for review
December 29, 2020 13:41
mdo
reviewed
Jan 5, 2021
Co-authored-by: Mark Otto <markd.otto@gmail.com>
mostly based on @mdo's suggestion, but also adds the word "attribute" after `data-ride` for better flow/legibility
Member
Author
mdo
approved these changes
Jan 5, 2021
patrickhlauke
added a commit
that referenced
this pull request
Jan 5, 2021
based on changes made in the backport #32639
patrickhlauke
added a commit
that referenced
this pull request
Jan 6, 2021
based on changes made in the backport #32639
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32638