Skip to content

Regression: carousel data-touch="false" not working #32629

Description

@patrickhlauke

A fresh version of this #28025 (comment)

It seems somehow the code that was added here #28046 has been lost at some point.

[edit: correction, as @rohit2sharma95 pointed out, the code is actually still there - i somehow managed to miss it while checking the code yesterday. so the problem may be deeper somehow]

Activity

  1. added
    jsJavaScript or TypeScript sources and plugins
    v4v4, the frozen docs on gh-pages
    v5v5, the v5-dev branch
    regressionA bug that did not happen in an earlier release
    on Dec 27, 2020
  2. rohit2sharma95 commented on Dec 28, 2020

    @rohit2sharma95
    Contributor

    But the check (added in #28046) still exists in the main branch:

    if (this._config.touch && this._touchSupported) {
    this._addTouchEventListeners()
    }

  3. patrickhlauke commented on Dec 28, 2020

    @patrickhlauke
    MemberAuthor

    where is the actual data-touch data attribute queried? is that part of some more generic "grab anything that's a data attribute and shove it into the _config object" type logic?

  4. patrickhlauke commented on Dec 28, 2020

    @patrickhlauke
    MemberAuthor

    as I always find it difficult to debug this sort of thing easily, and also because it would be nice to actually provide a live example, i made this provisional PR here to add a carousel without touch to the docs #32638

  5. patrickhlauke commented on Dec 28, 2020

    @patrickhlauke
    MemberAuthor

    using the added example from #32638 I can confirm that https://deploy-preview-32638--twbs-bootstrap.netlify.app/docs/5.0/components/carousel/#suppressing-touch-swiping when tested on iOS, Android, and a Surface with touchscreen still reacts to touch/swipe despite the data-touch="false" attribute

  6. patrickhlauke commented on Dec 28, 2020

    @patrickhlauke
    MemberAuthor

    turns out i was being a moron - this actually works in v5 if using the correct data-bs-touch="false". now wondering how to test the reported issue in 4.5...

  7. patrickhlauke commented on Dec 28, 2020

    @patrickhlauke
    MemberAuthor

    ok, having now tested this in v4.5 as well, it seems there is no actual problem with data-touch="false". #32639

    closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    jsJavaScript or TypeScript sources and pluginsregressionA bug that did not happen in an earlier releasev4v4, the frozen docs on gh-pages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions