Repository navigation
Regression: carousel data-touch="false" not working #32629
Description
Activity
- addedjsJavaScript or TypeScript sources and pluginsJavaScript or TypeScript sources and pluginsv4v4, the frozen docs on gh-pagesv4, the frozen docs on gh-pagesv5v5, the v5-dev branchv5, the v5-dev branchregressionA bug that did not happen in an earlier releaseA bug that did not happen in an earlier release
on Dec 27, 2020 where is the actual
data-touchdata attribute queried? is that part of some more generic "grab anything that's a data attribute and shove it into the_configobject" type logic?as I always find it difficult to debug this sort of thing easily, and also because it would be nice to actually provide a live example, i made this provisional PR here to add a carousel without touch to the docs #32638
using the added example from #32638 I can confirm that https://deploy-preview-32638--twbs-bootstrap.netlify.app/docs/5.0/components/carousel/#suppressing-touch-swiping when tested on iOS, Android, and a Surface with touchscreen still reacts to touch/swipe despite the
data-touch="false"attributeturns out i was being a moron - this actually works in v5 if using the correct
data-bs-touch="false". now wondering how to test the reported issue in 4.5...ok, having now tested this in v4.5 as well, it seems there is no actual problem with
data-touch="false". #32639closing.
A fresh version of this #28025 (comment)
It seems somehow the code that was added here #28046 has been lost at some point.
[edit: correction, as @rohit2sharma95 pointed out, the code is actually still there - i somehow managed to miss it while checking the code yesterday. so the problem may be deeper somehow]