Skip to content

Move dropdown offset function logic into private function - #28138

Merged
XhmikosR merged 1 commit into
twbs:v4-devfrom
jgolieb:dropdown-offset-fn
Feb 5, 2019
Merged

XhmikosR merged 1 commit into
twbs:v4-devfrom
jgolieb:dropdown-offset-fn

Conversation

@jgolieb

@jgolieb jgolieb commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

This makes the dropdown offset function work the same as for tooltips as in #28130.

@jgolieb
jgolieb requested a review from a team as a code owner January 29, 2019 20:40
Comment thread js/tests/unit/dropdown.js Outdated
@XhmikosR

XhmikosR commented Feb 5, 2019 •

Copy link
Copy Markdown
Member

I don't understand the point of this PR. Isn't this in #28130?

EDIT: I need more coffee. This is for the dropdown.

@mdo mdo mentioned this pull request Feb 5, 2019
@XhmikosR
XhmikosR merged commit e44d047 into twbs:v4-dev Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants