Repository navigation
Add support for tooltip offset option to be a function - #28130
Merged
Merged
Conversation
Johann-S
requested changes
Jan 29, 2019
Johann-S
left a comment
Johann-S
left a comment
Member
There was a problem hiding this comment.
Can you move the logic in a private method please and can you add unit tests please
Member
|
@XhmikosR it seems we have some issues with Bundlesize, the github token is not found https://travis-ci.org/twbs/bootstrap/jobs/486082928#L833 |
Johann-S
reviewed
Jan 30, 2019
Member
|
Just one comment and it'll be alright 👍 |
Member
|
@Johann-S the GH token isn't (and wasn't) available for PRs made by people without push rights, same as Browser Stack. The build fails here due to the bundlesize limit. We'll need to increase bootstrap.js limit a bit. |
Johann-S
approved these changes
Jan 30, 2019
XhmikosR
force-pushed
the
popper-offset-fn
branch
from
February 5, 2019 08:20
63a2622 to
7557bd8
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24223