Skip to content

Fixed issue #17754 - #17933

Closed
daleparkerwinston wants to merge 3 commits into
twbs:masterfrom
daleparkerwinston:master
Closed

daleparkerwinston wants to merge 3 commits into
twbs:masterfrom
daleparkerwinston:master

Conversation

@daleparkerwinston

Copy link
Copy Markdown

Updated js/tab.js to work with <ol> along with <ul>
Fixes #17754.

Updated js/tab.js to work with <ol> along with <ul>
Comment thread js/tab.js Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to duplicate the :not part too.

@cvrebert cvrebert added js JavaScript or TypeScript sources and plugins v3 Legacy: v3 labels Oct 15, 2015
Updated js/tab.js to be able to work with <ol> as well as <ul>.
Comment thread js/tab.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this

Updated tab.js to be able to work with <ol> as well as <ul>.
@cvrebert cvrebert added this to the v3.3.6 milestone Oct 15, 2015
@mdo mdo modified the milestones: v3.3.6, v3.3.7 Nov 24, 2015
@cvrebert cvrebert modified the milestones: v3.3.7, v3.3.8 Jul 25, 2016
@mdo

mdo commented Sep 5, 2016

Copy link
Copy Markdown
Member

Bootstrap 3 is no longer being officially developed or supported.

All work has moved onto our next major release, v4. As such, this issue or pull request is being closed as a "won't fix." For additional help and support, we recommend utilizing our community resources. Thanks for your understanding, and see you on the other side of v4!

<3,
@mdo and team

@mdo mdo closed this Sep 5, 2016
@mdo mdo modified the milestone: v3.3.8 Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

js JavaScript or TypeScript sources and plugins v3 Legacy: v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants