Repository navigation
Tab plugin should use a class selector instead of a ul tag selector #17754
Description
Hello. I want to use <ol> instead of <ul>, but in the Tab plugin tag name is hardcoded.
https://github.com/twbs/bootstrap/blob/master/js/tab.js#L28
var $ul = $this.closest('ul:not(.dropdown-menu)')
Activity
cvrebert commentedon Oct 1, 2015
Why?
[-]Tag name hardcoded[/-][+]Tab plugin only works with <ul>, not <ol>[/+]Invis1ble commentedon Oct 1, 2015
Because I have an ordered list.
cvrebert commentedon Oct 1, 2015
And you have an ordered list because...?
[-]Tab plugin only works with <ul>, not <ol>[/-][+]Tab plugin should use a class selector instead of a ul tag selector[/+]Invis1ble commentedon Oct 1, 2015
Because it is an ordered dataset from database and it should be displayed as an orderd list of tabs. It is semantic, isn't it?
Fixed issue twbs#17754
Fixed issue twbs#17754
Fixed issue twbs#17754
add support for ol in tab plugin. fixes twbs#17754