fix(background-checks): move admin actions into the status card footer#2998
Merged
Conversation
The Retry/Cancel/Delete buttons rendered as a stray row between the exempt toggle and the status card. Render them inside the status card at the bottom (below a divider) via a new actions slot on BackgroundCheckStatusView, so the actions sit with the check they act on. The divider lives in BackgroundCheckAdminActions so it only shows when there are buttons. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
claudfuen
pushed a commit
that referenced
this pull request
Jun 2, 2026
# [3.67.0](v3.66.2...v3.67.0) (2026-06-02) ### Bug Fixes * **api:** guarantee non-null SoA justification on YES defaults ([7f564df](7f564df)) * **api:** include a default justification on SoA ([732f262](732f262)) * **app:** able to edit the justification ([2939178](2939178)) * **app:** fix empty justification issue on SoA ([43fa889](43fa889)) * **app:** keep SoA justification dialog open when save fails ([a5621cb](a5621cb)) * **app:** return a generic default when no family match on SoA ([6682be1](6682be1)) * **app:** show default justification at all times on SoA ([13f468a](13f468a)) * **background-checks:** move admin actions into the status card footer ([#2998](#2998)) ([dcd4b4d](dcd4b4d)) * **people:** stop tracking background checks for auditor-only members (CS-416) ([#2995](#2995)) ([4e7d57d](4e7d57d)) ### Features * **admin:** add Finding Templates management to admin panel ([c381397](c381397)) * **background-checks:** admin cancel/delete/retry (CS-475) ([#2993](#2993)) ([51c3b3d](51c3b3d)) * **background-checks:** hourly reconciliation for stuck checks (CS-473) ([#2996](#2996)) ([3d6e609](3d6e609))
Contributor
|
🎉 This PR is included in version 3.67.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move background-check admin actions into the status card
Follow-up UX tweak to CS-475 (#2993).
Problem
The Retry / Cancel / Delete buttons rendered as a stray row floating between the "Exempt this employee" toggle and the Status card — they looked orphaned.
Fix
Render the actions inside the Status card, at the bottom (below a divider), so they sit with the check they act on:
actions?: ReactNodeslot toBackgroundCheckStatusView, rendered as the last item in the status card.EmployeeBackgroundChecknow passesBackgroundCheckAdminActionsinto that slot instead of rendering it standalone above the card.border-tdivider lives insideBackgroundCheckAdminActions, so it only appears when there are actually buttons to show (read-only users / no-op states render nothing — no empty divider).Before → After
Tests
BackgroundCheckAdminActions6/6 andEmployeeBackgroundCheck17/17 still pass (buttons are queried by role; placement change doesn't affect them).tscclean on the three changed files; design-system audit clean (no legacy/lucide imports;classNameonly on a<div>).🤖 Generated with Claude Code
Summary by cubic
Move background-check admin actions into the status card footer to keep Retry/Cancel/Delete with the check they control and fix the stray row. Follow-up to Linear CS-475.
actionsslot toBackgroundCheckStatusViewand render it at the end of the card.EmployeeBackgroundChecknow passesBackgroundCheckAdminActionsinto that slot; removed the standalone row.BackgroundCheckAdminActionsso it only shows when buttons render.Written for commit da72dea. Summary will update on new commits.