fix(people): stop tracking background checks for auditor-only members (CS-416) by Marfuen · Pull Request #2995 · trycompai/comp

Marfuen · 2026-06-02T19:14:38Z

CS-416 — Stop tracking background checks for auditor-only members

Relates to: https://linear.app/compai/issue/CS-416 (sub-issue of CS-475)

Problem

Auditor-only members (external reviewers) were still surfaced as needing a background check in the people area, which confused customers.

Fix

Treat auditor-only members (every comma-separated role is auditor) as not subject to the background-check requirement:

People score (apps/api/src/frameworks/frameworks-people-score.helper.ts): auditor-only members no longer count toward the BG-check requirement (alongside the existing backgroundCheckExempt exclusion).
Employee detail page (Employee.tsx): the Background Check tab + header status are hidden for auditor-only members.
The people-list row was already gated (MemberRow.tsx !isAuditorOnly).
Extracted a small, tested isAuditorOnly helper.

A member with auditor plus another role still requires a check (they carry the other role's obligations).

Tests

API (jest): frameworks-people-score.helper.spec.ts → 10/10 (adds auditor-only and auditor+employee cases).
App (vitest): isAuditorOnly.test.ts → 4/4.
tsc clean on changed files; no new lint.

🤖 Generated with Claude Code

Summary by cubic

Stops tracking background checks for auditor-only members to avoid confusing customers. Auditor-only users are excluded from the requirement and related UI, matching CS-416.

Bug Fixes
- People score: exclude auditor-only members from background-check requirements (still required if auditor is combined with another role).
- Employee page: hide Background Check tab and header for auditor-only members.
- Add isAuditorOnly helper (shared logic) with tests; expand API tests for auditor-only and mixed-role cases.

^{Written for commit 06e2552. Summary will update on new commits.}

… (CS-416) Auditor-only members are external reviewers and aren't subject to people-security requirements. Exclude them from the background-check requirement in the people score and hide the Background Check tab/header on their detail page (the people-list row was already gated). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Marfuen · 2026-06-02T19:14:40Z

@cubic-dev-ai ultrareview this

linear · 2026-06-02T19:14:43Z

CS-416

cubic-dev-ai · 2026-06-02T19:14:43Z

@cubic-dev-ai ultrareview this

@Marfuen Ultrareview monthly budget exhausted (12/12 used). Budget resets at the start of next month.

vercel · 2026-06-02T19:14:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app	Ready	Preview, Comment	Jun 2, 2026 7:18pm
comp-framework-editor	Ready	Preview, Comment	Jun 2, 2026 7:18pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
portal	Skipped		Jun 2, 2026 7:18pm

Marfuen · 2026-06-02T19:28:56Z

@cubic-dev-ai review this

cubic-dev-ai · 2026-06-02T19:29:06Z

@cubic-dev-ai review this

@Marfuen I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

cubic analysis

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

Linked issue analysis

Linked issue: CS-416: Remove background check requirement from Auditor roles in the people tab

Status	Acceptance criteria	Notes
✅	Exclude auditor-only members from the background-check requirement in people-score computation	computePeopleScore was updated to skip auditor-only members when computing whether a member requires a background check, and tests were added to verify auditor-only vs auditor+other-role behavior.
✅	Hide Background Check tab and header/status on the Employee detail page for auditor-only members	Employee page now computes showBackgroundCheck using isAuditorOnly and conditionally omits the Background Check tab, content, and background-check-related props.
✅	Ensure a member who is auditor plus another role still requires a background check	Tests exercise a mixed-role member (auditor,employee) and assert that a background check is still required.
✅	Add a shared isAuditorOnly helper with unit tests	A new isAuditorOnly helper was added and covered by vitest unit tests for empty, single, multiple, and mixed-role inputs.
✅	People-list row does not show background check for auditor-only members (no user-facing regression)	PR notes the people-list row was already gated; no change required and behavior remains consistent with the fix.

_{Re-trigger cubic}

cubic-dev-ai

cubic analysis

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

Linked issue analysis

Linked issue: CS-416: Remove background check requirement from Auditor roles in the people tab

Status	Acceptance criteria	Notes
✅	Exclude auditor-only members from the background-check requirement in people-score computation	computePeopleScore was updated to skip auditor-only members when computing whether a member requires a background check, and tests were added to verify auditor-only vs auditor+other-role behavior.
✅	Hide Background Check tab and header/status on the Employee detail page for auditor-only members	Employee page now computes showBackgroundCheck using isAuditorOnly and conditionally omits the Background Check tab, content, and background-check-related props.
✅	Ensure a member who is auditor plus another role still requires a background check	Tests exercise a mixed-role member (auditor,employee) and assert that a background check is still required.
✅	Add a shared isAuditorOnly helper with unit tests	A new isAuditorOnly helper was added and covered by vitest unit tests for empty, single, multiple, and mixed-role inputs.
✅	People-list row does not show background check for auditor-only members (no user-facing regression)	PR notes the people-list row was already gated; no change required and behavior remains consistent with the fix.

_{Re-trigger cubic}

# [3.67.0](v3.66.2...v3.67.0) (2026-06-02) ### Bug Fixes * **api:** guarantee non-null SoA justification on YES defaults ([7f564df](7f564df)) * **api:** include a default justification on SoA ([732f262](732f262)) * **app:** able to edit the justification ([2939178](2939178)) * **app:** fix empty justification issue on SoA ([43fa889](43fa889)) * **app:** keep SoA justification dialog open when save fails ([a5621cb](a5621cb)) * **app:** return a generic default when no family match on SoA ([6682be1](6682be1)) * **app:** show default justification at all times on SoA ([13f468a](13f468a)) * **background-checks:** move admin actions into the status card footer ([#2998](#2998)) ([dcd4b4d](dcd4b4d)) * **people:** stop tracking background checks for auditor-only members (CS-416) ([#2995](#2995)) ([4e7d57d](4e7d57d)) ### Features * **admin:** add Finding Templates management to admin panel ([c381397](c381397)) * **background-checks:** admin cancel/delete/retry (CS-475) ([#2993](#2993)) ([51c3b3d](51c3b3d)) * **background-checks:** hourly reconciliation for stuck checks (CS-473) ([#2996](#2996)) ([3d6e609](3d6e609))

claudfuen · 2026-06-02T22:23:47Z

🎉 This PR is included in version 3.67.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

vercel Bot deployed to Preview – app June 2, 2026 19:17 View deployment

vercel Bot deployed to Preview – comp-framework-editor June 2, 2026 19:18 View deployment

Marfuen marked this pull request as ready for review June 2, 2026 19:29

cubic-dev-ai Bot reviewed Jun 2, 2026

View reviewed changes

Marfuen merged commit 4e7d57d into main Jun 2, 2026
10 checks passed

Marfuen deleted the cs-416 branch June 2, 2026 20:00

claudfuen added the released label Jun 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(people): stop tracking background checks for auditor-only members (CS-416)#2995

fix(people): stop tracking background checks for auditor-only members (CS-416)#2995
Marfuen merged 1 commit into
mainfrom
cs-416

Marfuen commented Jun 2, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

Marfuen commented Jun 2, 2026

Uh oh!

linear Bot commented Jun 2, 2026

Uh oh!

cubic-dev-ai Bot commented Jun 2, 2026

Uh oh!

vercel Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

Marfuen commented Jun 2, 2026

Uh oh!

cubic-dev-ai Bot commented Jun 2, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

claudfuen commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Marfuen commented Jun 2, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CS-416 — Stop tracking background checks for auditor-only members

Problem

Fix

Tests

Summary by cubic

Uh oh!

Marfuen commented Jun 2, 2026

Uh oh!

linear Bot commented Jun 2, 2026

Uh oh!

cubic-dev-ai Bot commented Jun 2, 2026

Uh oh!

vercel Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marfuen commented Jun 2, 2026

Uh oh!

cubic-dev-ai Bot commented Jun 2, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

cubic analysis

Linked issue analysis

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

cubic analysis

Linked issue analysis

Uh oh!

Uh oh!

claudfuen commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Marfuen commented Jun 2, 2026 •

edited by cubic-dev-ai Bot

Loading

vercel Bot commented Jun 2, 2026 •

edited

Loading