Claudio/fix hydration#265
Merged
Merged
Conversation
…ls view - Renamed "Mapped Requirements" to "Linked Requirements" in controls table and related components. - Updated error logging message for fetching artifacts to reflect new terminology. - Adjusted localization strings to replace "related artifacts" with "Linked Artifacts".
…ation - Updated RequirementsTable to include framework instance details in the requirements mapping. - Modified SingleControl component to reflect changes in requirementsMapped structure. - Adjusted getControl function to include framework instance in the requirements mapping. - Updated localization strings to include new framework and requirement identifiers.
…ting - Refactored RequirementsTable to replace requirementId with id for improved clarity. - Enhanced cell rendering to display both framework and requirement names. - Removed unnecessary sorting logic for framework and requirementId columns. - Updated initial sorting state to reflect new id accessor.
…rtifact handling - Refactored ArtifactsTable to utilize a new structure for artifacts, integrating evidence and policy details. - Updated SingleControl component to reflect changes in relatedArtifacts structure. - Simplified getRelatedArtifacts function to return artifacts directly without transformation. - Enhanced sorting and filtering logic in ArtifactsTable for better user experience.
…mproved clarity - Removed Alert component from EvidenceDetails to streamline the display of evidence information. - Updated ReviewSection to show evidence name in the header and description in the subtitle for better context.
… data display - Added RequirementsTable component to SingleControl for displaying control requirements. - Removed commented-out code for RequirementsTable to clean up the component structure.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
|
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates several control components by refining and standardizing their data types and logic. Artifact and requirement structures now include additional properties (such as evidence, policy, and frameworkInstance) and use updated sorting, filtering, and routing functions. Adjustments include renaming terminology from “Mapped/Related” to “Linked”, removing obsolete UI elements and debugging logs, and updating locale strings. Import paths and table configurations are also modified to align with the new data representations. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant AT as ArtifactsTable
participant Router as Router
U->>AT: Clicks on an artifact row
AT->>AT: getRowId(row)
alt row.type is "policy"
AT->>Router: Navigate to /policies/{policyId}
else row.type is "evidence"
AT->>Router: Navigate to /evidence/{evidenceId}
else
AT->>Router: Navigate to /artifacts/{id}
end
Possibly Related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (12)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit