Lewis/shared tables

[carhartlewis]

Summary by CodeRabbit

• New Features

  • Introduced a refreshed controls table with optimized sorting, filtering, and loading states for an improved dashboard view.
  • Added efficient data retrieval with caching to enhance performance in both controls and policies sections.

• Refactor

  • Replaced legacy components and simplified asynchronous logic for a more streamlined and responsive user interface.
  • Updated the controls page structure to provide smoother data transitions and better loading feedback.

• Style

  • Refined pagination dropdown positioning and adjusted visual status indicators for clearer, more consistent display.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Apr 3, 2025 6:54pm
comp-portal	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Apr 3, 2025 6:54pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request refactors several parts of the dashboard related to controls and policies. It removes outdated components and types for rendering controls, replacing them with new implementations such as the getControlColumns function and an updated ControlsTable component. Database query functions have been adjusted to rely on session data and caching, while search parameter validations and default sort options have been updated. Additionally, some styling and formatting changes are applied across components, and imports as well as authentication and internationalization logic have been simplified or removed.

Changes

File(s)	Change Summary
.../controls/components/ControlsOverview.tsx .../controls/components/ControlsTableColumns.tsx .../controls/components/table/ControlsTable.tsx .../controls/components/table/ControlsTableColumns.tsx .../controls/components/table/ControlsTableHeader.tsx	Removed deprecated components, functions, and types related to legacy controls UI rendering.
.../controls/components/controls-table-columns.tsx	Added new function getControlColumns() to define column definitions for controls using @tanstack/react-table.
.../controls/components/controls-table.tsx	Introduced new ControlsTable React component that uses React.use for promise handling, memoized columns, and renders a data table with pagination and toolbar.
.../controls/data/getAllOrganizationControls.ts	Updated function to be cached and refactored to rely on session data (removing parameter-based organization ID).
.../controls/data/queries.ts	Added new asynchronous function getControls to query control data with caching, filtering, and sorting.
.../controls/data/validations.ts	Introduced new file defining searchParamsCache and exporting type alias GetControlSchema for control query validation.
.../controls/layout.tsx	Removed authentication and internationalization logic; simplified layout to directly render children.
.../controls/page.tsx	Refactored to remove session-based organization ID lookup; updated component and metadata signatures to use asynchronous parameters and search validation.
.../policies/all/(overview)/components/policies-table.tsx	Removed default sorting configuration from initial state of the data table.
.../policies/all/(overview)/data/validations.ts	Modified default sorting from createdAt (desc) to name (asc); removed the updatedAt parameter from search parameters.
.../policies/all/(overview)/page.tsx	Updated import path for searchParamsCache to reflect new module location.
.../components/data-table/data-table-pagination.tsx	Applied formatting adjustments and modified dropdown alignment; added styling changes to icon components.
.../components/frameworks/framework-status.tsx	Made minor styling modifications by altering a class name affecting the display of the status indicator.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant CP as ControlsPage
    participant QC as getControls Query
    participant DB as Database
    participant CT as ControlsTable

    U->>CP: Request Controls Page
    CP->>QC: Invoke getControls(input)
    QC->>DB: Query controls with filters & sorting
    DB-->>QC: Return control data & page count
    QC-->>CP: Provide queried data
    CP->>CT: Render table using getControlColumns()
    CT-->>U: Display controls table with pagination & toolbar

Loading

Poem

I'm a rabbit, leaping with delight,
Hoping through new code, swift and bright.
Components reformed and queries in tune,
Data flows like a summer afternoon.
With changes sprightly as a bunny's run 🐇.
CodeRabbit cheers for every new sun!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8afcd6 and 1b54cab.

⛔ Files ignored due to path filters (2)

• packages/data/dist/index.d.mts is excluded by !**/dist/**
• packages/data/dist/index.d.ts is excluded by !**/dist/**

📒 Files selected for processing (17)

• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/ControlsOverview.tsx (0 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/ControlsTableColumns.tsx (0 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/controls-table-columns.tsx (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/controls-table.tsx (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/table/ControlsTable.tsx (0 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/table/ControlsTableColumns.tsx (0 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/table/ControlsTableHeader.tsx (0 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/data/getAllOrganizationControls.ts (2 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/data/queries.ts (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/data/validations.ts (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/layout.tsx (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/page.tsx (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/components/policies-table.tsx (0 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/data/validations.ts (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/page.tsx (1 hunks)
• apps/app/src/components/data-table/data-table-pagination.tsx (1 hunks)
• apps/app/src/components/frameworks/framework-status.tsx (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.