Repository navigation
docs(fork): retain same-task follow-up delivery after upstream fix - #428
Conversation
Refs #212 Co-Authored-By: GPT-6.1-Sol via Codex
|
Independent review, relayed unchanged from the delegated reviewer (GPT-6.1-Sol via Codex): PASS. Reviewed head
Evidence limits: reviewed supplied logs and patch without rerunning tests. No pristine-upstream or live verification claimed. No edits or GitHub posts made. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Review round 1 at exact head
Ready for the final train review and the user's merge decision. 🤖 Claude Opus 5.5 planner via Claude Code in T3 Code |
…rk contracts Upstream's newer Stop, queue and follow-up behavior collided with retained fork contracts and left 35 focused tests failing. - A usage-limit continuation the user re-armed after Stop now resumes that thread through the retirement guard, which rechecks the arm at commit. - A failed Codex root still settles at once, but stays reachable so Stop and cut-in reach its live child and background processes (fork #332). - Tests now model the fork's same-task follow-ups (#213/#428), parked completions (#431), per-Stop retirement tokens and upstream's message-led queue release, instead of upstream's fresh-task and dispose-on-Stop shapes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What: Keep the same-task follow-up delivery adaptation; upstream fixes the notification bug with a different task lifecycle.
Why: Removing the carried non-test behavior breaks 13 behavioral tests plus the continuation-guidance test on the already-absorbed upstream base.
So what: This registry-only PR clarifies the retained purpose and watched files; the #411 absorption must keep this adaptation unless it deliberately migrates the fork's task lifecycle.
Retire check, 2026-10-18
This supports the Objective's delegated Drafters by preserving follow-up delivery without changing their task identity.
chore/212-retire-child-follow-up-wake,/home/luke/.t3/worktrees/chromeria/chore-212-retire-child-follow-up-wake; clean starting HEADdfb9235811e8d9b76f4713c383301e1a220364ce, matching liveorigin/main.c572cb71d2711d8cdb4ff7e0ba88af5e9a23aa81. Read the complete 14-file diff. #13490 closed at 05:10:12Z. Candidates #14030, #15004 and #13338 are unmerged.git log upstream/main --oneline --grep='17696'finds the fix. Bothgit merge-base --is-ancestor c572cb71d2711d8cdb4ff7e0ba88af5e9a23aa81 f798cb299ac9eab9d51ef63b5159de14a2b6aa18and the same command againstd0918f1659f4c19172796c8d1910ca6e4bc18b51exit 0. No detached worktree or write in the chore(fork): daily upstream absorption through d0918f1659 #411 worktree was needed.Equivalence boundary
Upstream's
recordSubagentFollowupcreates a fresh delegated task, node and turn item after the original result. Each task has its own pending delivery. It excludes notifications, schedules and restart-continuation intake. Its completed-follow-up regression also finishes a Monitor run and verifies no extra result transfer or task mutation.The fork deliberately changed this during absorption, recorded in
04770c9147e8940641edb7a818f93803b371564a(wip: preserve native follow-up identity and fork result delivery). CurrentrecordSubagentFollowupbinds later requested runs tooriginal.id, andchildThreads/delegatedFollowups.tsselects and recovers results per run. The retained #212 contract keeps the first summary/result stable while showing later results aslatestTerminal*. With that same-task lifecycle, upstream's normal completion planner sees an acknowledged/delivered result and will not reserve another wake. The carried rearming and stable-result handling are still required.Removal proof
Used Node 24.15.0 and pnpm 11.10.0 through a disposable npm execution environment because this shell had Node 26 and no pnpm. Installed dependencies only in this task worktree. No versions changed.
Exact focused command, run before removal, with removal, and after restoration:
expected 'acknowledged' to equal 'claimed'. Previously stopped and wait-mode parent regressions fail the same way. MCP integration observes the original summary overwritten with the follow-up response. These are behavior failures, not compilation or dependency failures.Orchestrator.tsand the three instruction sites, following the instruction-file moves since fix(server): a delegated child's finished follow-up turn wakes its parent #213. Reverted stable-result handling, delivery rearming, forced async policy, parent-cohort reopening, and follow-up suppression of original node/card rewrites. Retained upstream per-run deduplication and unrelated later restart/Stop/Prism hooks. All tests remained byte-for-byte unchanged. This is a removal experiment inside the current fork, not a claim to have run a pristine upstream checkout or migrated the fork back to fresh tasks.git diff --quietexited 0 before the registry edit. The delivered diff changes only the registry purpose, shared-file coverage and keywords.node scripts/fork-features.mjs checkpasses, 42 features.git diff --checkpasses.No runtime change, server, browser, live database, Rocky work or repo-wide check. No version bump. No feature-map part is added, removed or shipped; the registry entry remains carried. No website impact: maintainer registry metadata only.
Elon record
Requirements and who asked: User requested an evidence-based retire check of #213, keeping its regressions and Monitor exclusion; #212 also requires stable first-result semantics.
Deleted: The proposed wholesale retirement was rejected by removal proof; no new task model, runtime patch or test rewrite is needed.
Bottleneck: Same-task completion-delivery state, not missing upstream code: upstream's fresh-task design is already in both bases.
Checked myself: Read upstream #17696's entire diff, verified both ancestry relationships, inspected the fork's identity-preserving intake, and ran the retained tests before removal, with the edit removed, and after restoration.
Refs #212
Model and harness: GPT-6.1-Sol via Codex in T3 Code.