Skip to content

fix(promachos): readable outbound bubbles and no turn navigator - #207

Merged
lukemaj merged 1 commit into
mainfrom
fix/promachos-v2-sidebar-bubbles
Oct 9, 2026
Merged

lukemaj merged 1 commit into
mainfrom
fix/promachos-v2-sidebar-bubbles

Conversation

@lukemaj

@lukemaj lukemaj commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

What: Promachos chats show the user's text in its dark bubble again, and the timeline minimap no longer appears in Promachos mode.
Why: On v2 the user message body hardcodes text-foreground, the same color the outbound bubble uses as its surface; the minimap was never gated by the Promachos presentation.
So what: Needs the developer's merge approval; after merge it gets staged on cavallo per the runbook.

Fix

  • PROMACHOS_OUTBOUND_BUBBLE_CLASS_NAME re-inks the body's .text-foreground with the bubble's message foreground (fork-owned file, no upstream edit).
  • MessagesTimeline derives no minimap items in Promachos presentation, so the rail renders nothing.

Sidebar report (no change)

On cavallo, chromeria-v2.sqlite and the old state.sqlite both hold one top-level conversation in the promachos home ("Greeting") plus three child Drafters (sub.08f96689-...). The sidebar lists top-level conversations only, so one row is the correct data, not a lost import.

Proof

  • vp test run src/components/promachos src/components/chat/MessagesTimeline.test.tsx: 5 files, 101 tests passed.
  • apps/web typecheck passed; lint shows only pre-existing warnings.
  • Not verified in a real client; no before/after screenshots (browser use not authorized).

Elon record

Requirements and who asked: The developer: readable user bubbles and no minimap in Promachos mode.
Deleted: Sidebar change; the data shows the list is correct.
Bottleneck: Finding the hardcoded text-foreground in UserMessageBody.
Checked myself: Read cavallo's databases read-only; ran the tests and typecheck above.

Opus 5.5 via Claude Code in T3 Code.

🤖 Generated with Claude Code

On v2 the user's message body paints itself text-foreground, which is the
outbound bubble's surface color, so the text vanished. The bubble now
re-inks that body. The timeline minimap also showed in Promachos chats;
it is now hidden there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +7 B (+0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +7 B (+0.6%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 18229e6 · PR result: 2882087 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@lukemaj
lukemaj merged commit 061ebef into main Oct 9, 2026
26 checks passed
@lukemaj
lukemaj deleted the fix/promachos-v2-sidebar-bubbles branch October 9, 2026 18:09
lukemaj added a commit that referenced this pull request Oct 14, 2026
On v2 the user's message body paints itself text-foreground, which is the
outbound bubble's surface color, so the text vanished. The bubble now
re-inks that body. The timeline minimap also showed in Promachos chats;
it is now hidden there.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant