Repository navigation
test(desktop): cover external reply-link navigation - #6251
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds an end-to-end test for external reply links and a Windows smoke-test checklist item. It also adds spacing in the test coverage matrix and reformats two Rust test assertions. ChangesExternal reply-link validation
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
A rabbit clicks a link with care Comment |
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
Requesting changes: 2 lane(s) blocking, worst finding is high.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0166 · 183,297 in / 2,536 out · 1,792 cached (1%) · openrouter/openai/text-embedding-3-small, deepseek/deepseek-v4-flash · 603 embedded
critique: $0.0083 · 91,664 in / 1,383 out · 512 cached (1%) · deepseek/deepseek-v4-flash
security: $0.0058 · 64,707 in / 929 out · 1,280 cached (2%) · deepseek/deepseek-v4-flash
tests: $0.0016 · 17,446 in / 144 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0009 · 9,480 in / 80 out · 0 cached (0%) · deepseek/deepseek-v4-flash
Tiny Sweeper reviewTiny Sweeper completed its review; deterministic results follow. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedAdds a new E2E test to cover external reply-link navigation on desktop, updates the Windows release smoke checklist to include a check for chat links preserving the desktop UI, and removes an obsolete layout exception entry. Features
Tests
FindingsPreviously reported and still active
Resolved this pass
Before merge
How this fits togetherflowchart LR
n0["threadId"]:::impacted
n1["file"]:::impacted
n2["startNewThread"]:::impacted
n3["directory"]:::impacted
n0 -->|calls| n2
n1 -->|uses| n3
n2 -->|uses| n0
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
tinysweeper
Bot
added
the
priority: p1
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92c6ef194b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
The previously-blocking findings are resolved. Clearing the changes request.
$0.0407 · 92,411 in / 17,589 out · 19,709 cached (21%) · openrouter/openai/text-embedding-3-small, z-ai/glm-5.2, deepseek/deepseek-v4-flash · 616 embedded
critique: $0.0208 · 38,403 in / 9,066 out · 9,109 cached (24%) · z-ai/glm-5.2, deepseek/deepseek-v4-flash
security: $0.0022 · 25,906 in / 245 out · 2,560 cached (10%) · deepseek/deepseek-v4-flash
tests: $0.0016 · 18,031 in / 235 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0161 · 10,071 in / 8,043 out · 8,040 cached (80%) · z-ai/glm-5.2
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Requesting changes: 2 lane(s) blocking, worst finding is high.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0401 · 219,148 in / 13,995 out · 25,034 cached (11%) · openrouter/openai/text-embedding-3-small, deepseek/deepseek-v4-flash, z-ai/glm-5.2 · 665 embedded
critique: $0.0137 · 111,346 in / 4,178 out · 8,414 cached (8%) · deepseek/deepseek-v4-flash, z-ai/glm-5.2
security: $0.0111 · 78,857 in / 3,210 out · 8,830 cached (11%) · deepseek/deepseek-v4-flash, z-ai/glm-5.2
tests: $0.0017 · 18,315 in / 214 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0137 · 10,630 in / 6,393 out · 7,790 cached (73%) · z-ai/glm-5.2
|
@tinysweeper Please reassess the changes request on
No production changes were needed after checking these findings. Please clear the changes request if this evidence resolves the concerns. I have not dismissed the review or marked its threads resolved on the reviewer's behalf. |
There was a problem hiding this comment.
Requesting changes: 2 lane(s) blocking, worst finding is high.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0433 · 225,498 in / 15,731 out · 32,607 cached (14%) · openrouter/openai/text-embedding-3-small, deepseek/deepseek-v4-flash, z-ai/glm-5.2 · 665 embedded
critique: $0.0279 · 114,807 in / 10,873 out · 22,161 cached (19%) · deepseek/deepseek-v4-flash, z-ai/glm-5.2
security: $0.0127 · 81,157 in / 3,761 out · 10,446 cached (13%) · deepseek/deepseek-v4-flash, z-ai/glm-5.2
tests: $0.0017 · 18,714 in / 219 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0011 · 10,820 in / 878 out · 0 cached (0%) · deepseek/deepseek-v4-flash
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The Cargo.lock file is updated to include the tracing crate as a dependency for the openhuman-app package, ensuring the lockfile stays in sync with the project's dependency requirements. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Reformat two test files to break long method chains and assertion expressions across multiple lines, improving readability without changing any logic or test behavior. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
@tinysweeper Please reassess the current head |
The agent-runtime-boundary baseline and legacy layout limits are refreshed to match the current line numbers after recent refactoring in the Rust codebase. The boundary markers shifted due to code movement, and the two spawn subagent tool files grew slightly, so their pinned limits are raised accordingly. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
@tinysweeper Please reassess current head |
The import of `TranscriptCodec` from `tinyagents_runtime` was unused in this file, so it has been removed to keep the code clean and avoid compiler warnings. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
# Conflicts: # scripts/ci/check-openhuman-rust-layout.mjs
There was a problem hiding this comment.
Requesting changes: 1 lane(s) blocking, worst finding is high.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0084 · 126,024 in / 30,774 out · 28,118 cached (22%) · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 372 embedded
critique: $0.0019 · 32,162 in / 2,283 out · 4,828 cached (15%) · gpt-5.6-luna, deepseek/deepseek-v4-flash
security: $0.0015 · 28,696 in / 973 out · 1,786 cached (6%) · gpt-5.6-luna
tests: $0.0017 · 32,691 in / 17,877 out · 1,280 cached (4%) · deepseek/deepseek-v4-flash
description: $0.0017 · 8,886 in / 5,377 out · 1,280 cached (14%) · deepseek/deepseek-v4-flash
e2e: $0.0007 · 19,020 in / 1,686 out · 18,944 cached (100%) · deepseek/deepseek-v4-flash
…l.rs The file `spawn_subagent_tool_impl.rs` no longer needs a legacy line‑count exemption, so its entry is removed from the limits map to keep the configuration current. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
senamakel
changed the title
|
@tinysweeper Please reassess current head |
There was a problem hiding this comment.
The previously-blocking findings are resolved. Clearing the changes request.
$0.0019 · 12,633 in / 5,662 out · 4,343 cached (34%) · ladder/vectors, deepseek/deepseek-v4-flash · 334 embedded
description: $0.0010 · 9,071 in / 1,689 out · 1,280 cached (14%) · deepseek/deepseek-v4-flash
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0120 · 185,314 in / 15,263 out · 16,598 cached (9%) · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 334 embedded
critique: $0.0061 · 106,266 in / 4,667 out · 6,361 cached (6%) · gpt-5.6-luna, deepseek/deepseek-v4-flash
security: $0.0037 · 67,267 in / 2,763 out · 5,373 cached (8%) · gpt-5.6-luna
description: $0.0014 · 8,177 in / 4,130 out · 1,280 cached (16%) · deepseek/deepseek-v4-flash
2 participants
Summary
spawn_subagent_tool_impl.rslayout exception now that the file is below the general 750-line limit.The production external-navigation fix and its focused Rust/TypeScript tests are already present on
main; after merging currentmain, this PR now supplies the remaining end-to-end and release-validation coverage.Submission Checklist
main; this PR does not alter that entry.example.comonly as inert URL data.Validation
cargo fmt --all -- --checkpnpm rust:layoutnode scripts/ci/check-agent-runtime-boundary.mjs-D warningscargo clippy -p openhuman-embed --all-targets -- -D warningscargo test -p openhuman-embed(77 unit tests, integration tests, and 5 doc tests passed)cargo clippy -p openhuman-tinyhumans --all-targets -- -D warningsValidation Blocked
command:The added desktop E2E case.error:This checkout has no desktop E2E session, so it was not run locally.impact:CI and the documented release smoke cover the execution environments; the mocked case is committed for the desktop suite.Impact
Test and release-validation coverage only. The E2E explicitly verifies that opener failure does not call
window.open, because doing so would reproduce the remote-navigation bug. It also verifies the app URL, selected thread, and mounted chat remain unchanged.Related
AI Authored PR Metadata
fix/desktop-external-link-navigation